refactor: changed method name and removed useless data

This commit is contained in:
Andrea Lamparelli 2023-06-22 17:57:49 +02:00
parent 99fbcc39cc
commit a30b6d6290
8 changed files with 19 additions and 34 deletions

View file

@ -25,8 +25,7 @@ export default class GitServiceFactory {
* @param type git management service type
* @param auth authentication, like github token
*/
// TODO rename to getOrCreate
public static init(type: GitServiceType, auth: string): void {
public static getOrCreate(type: GitServiceType, auth: string): void {
if (GitServiceFactory.instance) {
GitServiceFactory.logger.warn("Git service already initialized!");

View file

@ -12,8 +12,8 @@ export interface GitPullRequest {
assignees: string[],
targetRepo: GitRepository,
sourceRepo: GitRepository,
nCommits: number, // number of commits in the pr
commits: string[], // merge commit or last one
nCommits?: number, // number of commits in the pr
commits?: string[], // merge commit or last one
branchName?: string,
}