Warnings-- (~T() override)

Consistently use
	~T() override;
in class declarations (so no virtual in front, and avoid
warnings due to the missing override in back).

src/calamares/CalamaresApplication.h

@@ -30,7 +30,7 @@ class CalamaresApplication : public QApplication
     Q_OBJECT
 public:
     CalamaresApplication( int& argc, char* argv[] );
-    virtual ~CalamaresApplication();
+    ~CalamaresApplication() override;
 
     /**
      * @brief init handles the first part of Calamares application startup.

src/libcalamares/CppJob.h

@@ -28,7 +28,7 @@ class DLLEXPORT CppJob : public Job
     Q_OBJECT
 public:
     explicit CppJob( QObject* parent = nullptr );
-    virtual ~CppJob();
+    ~CppJob() override;
 
     void setModuleInstanceKey( const Calamares::ModuleSystem::InstanceKey& instanceKey );
     Calamares::ModuleSystem::InstanceKey moduleInstanceKey() const { return m_instanceKey; }

src/libcalamares/Job.h

@@ -86,7 +86,7 @@ class DLLEXPORT Job : public QObject
     Q_OBJECT
 public:
     explicit Job( QObject* parent = nullptr );
-    virtual ~Job();
+    ~Job() override;
 
     /** @brief The job's (relative) weight.
      *

src/libcalamares/JobQueue.cpp

@@ -53,7 +53,7 @@ public:
     {
     }
 
-    virtual ~JobThread() override;
+    ~JobThread() override;
 
     void finalize()
     {

src/libcalamares/JobQueue.h

@@ -25,7 +25,7 @@ class DLLEXPORT JobQueue : public QObject
     Q_OBJECT
 public:
     explicit JobQueue( QObject* parent = nullptr );
-    virtual ~JobQueue();
+    ~JobQueue() override;
 
     static JobQueue* instance();
 

src/libcalamares/PythonHelper.h

@@ -48,7 +48,7 @@ public:
     static Helper* instance();
 
 private:
-    virtual ~Helper();
+    ~Helper() override;
     explicit Helper();
 
     boost::python::object m_mainModule;

src/libcalamares/locale/LabelModel.h

@@ -36,7 +36,7 @@ public:
     };
 
     LabelModel( const QStringList& locales, QObject* parent = nullptr );
-    virtual ~LabelModel() override;
+    ~LabelModel() override;
 
     int rowCount( const QModelIndex& parent ) const override;
 

src/libcalamares/locale/TimeZone.h

@@ -94,7 +94,7 @@ public:
     };
 
     RegionsModel( QObject* parent = nullptr );
-    virtual ~RegionsModel() override;
+    ~RegionsModel() override;
 
     int rowCount( const QModelIndex& parent ) const override;
     QVariant data( const QModelIndex& index, int role ) const override;
@@ -126,7 +126,7 @@ public:
     };
 
     ZonesModel( QObject* parent = nullptr );
-    virtual ~ZonesModel() override;
+    ~ZonesModel() override;
 
     int rowCount( const QModelIndex& parent ) const override;
     QVariant data( const QModelIndex& index, int role ) const override;

src/libcalamares/network/Manager.h

@@ -99,7 +99,7 @@ public:
      * to keep the reference.
      */
     static Manager& instance();
-    virtual ~Manager();
+    virtual ~Manager() override;
 
     /** @brief Checks if the given @p url returns data.
      *

src/libcalamares/utils/CalamaresUtilsSystem.h

@@ -126,7 +126,7 @@ public:
      * @param parent the QObject parent.
      */
     explicit System( bool doChroot, QObject* parent = nullptr );
-    virtual ~System();
+    virtual ~System() override;
 
     static System* instance();
 

src/libcalamares/utils/PluginFactory.h

@@ -88,7 +88,7 @@ public:
         Q_PLUGIN_METADATA( IID CalamaresPluginFactory_iid ) \
     public: \
         explicit name(); \
-        ~name(); \
+        ~name() override; \
     };
 #define CALAMARES_PLUGIN_FACTORY_DEFINITION( name, pluginRegistrations ) \
     K_PLUGIN_FACTORY_DEFINITION_WITH_BASEFACTORY( name, CalamaresPluginFactory, pluginRegistrations )

src/libcalamaresui/viewpages/Slideshow.h

@@ -52,7 +52,7 @@ public:
         : QObject( parent )
     {
     }
-    virtual ~Slideshow();
+    ~Slideshow() override;
 
     /// @brief Is the slideshow being shown **right now**?
     bool isActive() const { return m_state == Start; }

src/libcalamaresui/widgets/PrettyRadioButton.h

@@ -38,7 +38,7 @@ class UIDLLEXPORT PrettyRadioButton : public QWidget
     Q_OBJECT
 public:
     explicit PrettyRadioButton( QWidget* parent = nullptr );
-    virtual ~PrettyRadioButton() {}
+    ~PrettyRadioButton() override {}
 
     /// @brief Passes @p text on to the ClickableLabel
     void setText( const QString& text );

src/modules/keyboard/KeyboardPage.cpp

@@ -35,7 +35,7 @@ class LayoutItem : public QListWidgetItem
 public:
     QString data;
 
-    virtual ~LayoutItem();
+    ~LayoutItem() override;
 };
 
 LayoutItem::~LayoutItem() {}

src/modules/keyboard/KeyboardPage.h

@@ -34,7 +34,7 @@ class KeyboardPage : public QWidget
     Q_OBJECT
 public:
     explicit KeyboardPage( QWidget* parent = nullptr );
-    virtual ~KeyboardPage();
+    ~KeyboardPage() override;
 
     void init();
 

src/modules/keyboard/keyboardwidget/keyboardpreview.h

@@ -71,8 +71,8 @@ private:
     QString fromUnicodeString( QString raw );
 
 protected:
-    void paintEvent( QPaintEvent* event );
+    void paintEvent( QPaintEvent* event ) override;
-    void resizeEvent( QResizeEvent* event );
+    void resizeEvent( QResizeEvent* event ) override;
 };
 
 #endif  // KEYBOARDPREVIEW_H

src/modules/locale/Config.h

@@ -52,7 +52,7 @@ class Config : public QObject
 
 public:
     Config( QObject* parent = nullptr );
-    ~Config();
+    ~Config() override;
 
     void setConfigurationMap( const QVariantMap& );
     void finalizeGlobalStorage() const;

src/modules/locale/LocalePage.h

@@ -32,7 +32,7 @@ class LocalePage : public QWidget
     Q_OBJECT
 public:
     explicit LocalePage( class Config* config, QWidget* parent = nullptr );
-    virtual ~LocalePage();
+    ~LocalePage() override;
 
     void onActivate();
 

src/modules/locale/timezonewidget/timezonewidget.h

@@ -66,8 +66,8 @@ private:
     const CalamaresUtils::Locale::ZonesModel* m_zonesData;
     const TimeZoneData* m_currentLocation = nullptr;  // Not owned by me
 
-    void paintEvent( QPaintEvent* event );
+    void paintEvent( QPaintEvent* event ) override;
-    void mousePressEvent( QMouseEvent* event );
+    void mousePressEvent( QMouseEvent* event ) override;
 };
 
 #endif  // TIMEZONEWIDGET_H

src/modules/netinstall/Config.h

@@ -28,7 +28,7 @@ class Config : public QObject
 
 public:
     Config( QObject* parent = nullptr );
-    virtual ~Config();
+    ~Config() override;
 
     enum class Status
     {

src/modules/netinstall/NetInstallPage.h

@@ -35,7 +35,7 @@ class NetInstallPage : public QWidget
     Q_OBJECT
 public:
     NetInstallPage( Config* config, QWidget* parent = nullptr );
-    virtual ~NetInstallPage();
+    ~NetInstallPage() override;
 
     /** @brief Sets the page title
      *

src/modules/tracking/Config.h

@@ -36,7 +36,7 @@ class TrackingStyleConfig : public QObject
 
 public:
     TrackingStyleConfig( QObject* parent );
-    virtual ~TrackingStyleConfig();
+    ~TrackingStyleConfig() override;
 
     void setConfigurationMap( const QVariantMap& );
 

src/modules/users/Config.h

@@ -104,7 +104,7 @@ public:
     using PasswordStatus = QPair< PasswordValidity, QString >;
 
     Config( QObject* parent = nullptr );
-    ~Config();
+    ~Config() override;
 
     void setConfigurationMap( const QVariantMap& );
 

src/modules/users/UsersPage.h

@@ -32,7 +32,7 @@ class UsersPage : public QWidget
     Q_OBJECT
 public:
     explicit UsersPage( Config* config, QWidget* parent = nullptr );
-    virtual ~UsersPage();
+    ~UsersPage() override;
 
     void onActivate();
 

src/modules/welcome/checker/CheckerContainer.h

@@ -32,7 +32,7 @@ class CheckerContainer : public QWidget
     Q_OBJECT
 public:
     explicit CheckerContainer( const Calamares::RequirementsModel& model, QWidget* parent = nullptr );
-    virtual ~CheckerContainer();
+    ~CheckerContainer() override;
 
     bool verdict() const;
 

src/modules/welcome/checker/ResultsListWidget.cpp

@@ -87,7 +87,7 @@ public:
      * or UB happens.
      */
     ResultsListDialog( const Calamares::RequirementsModel& model, QWidget* parent );
-    virtual ~ResultsListDialog();
+    ~ResultsListDialog() override;
 
 private:
     QLabel* m_title;