Clang: fix warnings on partition splitter

- initialize all the fields
 - member-initialization order
 - silence warnings about double<->int
 - drop unused parameter to setSplitPartition
This commit is contained in:
Adriaan de Groot 2017-09-08 07:50:09 -04:00
parent 3aa540a69e
commit 31fa9e4251
3 changed files with 18 additions and 16 deletions

View file

@ -40,9 +40,10 @@ struct PartitionSplitterItem
qint64 size;
Status status;
QVector< PartitionSplitterItem > children;
using ChildVector = QVector< PartitionSplitterItem >;
ChildVector children;
static PartitionSplitterItem null() { return { QString(), QColor(), false, 0, Normal }; }
static PartitionSplitterItem null() { return { QString(), QColor(), false, 0, Normal, ChildVector() }; }
bool isNull() const { return itemPath.isEmpty() && size == 0 && status == Normal; }
operator bool() const { return !isNull(); }
@ -59,8 +60,7 @@ public:
void setSplitPartition( const QString& path,
qint64 minSize,
qint64 maxSize,
qint64 preferredSize,
const QString& newLabel );
qint64 preferredSize );
qint64 splitPartitionSize() const;
qint64 newPartitionSize() const;