From 440b38addf36120b98553598c53d4117feec1f73 Mon Sep 17 00:00:00 2001 From: Kevin Kofler Date: Tue, 25 Nov 2014 19:44:16 +0100 Subject: [PATCH] locale: Optimize guessLCLocale by moving function calls out of loops. --- src/modules/locale/LocalePage.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/modules/locale/LocalePage.cpp b/src/modules/locale/LocalePage.cpp index 136e6967c..6420534a5 100644 --- a/src/modules/locale/LocalePage.cpp +++ b/src/modules/locale/LocalePage.cpp @@ -287,10 +287,11 @@ LocalePage::guessLCLocale() if ( m_localeGenLines.isEmpty() ) return "en_US.UTF-8 UTF-8"; + QString myLanguage = QLocale::languageToString( myLocale.language() ); QStringList linesForLanguage; foreach ( QString line, m_localeGenLines ) { - if ( line.startsWith( QLocale::languageToString( myLocale.language() ) ) ) + if ( line.startsWith( myLanguage ) ) linesForLanguage.append( line ); } @@ -312,10 +313,10 @@ LocalePage::guessLCLocale() } // FIXME: use reverse geocoding to guess the country + QString prefix = myLocale.name(); QStringList linesForLanguageAndCountry; foreach ( QString line, linesForLanguage ) { - QString prefix = myLocale.name(); if ( line.startsWith( prefix ) ) linesForLanguageAndCountry.append( line ); }