branding: Add a dedicated bootloaderEntryName setting.

Use it in the bootloader and grubcfg modules instead of
shortProductName.

src/branding/default/branding.desc

@@ -8,6 +8,7 @@ strings:
     shortVersion:        1.0
     versionedName:       Generic GNU/Linux 1.0 LTS "Rusty Trombone"
     shortVersionedName:  Generic 1.0
+    bootloaderEntryName: Generic
 
 images:
     productLogo:         "squid.png"

src/libcalamaresui/Branding.cpp

@@ -51,7 +51,8 @@ QStringList Branding::s_stringEntryStrings =
     "shortVersion",
     "versionedName",
     "shortVersionedName",
-    "shortProductName"
+    "shortProductName",
+    "bootloaderEntryName"
 };
 
 

src/libcalamaresui/Branding.h

@@ -43,7 +43,8 @@ public:
         ShortVersion,
         VersionedName,
         ShortVersionedName,
-        ShortProductName
+        ShortProductName,
+        BootloaderEntryName
     };
 
     enum ImageEntry : short

src/modules/bootloader/main.py

@@ -54,7 +54,7 @@ def get_uuid():
 
 def create_conf(uuid, conf_path):
     branding = libcalamares.globalstorage.value("branding")
-    distribution = branding["shortProductName"]
+    distribution = branding["bootloaderEntryName"]
     kernel = libcalamares.job.configuration["kernel"]
     img = libcalamares.job.configuration["img"]
     partitions = libcalamares.globalstorage.value("partitions")
@@ -81,7 +81,7 @@ def create_conf(uuid, conf_path):
 
 def create_fallback(uuid, fallback_path):
     branding = libcalamares.globalstorage.value("branding")
-    distribution = branding["shortProductName"]
+    distribution = branding["bootloaderEntryName"]
     kernel = libcalamares.job.configuration["kernel"]
     fb_img = libcalamares.job.configuration["fallback"]
     partitions = libcalamares.globalstorage.value("partitions")
@@ -108,7 +108,7 @@ def create_fallback(uuid, fallback_path):
 
 def create_loader(loader_path):
     branding = libcalamares.globalstorage.value("branding")
-    distribution = branding["shortProductName"]
+    distribution = branding["bootloaderEntryName"]
     timeout = libcalamares.job.configuration["timeout"]
     file_name_sanitizer = str.maketrans(" /", "_-")
     lines = [
@@ -127,7 +127,7 @@ def install_bootloader(boot_loader, fw_type):
         install_path = libcalamares.globalstorage.value("rootMountPoint")
         uuid = get_uuid()
         branding = libcalamares.globalstorage.value("branding")
-        distribution = branding["shortProductName"]
+        distribution = branding["bootloaderEntryName"]
         file_name_sanitizer = str.maketrans(" /", "_-")
         conf_path = os.path.join(
             install_path, "boot", "loader", "entries", "%s.conf" % distribution.translate(file_name_sanitizer))

src/modules/grubcfg/main.py

@@ -67,5 +67,5 @@ def run():
     partitions = libcalamares.globalstorage.value("partitions")
     root_mount_point = libcalamares.globalstorage.value("rootMountPoint")
     branding = libcalamares.globalstorage.value("branding")
-    distributor = branding["shortProductName"]
+    distributor = branding["bootloaderEntryName"]
     return modify_grub_default(partitions, root_mount_point, distributor)