applications/calamares
2
0
Fork 0
mirror of https://github.com/parchlinux/calamares.git synced 2025-07-02 20:05:37 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[users] New test for password-setting

Browse source 
- check new config for accepting empty and bogus passwords
- check a config with minor pw checks for empty and bogus passwords
This commit is contained in:
Adriaan de Groot 2020-08-17 13:11:54 +02:00
parent 1dcf56761f
commit 5f2bbd179c
1 changed files with 56 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

59
src/modules/users/Tests.cpp
View file

@ -19,6 +19,7 @@
#include "Config.h" #include "Config.h"
#include "JobQueue.h"
#include "utils/Logger.h" #include "utils/Logger.h"
#include <QtTest/QtTest> #include <QtTest/QtTest>
@ -45,6 +46,7 @@ private Q_SLOTS:
void testHostActions_data(); void testHostActions_data();
void testHostActions(); void testHostActions();
void testPasswordChecks(); void testPasswordChecks();
void testUserPassword();
}; };
UserTests::UserTests() {} UserTests::UserTests() {}
@ -136,7 +138,8 @@ UserTests::testHostActions()
{ {
m.insert( "setHostname", string ); m.insert( "setHostname", string );
} }
QCOMPARE( getHostNameActions( m ), HostNameActions( result ) | HostNameAction::WriteEtcHosts ); // write bits default to true QCOMPARE( getHostNameActions( m ),
HostNameActions( result ) | HostNameAction::WriteEtcHosts ); // write bits default to true
m.insert( "writeHostsFile", false ); m.insert( "writeHostsFile", false );
QCOMPARE( getHostNameActions( m ), HostNameActions( result ) ); QCOMPARE( getHostNameActions( m ), HostNameActions( result ) );
m.insert( "writeHostsFile", true ); m.insert( "writeHostsFile", true );
@ -149,13 +152,63 @@ UserTests::testPasswordChecks()
{ {
PasswordCheckList l; PasswordCheckList l;
QCOMPARE( l.length(), 0 ); QCOMPARE( l.length(), 0 );
QVERIFY( !addPasswordCheck( "nonempty", QVariant(false), l ) ); // a silly setting QVERIFY( !addPasswordCheck( "nonempty", QVariant( false ), l ) ); // a silly setting
QCOMPARE( l.length(), 0 ); QCOMPARE( l.length(), 0 );
QVERIFY( addPasswordCheck( "nonempty", QVariant(true), l ) ); QVERIFY( addPasswordCheck( "nonempty", QVariant( true ), l ) );
QCOMPARE( l.length(), 1 ); QCOMPARE( l.length(), 1 );
} }
} }
void
UserTests::testUserPassword()
{
if ( !Calamares::JobQueue::instance() )
{
(void)new Calamares::JobQueue( nullptr );
}
{
Config c;
QVERIFY( c.userPassword().isEmpty() );
QVERIFY( c.userPasswordSecondary().isEmpty() );
// There are no validity checks, so no check for nonempty
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Valid );
c.setUserPassword( "bogus" );
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Invalid );
QCOMPARE( c.userPassword(), "bogus" );
c.setUserPasswordSecondary( "bogus" );
QCOMPARE( c.userPasswordValidity(), Config::PasswordValidity::Valid );
}
{
Config c;
QVariantMap m;
m.insert( "allowWeakPasswords", true );
m.insert( "allowWeakPasswordsDefault", true );
m.insert( "defaultGroups", QStringList { "wheel" } );
QVariantMap pwreq;
pwreq.insert( "nonempty", true );
pwreq.insert( "minLength", 6 );
m.insert( "passwordRequirements", pwreq );
c.setConfigurationMap( m );
QVERIFY( c.userPassword().isEmpty() );
QVERIFY( c.userPasswordSecondary().isEmpty() );
// There is now a nonempty check, but weak passwords are ok
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Weak ) );
c.setUserPassword( "bogus" );
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Invalid ) );
c.setUserPasswordSecondary( "bogus" );
QCOMPARE( c.userPasswordValidity(), int( Config::PasswordValidity::Weak ) );
}
}
QTEST_GUILESS_MAIN( UserTests ) QTEST_GUILESS_MAIN( UserTests )