[users] Sanitize tests

- move the testing of config-object methods to its own tests - simplify file structure for the password job tests
2025-07-02 11:55:36 -04:00 · 2020-07-29 13:31:39 +02:00 · 2020-07-29 13:31:39 +02:00 · 892e9798f4
commit 892e9798f4
parent cc1136fb0e
6 changed files with 141 additions and 100 deletions
--- a/src/modules/users/Tests.cpp
+++ b/src/modules/users/Tests.cpp
@ -0,0 +1,113 @@
+/* === This file is part of Calamares - <https://github.com/calamares> ===
+ *
+ *   SPDX-FileCopyrightText: 2020 Adriaan de Groot <groot@kde.org>
+ *   SPDX-License-Identifier: GPL-3.0-or-later
+ *
+ *   Calamares is free software: you can redistribute it and/or modify
+ *   it under the terms of the GNU General Public License as published by
+ *   the Free Software Foundation, either version 3 of the License, or
+ *   (at your option) any later version.
+ *
+ *   Calamares is distributed in the hope that it will be useful,
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ *   GNU General Public License for more details.
+ *
+ *   You should have received a copy of the GNU General Public License
+ *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "Config.h"
+
+#include "utils/Logger.h"
+
+#include <QtTest/QtTest>
+
+// Implementation details
+extern void setConfigurationDefaultGroups( const QVariantMap& map, QStringList& defaultGroups );
+
+/** @brief Test Config object methods and internals
+ *
+ */
+class UserTests : public QObject
+{
+    Q_OBJECT
+public:
+    UserTests();
+    virtual ~UserTests() {}
+
+private Q_SLOTS:
+    void initTestCase();
+
+    void testDefaultGroups();
+};
+
+UserTests::UserTests() {}
+
+void
+UserTests::initTestCase()
+{
+    Logger::setupLogLevel( Logger::LOGDEBUG );
+    cDebug() << "Users test started.";
+}
+
+void
+UserTests::testDefaultGroups()
+{
+    {
+        QStringList groups;
+        QVariantMap hweelGroup;
+        QVERIFY( groups.isEmpty() );
+        hweelGroup.insert( "defaultGroups", QStringList { "hweel" } );
+        setConfigurationDefaultGroups( hweelGroup, groups );
+        QCOMPARE( groups.count(), 1 );
+        QVERIFY( groups.contains( "hweel" ) );
+    }
+
+    {
+        QStringList desired { "wheel", "root", "operator" };
+        QStringList groups;
+        QVariantMap threeGroup;
+        QVERIFY( groups.isEmpty() );
+        threeGroup.insert( "defaultGroups", desired );
+        setConfigurationDefaultGroups( threeGroup, groups );
+        QCOMPARE( groups.count(), 3 );
+        QVERIFY( !groups.contains( "hweel" ) );
+        QCOMPARE( groups, desired );
+    }
+
+    {
+        QStringList groups;
+        QVariantMap explicitEmpty;
+        QVERIFY( groups.isEmpty() );
+        explicitEmpty.insert( "defaultGroups", QStringList() );
+        setConfigurationDefaultGroups( explicitEmpty, groups );
+        QCOMPARE( groups.count(), 0 );
+    }
+
+    {
+        QStringList groups;
+        QVariantMap missing;
+        QVERIFY( groups.isEmpty() );
+        setConfigurationDefaultGroups( missing, groups );
+        QCOMPARE( groups.count(), 6 );  // because of fallback!
+        QVERIFY( groups.contains( "lp" ) );
+    }
+
+    {
+        QStringList groups;
+        QVariantMap typeMismatch;
+        QVERIFY( groups.isEmpty() );
+        typeMismatch.insert( "defaultGroups", 1 );
+        setConfigurationDefaultGroups( typeMismatch, groups );
+        QCOMPARE( groups.count(), 6 );  // because of fallback!
+        QVERIFY( groups.contains( "lp" ) );
+    }
+}
+
+
+QTEST_GUILESS_MAIN( UserTests )
+
+#include "utils/moc-warnings.h"
+
+#include "Tests.moc"