applications/calamares
2
0
Fork 0
mirror of https://github.com/parchlinux/calamares.git synced 2025-06-25 16:38:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[libcalamaresui] Make stepIsExecute() more general

Browse source 
- Checking if the **next** step is an execute-step is a little
   weird, so make the API more general (and add the +1 to indexes
   where it was using NextWillExecute before).
This commit is contained in:
Adriaan de Groot 2019-05-14 13:18:51 +02:00
parent 25099ae854
commit ad4352b65c
1 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/libcalamaresui/ViewManager.cpp
View file

@ -227,10 +227,18 @@ ViewManager::currentStepIndex() const
return m_currentStep; return m_currentStep;
} }
/** @brief Is the given step at @p index an execution step?
*
* Returns true if the step is an execution step, false otherwise.
* Also returns false if the @p index is out of range.
*/
static inline bool static inline bool
stepNextWillExecute(const ViewStepList& steps, int index) stepIsExecute( const ViewStepList& steps, int index )
{ {
return ( index + 1 < steps.count() ) && qobject_cast< ExecutionViewStep* >( steps.at( index + 1 ) ); return
( 0 <= index ) &&
( index < steps.count() ) &&
( qobject_cast< ExecutionViewStep* >( steps.at( index ) ) != nullptr );
} }
void void
@ -245,7 +253,7 @@ ViewManager::next()
// Special case when the user clicks next on the very last page in a view phase // Special case when the user clicks next on the very last page in a view phase
// and right before switching to an execution phase. // and right before switching to an execution phase.
// Depending on Calamares::Settings, we show an "are you sure" prompt or not. // Depending on Calamares::Settings, we show an "are you sure" prompt or not.
if ( settings->showPromptBeforeExecution() && stepNextWillExecute( m_steps, m_currentStep ) ) if ( settings->showPromptBeforeExecution() && stepIsExecute( m_steps, m_currentStep+1 ) )
{ {
QString title = settings->isSetupMode() QString title = settings->isSetupMode()
? tr( "Continue with setup?" ) ? tr( "Continue with setup?" )
@ -309,7 +317,8 @@ ViewManager::updateButtonLabels()
? tr( "Cancel setup without changing the system." ) ? tr( "Cancel setup without changing the system." )
: tr( "Cancel installation without changing the system." ); : tr( "Cancel installation without changing the system." );
if ( stepNextWillExecute( m_steps, m_currentStep ) ) // If we're going into the execution step / install phase, other message
if ( stepIsExecute( m_steps, m_currentStep+1 ) )
m_next->setText( next ); m_next->setText( next );
else else
m_next->setText( tr( "&Next" ) ); m_next->setText( tr( "&Next" ) );