[initcpio] Replace Python implementation with C++

- This is a simple variation on the theme of things-that-call-a- initramfs-updater, so the code is mostly a copy of initramfs/ module. I didn't even bother to strip out the configuration- handling (I figure it might be good for *something*) so now "" and "$uname" are valid kernel names as well. - Fixes security issue where the initramfs ends up readable by all, and that includes the cryptfile for LUKS. SEE #1190
2025-06-29 10:25:36 -04:00 · 2019-07-04 20:21:13 +02:00 · 2019-07-04 20:21:13 +02:00 · bb6530577d
commit bb6530577d
parent d5340f9743
6 changed files with 150 additions and 55 deletions
--- a/src/modules/initcpio/InitcpioJob.cpp
+++ b/src/modules/initcpio/InitcpioJob.cpp
@ -0,0 +1,77 @@
+/* === This file is part of Calamares - <https://github.com/calamares> ===
+ *
+ *   Copyright 2019, Adriaan de Groot <groot@kde.org>
+ *
+ *   Calamares is free software: you can redistribute it and/or modify
+ *   it under the terms of the GNU General Public License as published by
+ *   the Free Software Foundation, either version 3 of the License, or
+ *   (at your option) any later version.
+ *
+ *   Calamares is distributed in the hope that it will be useful,
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ *   GNU General Public License for more details.
+ *
+ *   You should have received a copy of the GNU General Public License
+ *   along with Calamares. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "InitcpioJob.h"
+
+#include "utils/CalamaresUtilsSystem.h"
+#include "utils/Logger.h"
+#include "utils/UMask.h"
+#include "utils/Variant.h"
+
+InitcpioJob::InitcpioJob( QObject* parent )
+    : Calamares::CppJob( parent )
+{
+}
+
+InitcpioJob::~InitcpioJob() {}
+
+
+QString
+InitcpioJob::prettyName() const
+{
+    return tr( "Creating initramfs with mkinitcpio." );
+}
+
+
+Calamares::JobResult
+InitcpioJob::exec()
+{
+    CalamaresUtils::UMask m( CalamaresUtils::UMask::Safe );
+
+    cDebug() << "Updating initramfs with kernel" << m_kernel;
+    auto r = CalamaresUtils::System::instance()->targetEnvCommand(
+        { "mkinitcpio", "-p", m_kernel }, QString(), QString(), 0 );
+    return r.explainProcess( "mkinitcpio", 10 );
+}
+
+void
+InitcpioJob::setConfigurationMap( const QVariantMap& configurationMap )
+{
+    m_kernel = CalamaresUtils::getString( configurationMap, "kernel" );
+    if ( m_kernel.isEmpty() )
+    {
+        m_kernel = QStringLiteral( "all" );
+    }
+    else if ( m_kernel == "$uname" )
+    {
+        auto r = CalamaresUtils::System::runCommand(
+            CalamaresUtils::System::RunLocation::RunInHost, { "/bin/uname", "-r" }, QString(), QString(), 3 );
+        if ( r.getExitCode() == 0 )
+        {
+            m_kernel = r.getOutput();
+            cDebug() << "*initcpio* using running kernel" << m_kernel;
+        }
+        else
+        {
+            cWarning() << "*initcpio* could not determine running kernel, using 'all'." << Logger::Continuation
+                       << r.getExitCode() << r.getOutput();
+        }
+    }
+}
+
+CALAMARES_PLUGIN_FACTORY_DEFINITION( InitcpioJobFactory, registerPlugin< InitcpioJob >(); )