Reduce warnings about extra ;

- Trailing ; after Q_UNUSED
 - Trailing ; after CALAMARES_RETRANSLATE
This commit is contained in:
Adriaan de Groot 2019-04-17 11:57:46 +02:00
parent c83395ff6d
commit cef2f50510
18 changed files with 29 additions and 30 deletions

View file

@ -98,9 +98,9 @@ ProgressTreeModel::data( const QModelIndex& index, int role ) const
QVariant QVariant
ProgressTreeModel::headerData( int section, Qt::Orientation orientation, int role ) const ProgressTreeModel::headerData( int section, Qt::Orientation orientation, int role ) const
{ {
Q_UNUSED( section ); Q_UNUSED( section )
Q_UNUSED( orientation ); Q_UNUSED( orientation )
Q_UNUSED( role ); Q_UNUSED( role )
return QVariant(); return QVariant();
} }

View file

@ -46,7 +46,7 @@ void
ViewStepItem::appendChild( ProgressTreeItem* item ) ViewStepItem::appendChild( ProgressTreeItem* item )
{ {
Q_ASSERT( false ); Q_ASSERT( false );
Q_UNUSED( item ); Q_UNUSED( item )
} }

View file

@ -92,7 +92,7 @@ BOOST_PYTHON_MODULE( libcalamares )
bp::object utilsModule( bp::handle<>( bp::borrowed( PyImport_AddModule( "libcalamares.utils" ) ) ) ); bp::object utilsModule( bp::handle<>( bp::borrowed( PyImport_AddModule( "libcalamares.utils" ) ) ) );
bp::scope().attr( "utils" ) = utilsModule; bp::scope().attr( "utils" ) = utilsModule;
bp::scope utilsScope = utilsModule; bp::scope utilsScope = utilsModule;
Q_UNUSED( utilsScope ); Q_UNUSED( utilsScope )
bp::def( bp::def(
"debug", "debug",

View file

@ -40,7 +40,7 @@ static int s_defaultFontHeight = 0;
QPixmap QPixmap
defaultPixmap( ImageType type, ImageMode mode, const QSize& size ) defaultPixmap( ImageType type, ImageMode mode, const QSize& size )
{ {
Q_UNUSED( mode ); Q_UNUSED( mode )
QPixmap pixmap; QPixmap pixmap;
switch ( type ) switch ( type )

View file

@ -71,7 +71,7 @@ ViewStep::setModuleInstanceKey( const QString& instanceKey )
void void
ViewStep::setConfigurationMap( const QVariantMap& configurationMap ) ViewStep::setConfigurationMap( const QVariantMap& configurationMap )
{ {
Q_UNUSED( configurationMap ); Q_UNUSED( configurationMap )
} }

View file

@ -43,7 +43,7 @@ FixedAspectRatioLabel::setPixmap( const QPixmap& pixmap )
void void
FixedAspectRatioLabel::resizeEvent( QResizeEvent* event ) FixedAspectRatioLabel::resizeEvent( QResizeEvent* event )
{ {
Q_UNUSED( event ); Q_UNUSED( event )
QLabel::setPixmap( m_pixmap.scaled( QLabel::setPixmap( m_pixmap.scaled(
contentsRect().size(), contentsRect().size(),
Qt::KeepAspectRatio, Qt::KeepAspectRatio,

View file

@ -125,7 +125,7 @@ FinishedPage::focusInEvent( QFocusEvent* e )
void void
FinishedPage::onInstallationFailed( const QString& message, const QString& details ) FinishedPage::onInstallationFailed( const QString& message, const QString& details )
{ {
Q_UNUSED( details ); Q_UNUSED( details )
if ( Calamares::Settings::instance()->isSetupMode() ) if ( Calamares::Settings::instance()->isSetupMode() )
ui->mainText->setText( tr( "<h1>Setup Failed</h1><br/>" ui->mainText->setText( tr( "<h1>Setup Failed</h1><br/>"
"%1 has not been set up on your computer.<br/>" "%1 has not been set up on your computer.<br/>"

View file

@ -148,8 +148,8 @@ FinishedViewStep::jobs() const
void void
FinishedViewStep::onInstallationFailed( const QString& message, const QString& details ) FinishedViewStep::onInstallationFailed( const QString& message, const QString& details )
{ {
Q_UNUSED( message ); Q_UNUSED( message )
Q_UNUSED( details ); Q_UNUSED( details )
installFailed = true; installFailed = true;
} }

View file

@ -32,7 +32,7 @@ KeyboardLayoutModel::KeyboardLayoutModel( QObject* parent )
int int
KeyboardLayoutModel::rowCount( const QModelIndex& parent ) const KeyboardLayoutModel::rowCount( const QModelIndex& parent ) const
{ {
Q_UNUSED( parent ); Q_UNUSED( parent )
return m_layouts.count(); return m_layouts.count();
} }

View file

@ -436,7 +436,7 @@ void
KeyboardPage::onListLayoutCurrentItemChanged( const QModelIndex& current, KeyboardPage::onListLayoutCurrentItemChanged( const QModelIndex& current,
const QModelIndex& previous ) const QModelIndex& previous )
{ {
Q_UNUSED( previous ); Q_UNUSED( previous )
if ( !current.isValid() ) if ( !current.isValid() )
return; return;
@ -457,7 +457,7 @@ static inline QStringList xkbmap_args( QStringList&& r, const QString& layout, c
void void
KeyboardPage::onListVariantCurrentItemChanged( QListWidgetItem* current, QListWidgetItem* previous ) KeyboardPage::onListVariantCurrentItemChanged( QListWidgetItem* current, QListWidgetItem* previous )
{ {
Q_UNUSED( previous ); Q_UNUSED( previous )
QPersistentModelIndex layoutIndex = ui->listLayout->currentIndex(); QPersistentModelIndex layoutIndex = ui->listLayout->currentIndex();
LayoutItem* variantItem = dynamic_cast< LayoutItem* >( current ); LayoutItem* variantItem = dynamic_cast< LayoutItem* >( current );

View file

@ -87,8 +87,7 @@ LicensePage::LicensePage(QWidget *parent)
CALAMARES_RETRANSLATE( CALAMARES_RETRANSLATE(
ui->acceptCheckBox->setText( tr( "I accept the terms and conditions above." ) ); ui->acceptCheckBox->setText( tr( "I accept the terms and conditions above." ) );
); )
} }

View file

@ -101,7 +101,7 @@ LocalePage::LocalePage( QWidget* parent )
static_cast< void ( QComboBox::* )( int ) >( &QComboBox::currentIndexChanged ), static_cast< void ( QComboBox::* )( int ) >( &QComboBox::currentIndexChanged ),
[this]( int currentIndex ) [this]( int currentIndex )
{ {
Q_UNUSED( currentIndex ); Q_UNUSED( currentIndex )
QHash< QString, QList< LocaleGlobal::Location > > regions = LocaleGlobal::getLocations(); QHash< QString, QList< LocaleGlobal::Location > > regions = LocaleGlobal::getLocations();
if ( !regions.contains( m_regionCombo->currentData().toString() ) ) if ( !regions.contains( m_regionCombo->currentData().toString() ) )
return; return;

View file

@ -127,7 +127,7 @@ bool
PackageModel::setHeaderData( int section, Qt::Orientation orientation, PackageModel::setHeaderData( int section, Qt::Orientation orientation,
const QVariant& value, int role ) const QVariant& value, int role )
{ {
Q_UNUSED( role ); Q_UNUSED( role )
if ( orientation == Qt::Horizontal ) if ( orientation == Qt::Horizontal )
{ {

View file

@ -540,7 +540,7 @@ void
ChoicePage::doAlongsideSetupSplitter( const QModelIndex& current, ChoicePage::doAlongsideSetupSplitter( const QModelIndex& current,
const QModelIndex& previous ) const QModelIndex& previous )
{ {
Q_UNUSED( previous ); Q_UNUSED( previous )
if ( !current.isValid() ) if ( !current.isValid() )
return; return;
@ -718,7 +718,7 @@ void
ChoicePage::onPartitionToReplaceSelected( const QModelIndex& current, ChoicePage::onPartitionToReplaceSelected( const QModelIndex& current,
const QModelIndex& previous ) const QModelIndex& previous )
{ {
Q_UNUSED( previous ); Q_UNUSED( previous )
if ( !current.isValid() ) if ( !current.isValid() )
return; return;

View file

@ -100,7 +100,7 @@ PartitionLabelsView::sizeHint() const
void void
PartitionLabelsView::paintEvent( QPaintEvent* event ) PartitionLabelsView::paintEvent( QPaintEvent* event )
{ {
Q_UNUSED( event ); Q_UNUSED( event )
QPainter painter( viewport() ); QPainter painter( viewport() );
painter.fillRect( rect(), palette().window() ); painter.fillRect( rect(), palette().window() );
@ -478,7 +478,7 @@ PartitionLabelsView::visualRect( const QModelIndex& idx ) const
QRegion QRegion
PartitionLabelsView::visualRegionForSelection( const QItemSelection& selection ) const PartitionLabelsView::visualRegionForSelection( const QItemSelection& selection ) const
{ {
Q_UNUSED( selection ); Q_UNUSED( selection )
return QRegion(); return QRegion();
} }
@ -543,8 +543,8 @@ PartitionLabelsView::setExtendedPartitionHidden( bool hidden )
QModelIndex QModelIndex
PartitionLabelsView::moveCursor( CursorAction cursorAction, Qt::KeyboardModifiers modifiers ) PartitionLabelsView::moveCursor( CursorAction cursorAction, Qt::KeyboardModifiers modifiers )
{ {
Q_UNUSED( cursorAction ); Q_UNUSED( cursorAction )
Q_UNUSED( modifiers ); Q_UNUSED( modifiers )
return QModelIndex(); return QModelIndex();
} }
@ -553,7 +553,7 @@ PartitionLabelsView::moveCursor( CursorAction cursorAction, Qt::KeyboardModifier
bool bool
PartitionLabelsView::isIndexHidden( const QModelIndex& index ) const PartitionLabelsView::isIndexHidden( const QModelIndex& index ) const
{ {
Q_UNUSED( index ); Q_UNUSED( index )
return false; return false;
} }
@ -598,7 +598,7 @@ PartitionLabelsView::mouseMoveEvent( QMouseEvent* event )
void void
PartitionLabelsView::leaveEvent( QEvent* event ) PartitionLabelsView::leaveEvent( QEvent* event )
{ {
Q_UNUSED( event ); Q_UNUSED( event )
QGuiApplication::restoreOverrideCursor(); QGuiApplication::restoreOverrideCursor();
if ( m_hoveredIndex.isValid() ) if ( m_hoveredIndex.isValid() )

View file

@ -286,7 +286,7 @@ PartitionSplitterWidget::minimumSizeHint() const
void void
PartitionSplitterWidget::paintEvent( QPaintEvent* event ) PartitionSplitterWidget::paintEvent( QPaintEvent* event )
{ {
Q_UNUSED( event ); Q_UNUSED( event )
QPainter painter( this ); QPainter painter( this );
painter.fillRect( rect(), palette().window() ); painter.fillRect( rect(), palette().window() );
@ -401,7 +401,7 @@ PartitionSplitterWidget::mouseMoveEvent( QMouseEvent* event )
void void
PartitionSplitterWidget::mouseReleaseEvent( QMouseEvent* event ) PartitionSplitterWidget::mouseReleaseEvent( QMouseEvent* event )
{ {
Q_UNUSED( event ); Q_UNUSED( event )
m_resizing = false; m_resizing = false;
} }

View file

@ -41,7 +41,7 @@ SummaryPage::SummaryPage( const SummaryViewStep* thisViewStep, QWidget* parent )
, m_contentWidget( nullptr ) , m_contentWidget( nullptr )
, m_scrollArea( new QScrollArea( this ) ) , m_scrollArea( new QScrollArea( this ) )
{ {
Q_UNUSED( parent ); Q_UNUSED( parent )
Q_ASSERT( m_thisViewStep ); Q_ASSERT( m_thisViewStep );
QVBoxLayout* layout = new QVBoxLayout( this ); QVBoxLayout* layout = new QVBoxLayout( this );
layout->setContentsMargins( 0, 0, 0, 0 ); layout->setContentsMargins( 0, 0, 0, 0 );

View file

@ -278,7 +278,7 @@ bool
GeneralRequirements::checkEnoughStorage( qint64 requiredSpace ) GeneralRequirements::checkEnoughStorage( qint64 requiredSpace )
{ {
#ifdef WITHOUT_LIBPARTED #ifdef WITHOUT_LIBPARTED
Q_UNUSED( requiredSpace ); Q_UNUSED( requiredSpace )
cWarning() << "GeneralRequirements is configured without libparted."; cWarning() << "GeneralRequirements is configured without libparted.";
return false; return false;
#else #else