Adriaan de Groot
1674c81e9c
[libcalamares] Add query for kpmcore status
2019-06-13 23:38:50 +02:00
Adriaan de Groot
7adbc8cda6
[libcalamares] Add KPMCore manager
...
- This handles cleaning up KPMCore on exit
2019-06-13 23:38:50 +02:00
Adriaan de Groot
8eb04a082e
[libcalamares] Move FS-related code to partition service
...
- only moves one function right now, providing user-visible
name for filesystem name.
2019-06-13 14:55:43 +02:00
Adriaan de Groot
a7a3c4f2d8
[libcalamares] Unused include
2019-06-13 14:51:13 +02:00
Adriaan de Groot
93742a8efe
[libcalamares] Reformat new code in partition service
2019-06-13 14:47:44 +02:00
Adriaan de Groot
4b3bb54320
[libcalamares] Move partition-finding into libcalamares
...
- Moved from KPMHelpers to the partition service
- The is-partition and find-partition methods that make sense
in general, are moved to libcalamares.
2019-06-13 14:41:33 +02:00
Adriaan de Groot
3930826e93
[fsresizer] [partition] Drop special cases for kpmcore 3.3.1
2019-06-13 14:10:49 +02:00
Adriaan de Groot
9f0f08b571
[partition] Replace useless qobject_cast
...
- We know the type of the widget, but were declaring it as
a QWidget. Just forward-declare the class and be done with it.
2019-06-13 14:02:43 +02:00
Adriaan de Groot
ca9f21d805
[libcalamares] Refortmat the partition service
2019-06-13 12:35:32 +02:00
Adriaan de Groot
4202126f34
[fsresizer] [partition] Fix build with moved headers
...
- PartitionIterator has moved into libcalamares
- While here, sort and organize #include lines
- Add using to keep code impact small
2019-06-13 12:27:39 +02:00
Adriaan de Groot
8885611ae3
[libcalamares] Fix build with non-namespaced KPMCore types
2019-06-13 12:27:21 +02:00
Adriaan de Groot
d8dc512f45
[libcalamares] Move PartitionIterator to partition service.
...
- Starting to centralize utility code for partitioning into
libcalamares instead of scattered and weirdly shared between
modules.
- This particular commit breaks compiling the modules, though.
2019-06-13 12:12:47 +02:00
Adriaan de Groot
f1822c2adb
[partition] [fsresizer] For simplicity, disallow beta KPMcore
2019-06-13 11:45:20 +02:00
Adriaan de Groot
5dfc4884b3
[calamares] Increase constness
...
- The model shouldn't change items at all.
2019-06-12 12:45:47 +02:00
Adriaan de Groot
85845c9b3e
[calamares] cLog() isn't a thing, return to cDebug()
2019-06-12 08:32:28 +02:00
Adriaan de Groot
a6d7fcdadf
[calamares] Reformat the rest of the application
2019-06-11 13:44:29 +02:00
Adriaan de Groot
9235499f7f
[calamares] Reformat the progresstree
...
- add { } to single-line blocks
- group some includes better
- lines broken at a different length, some shuffling around of
parameter lists.
2019-06-11 13:44:29 +02:00
Adriaan de Groot
39675655a0
[calamares] Tidy up include-guard comments
2019-06-11 11:17:44 +02:00
Adriaan de Groot
0d507ec265
[calamares] Tidy up application code
...
- remove commented code, fix logging around it
- misplaced include
2019-06-11 11:17:44 +02:00
Adriaan de Groot
74432f698f
[partition] Allow the requiredStorage setting to propagate
...
- store into globalStorage if the welcome module hasn't already done so.
- this ends up used in PartUtils (via globalStorage).
2019-06-08 14:36:11 +02:00
Adriaan de Groot
e6a2cb607f
[partition] Add setting for requiredstorage
...
- If the welcome module isn't used, can set a required amount
of storage for the installation here.
2019-06-08 07:48:47 -04:00
Adriaan de Groot
b5c50c8d04
[partition] Update canBeReplaced
...
- Use GiB consistently
- Provide same kind of debugging information as canBeResized()
2019-06-07 23:19:24 +02:00
Adriaan de Groot
79934aa513
[partition] Use GiB consistently in code
2019-06-07 23:04:24 +02:00
Adriaan de Groot
962776804c
[libcalamares] Add BytesToGiB (extends BytesToMiB)
2019-06-07 23:01:18 +02:00
Adriaan de Groot
acf3dbcdcb
[partition] Refactor getting the globalStorage value
2019-06-07 22:55:50 +02:00
Adriaan de Groot
3548792d1b
[partition] Improve check canBeResized
...
- Report the globalSettings name properly (with "GiB")
- Bail out on bad conversion early.
2019-06-07 22:51:33 +02:00
Adriaan de Groot
c233bbb23d
[libcalamaresui] Handle no-finished-page scenarios
...
- From an exec section, next() is called automatically when
all the jobs in that section are done.
- If there **is** no next section (e.g. there's no finished
page to show after the exec), then m_steps.at() would assert
on an out-of-range index.
- Introdcuce a helper predicate isAtVeryEnd() which handles both
out-of-range and normal at-the-end scenarios.
- If there's no page following the exec section, stay with the
slideshow but update buttons to match the normal last-page
behavior, and don't ask about cancel (since we're done).
2019-06-07 21:54:07 +02:00
Adriaan de Groot
4f221b41d1
[libcalamares] Close stdin on process jobs
...
- This avoids processes that wait on stdin, and e.g. improves
reaction to having just "cat" (no file) in a command, or
a package manager that asks for input.
2019-06-07 16:11:54 +02:00
Adriaan de Groot
4e13f780f1
[libcalamares] Expand tests for runCommand
...
- try both with and without a working-directory set, this would have
shown up the problem with bad indentation much earlier.
2019-06-07 16:00:37 +02:00
Adriaan de Groot
7be33b8196
[libcalamares] runCommand doesn't need queue or settings
...
- JobQueue is only needed to get global settings, which are needed
when running in the target; for host commands, allow running
without a queue.
- Settings is needed for the value of debugsettings; assume if
there's no settings object, that we're in a test and should
print debugging information.
2019-06-07 15:53:27 +02:00
Adriaan de Groot
5a835f32b8
[libcalamares] Start extending tests to runCommand()
2019-06-07 13:56:16 +02:00
Adriaan de Groot
07a59bd09c
[libcalamares] All commands with workingDirectory failed
...
- This is the same as EFAIL: a block is indented as if it's a multi-
line else block. This isn't Python though, and the return always
applies.
- Add the necessary braces.
- Apparently noone uses this code path (until ProcessJob was re-
factored to do so).
2019-06-07 13:37:46 +02:00
Adriaan de Groot
d7f5134121
[libcalamares] Be more verbose in error situations
...
- runCommand can return NoWorkingDirectory in multiple places,
make sure the log contains a more specific reason.
2019-06-07 13:32:31 +02:00
Adriaan de Groot
b587d77e31
[libcalamares] Fix untranslatable string.
...
- This would substitue an untranslated "in chroot" into the
translated string, which is weird.
2019-06-07 12:40:20 +02:00
Adriaan de Groot
6055f08aff
[libcalamares] Refactor ProcessJob
...
- Use the system runCommand() instead of a 90% copy of it.
This **does** change the overall command to `env /bin/sh -c`
rather than running only `/bin/sh -c`, though.
2019-06-07 12:30:38 +02:00
Adriaan de Groot
92d03c2cf7
[libcalamares] Introduce enum class for special process exit values
...
- Replace magic numbers like -3 with named enum values
(NoWorkingDirectory, for -3).
- Downside is big-ugly static_casts, but that's what you get
for having an int as return value for processes.
2019-06-07 12:10:22 +02:00
Adriaan de Groot
61b78d8895
[libcalamares] Stop job threads before exit
...
- This solves a crash where the thread is destroyed while still
running (e.g. cancelling during install).
- The thread might not cooperate in being terminated, but then we
have a bigger problem anyway (and Calamares will still crash on
exit).
FIXES #1164
2019-06-07 11:46:08 +02:00
Calamares CI
bbc0edecd3
i18n: [dummypythonqt] Automatic merge of Transifex translations
2019-06-07 10:44:01 +02:00
Adriaan de Groot
3335c2003e
[fsresizer] Fix tests
...
- Again? The checks on the job name (using filesystem or device
name) all looked very bogus, unless it was previously not
setting them at all.
2019-06-03 15:00:04 +02:00
Adriaan de Groot
f54b7dee9f
[welcome] Use convenience image loader from Branding
2019-05-31 17:27:11 +02:00
Adriaan de Groot
07c638ed48
[welcome] Allow theming the international language-select icon
2019-05-31 17:27:11 +02:00
Adriaan de Groot
75ce391e7e
[libcalamaresui] Add branding-aware function for loading image by name
2019-05-31 17:27:11 +02:00
Adriaan de Groot
1438729b72
[libcalamaresui] Do filename checks more sanely
...
- check directory exists before trying to open file from it
- re-use the componentDir already found for later tests.
2019-05-31 17:27:11 +02:00
Adriaan de Groot
69dabcae32
[libcalamares] Avoid static destructor
...
- The static destructor issues a warning on exit:
QBasicTimer::start: QBasicTimer can only be used with threads
started with QThread
so instead, heap-allocate the model. This leaks memory, but
it's a singleton *and* we're exiting anyway.
2019-05-31 12:38:34 +02:00
Adriaan de Groot
a263381996
[partition] Avoid an assert when running Calamares as user.
2019-05-31 12:27:32 +02:00
Adriaan de Groot
4a6b9f3528
[partition] Call update from init() in BootLoaderModel
...
- update() (might) add some extra rows for boot and root,
which otherwise vanish temporarily when calling init.
2019-05-31 12:11:48 +02:00
Adriaan de Groot
d5f0bdd28c
[partition] Simplify negative logic
...
- Instead of multiple continue statements to avoid negative cases,
state the one positive case instead.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
3bdbfe6bff
[partition] Avoid crash if combobox is gone and model resets
...
- Since the lambda is connected to the model only, it should
check that the target combo exists as well.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
2ce2b08027
[partition] Indent lambdas to tab-stop.
...
- Lambdas are all over the place in this codebase, formulate
a standard and start adjusting code to it in passing.
2019-05-31 12:08:58 +02:00
Adriaan de Groot
353e713f81
[partition] Complain loudly on dangling Partition pointers
...
- Don't crash if a bad pointer gets into colorutils.
2019-05-31 12:08:58 +02:00