applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
gnome-control-center/panels/network/connection-editor/ce-page-ip4.c

886 lines
36 KiB
C
Raw Normal View History

network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2012 Red Hat, Inc
*
* Licensed under the GNU General Public License Version 2
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include "config.h"
#include <errno.h>
#include <stdlib.h>
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
#include <arpa/inet.h>
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
#include <glib/gi18n.h>
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
#include <NetworkManager.h>
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
#include "ce-ip-address-entry.h"
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
#include "ce-netmask-entry.h"
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
#include "ce-page.h"
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
#include "ce-page-ip4.h"
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
#include "ui-helpers.h"
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
static void ensure_empty_address_row (CEPageIP4 *self);
static void ensure_empty_routes_row (CEPageIP4 *self);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
network: Replace GObject boilerplate with modern macros
2019-11-06 14:00:07 +13:00
struct _CEPageIP4
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
AdwBin parent;
network: Replace GObject boilerplate with modern macros
2019-11-06 14:00:07 +13:00
Address review feedback
2022-05-10 10:43:50 +02:00
GtkLabel *address_address_label;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkBox *address_box;
Address review feedback
2022-05-10 10:43:50 +02:00
GtkLabel *address_gateway_label;
GtkLabel *address_netmask_label;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkSizeGroup *address_sizegroup;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
GtkLabel *auto_dns_label;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkSwitch *auto_dns_switch;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
GtkLabel *auto_routes_label;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkSwitch *auto_routes_switch;
GtkBox *content_box;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
GtkBox *dns_box;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkEntry *dns_entry;
network: Make IPv4/v6 pages drive the scrolledwindow adjustments Those 2 pages in the connection editor dialog are scrollable, but don't hook focus changes so they drive the adjustments. Make them do so.
2019-12-12 16:20:57 +01:00
GtkGrid *main_box;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkCheckButton *never_default_check;
Address review feedback
2022-05-10 10:43:50 +02:00
GtkBox *routes_box;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
GtkBox *route_config_box;
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
GtkLabel *routes_address_label;
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
GtkLabel *routes_gateway_label;
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
GtkLabel *routes_netmask_label;
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
GtkLabel *routes_metric_label;
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
GtkSizeGroup *routes_address_sizegroup;
GtkSizeGroup *routes_gateway_sizegroup;
GtkSizeGroup *routes_netmask_sizegroup;
network: Get connection editor root widget from a virtual method
2019-11-06 14:55:12 +13:00
GtkSizeGroup *routes_metric_sizegroup;
GtkSizeGroup *routes_sizegroup;
network: Replace GObject boilerplate with modern macros
2019-11-06 14:00:07 +13:00
NMSettingIPConfig *setting;
GtkWidget *address_list;
GtkWidget *routes_list;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
GActionGroup *method_group;
network: Replace GObject boilerplate with modern macros
2019-11-06 14:00:07 +13:00
};
network: Convert CEPage from a class to an interface
2019-11-06 17:07:42 +13:00
static void ce_page_iface_init (CEPageInterface *);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
G_DEFINE_TYPE_WITH_CODE (CEPageIP4, ce_page_ip4, ADW_TYPE_BIN,
network: Convert CEPage from a class to an interface
2019-11-06 17:07:42 +13:00
G_IMPLEMENT_INTERFACE (ce_page_get_type (), ce_page_iface_init))
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
enum {
METHOD_COL_NAME,
METHOD_COL_METHOD
};
network: warn user if both automatic and manual DNS is configured If you manually configure a DNS server, you probably don't want to also receive DNS from DHCP. Warn the user about this. This is a softer replacement for the fix from: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1914 which we found in #2617 broke imported Wireguard connections.
2023-10-06 13:37:08 -05:00
static void
sync_dns_entry_warning (CEPageIP4 *self)
{
g_autoptr(GVariant) method_variant = NULL;
const gchar *method;
method_variant = g_action_group_get_action_state (self->method_group, "ip4method");
method = g_variant_get_string (method_variant, NULL);
if (gtk_entry_get_text_length (self->dns_entry) &&
gtk_switch_get_active (self->auto_dns_switch) &&
g_strcmp0 (method, "automatic") == 0) {
gtk_entry_set_icon_from_icon_name (self->dns_entry, GTK_ENTRY_ICON_SECONDARY, "dialog-warning-symbolic");
gtk_entry_set_icon_tooltip_text (self->dns_entry, GTK_ENTRY_ICON_SECONDARY, _("Automatic DNS is enabled. Did you intend to disable Automatic DNS?"));
gtk_widget_add_css_class (GTK_WIDGET (self->dns_entry), "warning");
} else {
gtk_entry_set_icon_from_icon_name (self->dns_entry, GTK_ENTRY_ICON_SECONDARY, NULL);
gtk_entry_set_icon_tooltip_text (self->dns_entry, GTK_ENTRY_ICON_SECONDARY, NULL);
gtk_widget_remove_css_class (GTK_WIDGET (self->dns_entry), "warning");
}
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
method_changed (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
gboolean addr_enabled;
gboolean dns_enabled;
gboolean routes_enabled;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gboolean auto_enabled;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
g_autoptr(GVariant) method_variant = NULL;
const gchar *method;
method_variant = g_action_group_get_action_state (self->method_group, "ip4method");
method = g_variant_get_string (method_variant, NULL);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
if (g_str_equal (method, "disabled") ||
g_str_equal (method, "shared")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
addr_enabled = FALSE;
dns_enabled = FALSE;
routes_enabled = FALSE;
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
auto_enabled = FALSE;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
} else {
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
addr_enabled = g_str_equal (method, "manual");
Revert "network: Disable DNS entry if the automatic option is enabled" This reverts commit 8a4a80b7b2c2c460ad6b12a48d7cc78da5d97d35. This is a manual revert, because the code changed considerably in a2b9620b1b69bc2e3e4feed2337ad92867738d04. Anyway, although this seemed like a good idea, problem is it clobbers the original state of the connection without any explicit user action if the connection is configured to use both manual and auto DNS. And this happens in practice for imported Wireguard connections, which uselessly have auto DNS enabled due to this NetworkManager bug: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1399 Additional discussion: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1745#note_2112420 The simplest solution is to not try to prevent the user from configuring both manual and auto DNS. Instead, let's just warn the user that this configuration may not be intended in a follow-up commit. Fixes #2617
2023-10-06 11:49:23 -05:00
dns_enabled = !g_str_equal (method, "local");
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
routes_enabled = !g_str_equal (method, "local");
auto_enabled = g_str_equal (method, "automatic");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_widget_set_visible (GTK_WIDGET (self->address_box), addr_enabled);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_widget_set_sensitive (GTK_WIDGET (self->dns_box), dns_enabled);
gtk_widget_set_sensitive (GTK_WIDGET (self->routes_box), routes_enabled);
gtk_widget_set_sensitive (GTK_WIDGET (self->auto_dns_label), auto_enabled);
gtk_widget_set_sensitive (GTK_WIDGET (self->auto_dns_switch), auto_enabled);
gtk_widget_set_sensitive (GTK_WIDGET (self->auto_routes_label), auto_enabled);
gtk_widget_set_sensitive (GTK_WIDGET (self->auto_routes_switch), auto_enabled);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: warn user if both automatic and manual DNS is configured If you manually configure a DNS server, you probably don't want to also receive DNS from DHCP. Warn the user about this. This is a softer replacement for the fix from: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1914 which we found in #2617 broke imported Wireguard connections.
2023-10-06 13:37:08 -05:00
sync_dns_entry_warning (self);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ce_page_changed (CE_PAGE (self));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
update_row_sensitivity (CEPageIP4 *self, GtkWidget *list)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gint rows = 0, i = 0;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (GTK_WIDGET (list));
child;
child = gtk_widget_get_next_sibling (child)) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *button;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
button = GTK_WIDGET (g_object_get_data (G_OBJECT (child), "delete-button"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (button != NULL)
rows++;
}
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (GTK_WIDGET (list));
child;
child = gtk_widget_get_next_sibling (child)) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *button;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
button = GTK_WIDGET (g_object_get_data (G_OBJECT (child), "delete-button"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (button != NULL)
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_widget_set_sensitive (button, rows > 1 && ++i < rows);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
}
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
update_row_gateway_sensitivity (CEPageIP4 *self)
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child;
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
gint rows = 0;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (self->address_list);
child;
child = gtk_widget_get_next_sibling (child)) {
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
GtkWidget *entry;
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
entry = GTK_WIDGET (g_object_get_data (G_OBJECT (child), "gateway"));
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_widget_set_sensitive (entry, (rows == 0));
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
rows++;
}
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
network: Fix connection editor blanking when removing manual entry To delete a manual entry row (IP addresses or routes) the remove_row function started walking the widget hierarchy at the connection editor widget. This caused the entire dialog box getting removed. Begin at the GtkButton instead to actually remove the corresponding line. Fixes #972.
2020-06-20 23:52:19 +02:00
remove_row (CEPageIP4 *self, GtkButton *button)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
GtkWidget *list;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
GtkWidget *row;
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Fix connection editor blanking when removing manual entry To delete a manual entry row (IP addresses or routes) the remove_row function started walking the widget hierarchy at the connection editor widget. This caused the entire dialog box getting removed. Begin at the GtkButton instead to actually remove the corresponding line. Fixes #972.
2020-06-20 23:52:19 +02:00
row_box = gtk_widget_get_parent (GTK_WIDGET (button));
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row = gtk_widget_get_parent (row_box);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
list = gtk_widget_get_parent (row);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_list_box_remove (GTK_LIST_BOX (list), row);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ce_page_changed (CE_PAGE (self));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
update_row_sensitivity (self, list);
if (list == self->address_list)
update_row_gateway_sensitivity (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
static gboolean
validate_row (GtkWidget *row)
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
GtkWidget *box;
gboolean valid;
valid = FALSE;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
box = gtk_list_box_row_get_child (GTK_LIST_BOX_ROW (row));
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (box);
child;
child = gtk_widget_get_next_sibling (child)) {
if (!GTK_IS_ENTRY (child))
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
continue;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
valid = valid || gtk_entry_get_text_length (GTK_ENTRY (child)) > 0;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
}
return valid;
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_address_row (CEPageIP4 *self,
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *address,
const gchar *network,
const gchar *gateway)
{
GtkWidget *row;
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *widget;
GtkWidget *delete_button;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row = gtk_list_box_row_new ();
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_list_box_row_set_activatable (GTK_LIST_BOX_ROW (row), FALSE);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
row_box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_widget_add_css_class (row_box, "linked");
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
widget = GTK_WIDGET (ce_ip_address_entry_new (AF_INET));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_address_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "address", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), address);
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
Address review feedback
2022-05-10 10:43:50 +02:00
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_address_label, NULL,
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
widget = GTK_WIDGET (ce_netmask_entry_new ());
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_address_row), self, G_CONNECT_SWAPPED);
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
g_object_set_data (G_OBJECT (row), "netmask", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), network);
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
Address review feedback
2022-05-10 10:43:50 +02:00
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_netmask_label, NULL,
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
widget = GTK_WIDGET (ce_ip_address_entry_new (AF_INET));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_address_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "gateway", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), gateway ? gateway : "");
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
Address review feedback
2022-05-10 10:43:50 +02:00
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->address_gateway_label, NULL,
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Fix gateway entry visibility From https://bugzilla.gnome.org/show_bug.cgi?id=765969 as explained by Dan Winship: " libnm-util/libnm-glib had a buggy data model, which nm-connection-editor (and then gnome-control-center) copied, in which each manually-configured IP address has an associated gateway address. In reality, NM always just took the first non-empty gateway value from the address array, and completely ignored any other gateway values. libnm represents this more accurately, by having a single gateway value which is separate from the address array. Ideally, the editors should show it this way as well (eg, like nmtui does). Failing that, it would be nice to at least make it so that only the first row in the address table can have a non-empty gateway value. " We went for the second option, only showing a gateway entry for the first address in the list. This isn't related to route-specific gateway addresses. https://bugzilla.gnome.org/show_bug.cgi?id=765969
2016-09-16 16:57:10 +02:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
delete_button = gtk_button_new_from_icon_name ("edit-delete-symbolic");
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_widget_set_sensitive (delete_button, FALSE);
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (delete_button, "clicked", G_CALLBACK (remove_row), self, G_CONNECT_SWAPPED);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_accessible_update_property (GTK_ACCESSIBLE (delete_button),
GTK_ACCESSIBLE_PROPERTY_LABEL, _("Delete Address"),
-1);
gtk_box_append (GTK_BOX (row_box), delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "delete-button", delete_button);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_size_group_add_widget (self->address_sizegroup, delete_button);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_list_box_row_set_child (GTK_LIST_BOX_ROW (row), row_box);
gtk_list_box_append (GTK_LIST_BOX (self->address_list), row);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
update_row_gateway_sensitivity (self);
update_row_sensitivity (self, self->address_list);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ensure_empty_address_row (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child = gtk_widget_get_last_child (self->address_list);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
/* Add the last, stub row if needed*/
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
if (!child || validate_row (child))
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_address_row (self, "", "", "");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_address_box (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
GtkWidget *list;
gint i;
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
self->address_list = list = gtk_list_box_new ();
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
gtk_list_box_set_selection_mode (GTK_LIST_BOX (list), GTK_SELECTION_NONE);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (self->address_box, list);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
for (i = 0; i < nm_setting_ip_config_get_num_addresses (self->setting); i++) {
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMIPAddress *addr;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
struct in_addr tmp_addr;
gchar network[INET_ADDRSTRLEN + 1];
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
addr = nm_setting_ip_config_get_address (self->setting, i);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (!addr)
continue;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
tmp_addr.s_addr = nm_utils_ip4_prefix_to_netmask (nm_ip_address_get_prefix (addr));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
(void) inet_ntop (AF_INET, &tmp_addr, &network[0], sizeof (network));
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_address_row (self,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_ip_address_get_address (addr),
network,
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
i == 0 ? nm_setting_ip_config_get_gateway (self->setting) : "");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
if (nm_setting_ip_config_get_num_addresses (self->setting) == 0)
ensure_empty_address_row (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_dns_section (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
GString *string;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gint i;
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_switch_set_active (self->auto_dns_switch, !nm_setting_ip_config_get_ignore_auto_dns (self->setting));
Revert "network: Disable DNS entry if the automatic option is enabled" This reverts commit 8a4a80b7b2c2c460ad6b12a48d7cc78da5d97d35. This is a manual revert, because the code changed considerably in a2b9620b1b69bc2e3e4feed2337ad92867738d04. Anyway, although this seemed like a good idea, problem is it clobbers the original state of the connection without any explicit user action if the connection is configured to use both manual and auto DNS. And this happens in practice for imported Wireguard connections, which uselessly have auto DNS enabled due to this NetworkManager bug: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1399 Additional discussion: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1745#note_2112420 The simplest solution is to not try to prevent the user from configuring both manual and auto DNS. Instead, let's just warn the user that this configuration may not be intended in a follow-up commit. Fixes #2617
2023-10-06 11:49:23 -05:00
g_signal_connect_object (self->auto_dns_switch, "notify::active", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
network: warn user if both automatic and manual DNS is configured If you manually configure a DNS server, you probably don't want to also receive DNS from DHCP. Warn the user about this. This is a softer replacement for the fix from: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1914 which we found in #2617 broke imported Wireguard connections.
2023-10-06 13:37:08 -05:00
g_signal_connect_object (self->auto_dns_switch, "notify::active", G_CALLBACK (sync_dns_entry_warning), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
string = g_string_new ("");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
for (i = 0; i < nm_setting_ip_config_get_num_dns (self->setting); i++) {
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
const char *address;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
address = nm_setting_ip_config_get_dns (self->setting, i);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
if (i > 0)
g_string_append (string, ", ");
g_string_append (string, address);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (self->dns_entry), string->str);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (self->dns_entry, "notify::text", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
network: warn user if both automatic and manual DNS is configured If you manually configure a DNS server, you probably don't want to also receive DNS from DHCP. Warn the user about this. This is a softer replacement for the fix from: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1914 which we found in #2617 broke imported Wireguard connections.
2023-10-06 13:37:08 -05:00
g_signal_connect_object (self->dns_entry, "notify::text", G_CALLBACK (sync_dns_entry_warning), self, G_CONNECT_SWAPPED);
sync_dns_entry_warning (self);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
g_string_free (string, TRUE);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_route_row (CEPageIP4 *self,
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *address,
const gchar *netmask,
const gchar *gateway,
gint metric)
{
GtkWidget *row;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *widget;
GtkWidget *delete_button;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row = gtk_list_box_row_new ();
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_list_box_row_set_activatable (GTK_LIST_BOX_ROW (row), FALSE);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
row_box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_widget_add_css_class (row_box, "linked");
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
widget = GTK_WIDGET (ce_ip_address_entry_new (AF_INET));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_routes_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "address", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), address);
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->routes_address_label, NULL,
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
gtk_size_group_add_widget (self->routes_address_sizegroup, widget);
network/connection-editor: Fixup creation of the netmask widget Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1274 Signed-off-by: Igor Raits <igor.raits@gmail.com>
2021-03-06 22:07:29 +01:00
widget = GTK_WIDGET (ce_netmask_entry_new ());
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_routes_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "netmask", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), netmask);
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->routes_netmask_label, NULL,
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
gtk_size_group_add_widget (self->routes_netmask_sizegroup, widget);
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
widget = GTK_WIDGET (ce_ip_address_entry_new (AF_INET));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_routes_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "gateway", widget);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), gateway ? gateway : "");
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->routes_gateway_label, NULL,
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
gtk_size_group_add_widget (self->routes_gateway_sizegroup, widget);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (widget, "changed", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
g_signal_connect_object (widget, "activate", G_CALLBACK (ensure_empty_routes_row), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "metric", widget);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (metric >= 0) {
network: Use g_autofree for strings
2019-09-12 11:40:48 +12:00
g_autofree gchar *s = g_strdup_printf ("%d", metric);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_text (GTK_EDITABLE (widget), s);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_editable_set_width_chars (GTK_EDITABLE (widget), 5);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_accessible_update_relation (GTK_ACCESSIBLE (widget),
GTK_ACCESSIBLE_RELATION_LABELLED_BY, self->routes_metric_label, NULL,
-1);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), widget);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_size_group_add_widget (self->routes_metric_sizegroup, widget);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
delete_button = gtk_button_new_from_icon_name ("edit-delete-symbolic");
gtk_widget_set_sensitive (delete_button, FALSE);
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (delete_button, "clicked", G_CALLBACK (remove_row), self, G_CONNECT_SWAPPED);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_accessible_update_property (GTK_ACCESSIBLE (delete_button),
GTK_ACCESSIBLE_PROPERTY_LABEL, _("Delete Route"),
-1);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_halign (delete_button, GTK_ALIGN_CENTER);
gtk_widget_set_valign (delete_button, GTK_ALIGN_CENTER);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_box_append (GTK_BOX (row_box), delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "delete-button", delete_button);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_size_group_add_widget (self->routes_sizegroup, delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_list_box_row_set_child (GTK_LIST_BOX_ROW (row), row_box);
gtk_list_box_append (GTK_LIST_BOX (self->routes_list), row);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
update_row_sensitivity (self, self->routes_list);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ensure_empty_routes_row (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child = gtk_widget_get_last_child (self->routes_list);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
/* Add the last, stub row if needed*/
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
if (!child || validate_row (child))
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_route_row (self, "", "", "", -1);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
add_route_config_box (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
GtkWidget *list;
gint i;
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
self->routes_list = list = gtk_list_box_new ();
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
gtk_list_box_set_selection_mode (GTK_LIST_BOX (list), GTK_SELECTION_NONE);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_box_append (GTK_BOX (self->route_config_box), list);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
gtk_switch_set_active (self->auto_routes_switch, !nm_setting_ip_config_get_ignore_auto_routes (self->setting));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (self->auto_routes_switch, "notify::active", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
for (i = 0; i < nm_setting_ip_config_get_num_routes (self->setting); i++) {
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMIPRoute *route;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
struct in_addr tmp_addr;
gchar netmask[INET_ADDRSTRLEN + 1];
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
route = nm_setting_ip_config_get_route (self->setting, i);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (!route)
continue;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
tmp_addr.s_addr = nm_utils_ip4_prefix_to_netmask (nm_ip_route_get_prefix (route));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
(void) inet_ntop (AF_INET, &tmp_addr, &netmask[0], sizeof (netmask));
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_route_row (self,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_ip_route_get_dest (route),
netmask,
nm_ip_route_get_next_hop (route),
nm_ip_route_get_metric (route));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
if (nm_setting_ip_config_get_num_routes (self->setting) == 0)
ensure_empty_routes_row (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
connect_ip4_page (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
const gchar *str_method;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
gchar *method;
network: Store widgets inside objects This is a step towards replacing GtkBuilder with GtkTemplate
2019-10-15 12:25:48 +13:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
add_address_box (self);
add_dns_section (self);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
add_route_config_box (self);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
str_method = nm_setting_ip_config_get_method (self->setting);
network: Add option for connection sharing Introduce a new IP{4,6} config method to allow sharing the default network (usually the Internet) through the wired interface. This is needed because the control-panel is lacking this feature backed by nm and currently the only way to enable the connection sharing is by using nm-connection-editor.
2018-07-11 19:36:54 +01:00
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method = "automatic";
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (g_strcmp0 (str_method, NM_SETTING_IP4_CONFIG_METHOD_LINK_LOCAL) == 0) {
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method = "local";
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
} else if (g_strcmp0 (str_method, NM_SETTING_IP4_CONFIG_METHOD_MANUAL) == 0) {
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method = "manual";
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
} else if (g_strcmp0 (str_method, NM_SETTING_IP4_CONFIG_METHOD_SHARED) == 0) {
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method = "shared";
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
} else if (g_strcmp0 (str_method, NM_SETTING_IP4_CONFIG_METHOD_DISABLED) == 0) {
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method = "disabled";
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gtk_check_button_set_active (GTK_CHECK_BUTTON (self->never_default_check),
nm_setting_ip_config_get_never_default (self->setting));
network: Connect signals with g_signal_connect_object in swapped form
2019-11-22 16:21:43 +13:00
g_signal_connect_object (self->never_default_check, "toggled", G_CALLBACK (ce_page_changed), self, G_CONNECT_SWAPPED);
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
g_action_group_change_action_state (self->method_group, "ip4method", g_variant_new_string (method));
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
method_changed (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static gboolean
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ui_to_setting (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
const gchar *method;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
g_autoptr(GVariant) method_variant = NULL;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gboolean ignore_auto_dns;
gboolean ignore_auto_routes;
gboolean never_default;
GPtrArray *addresses = NULL;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
GPtrArray *dns_servers = NULL;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GPtrArray *routes = NULL;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
GtkWidget *child;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
GStrv dns_addresses = NULL;
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
gboolean ret = TRUE;
network: Fix application of the default gateway Now that we ensured that only the first address has a gateway entry, read it and apply it. See https://bugzilla.gnome.org/show_bug.cgi?id=765969 https://bugzilla.gnome.org/show_bug.cgi?id=771515
2016-09-16 17:01:36 +02:00
const char *default_gateway = NULL;
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
gboolean add_addresses = FALSE;
gboolean add_routes = FALSE;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
gchar *dns_text = NULL;
guint i;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
method_variant = g_action_group_get_action_state (self->method_group, "ip4method");
method = g_variant_get_string (method_variant, NULL);
if (g_str_equal (method, "disabled"))
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP4_CONFIG_METHOD_DISABLED;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
else if (g_str_equal (method, "automatic"))
network: cleanup: Rework disabled toggle button The disable toggle button isn't special and there is no real need for it to not be managed as all the other radio buttons.
2018-07-20 11:26:05 +01:00
method = NM_SETTING_IP4_CONFIG_METHOD_AUTO;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
else if (g_str_equal (method, "local"))
network: cleanup: Rework disabled toggle button The disable toggle button isn't special and there is no real need for it to not be managed as all the other radio buttons.
2018-07-20 11:26:05 +01:00
method = NM_SETTING_IP4_CONFIG_METHOD_LINK_LOCAL;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
else if (g_str_equal (method, "manual"))
network: cleanup: Rework disabled toggle button The disable toggle button isn't special and there is no real need for it to not be managed as all the other radio buttons.
2018-07-20 11:26:05 +01:00
method = NM_SETTING_IP4_CONFIG_METHOD_MANUAL;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
else if (g_str_equal (method, "shared"))
network: Add option for connection sharing Introduce a new IP{4,6} config method to allow sharing the default network (usually the Internet) through the wired interface. This is needed because the control-panel is lacking this feature backed by nm and currently the only way to enable the connection sharing is by using nm-connection-editor.
2018-07-11 19:36:54 +01:00
method = NM_SETTING_IP4_CONFIG_METHOD_SHARED;
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
else
g_assert_not_reached ();
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Fix compilation warnings Those come from the fixes made in commits 981c354 and 7f601cf. https://bugzilla.gnome.org/show_bug.cgi?id=771538
2016-09-16 16:51:14 +02:00
addresses = g_ptr_array_new_with_free_func ((GDestroyNotify) nm_ip_address_unref);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
add_addresses = g_str_equal (method, NM_SETTING_IP4_CONFIG_METHOD_MANUAL);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (self->address_list);
add_addresses && child;
child = gtk_widget_get_next_sibling (child)) {
GtkWidget *row = child;
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
CEIPAddressEntry *address_entry;
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
CENetmaskEntry *netmask_entry;
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
CEIPAddressEntry *gateway_entry;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMIPAddress *addr;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
address_entry = CE_IP_ADDRESS_ENTRY (g_object_get_data (G_OBJECT (row), "address"));
if (!address_entry)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
netmask_entry = CE_NETMASK_ENTRY (g_object_get_data (G_OBJECT (row), "netmask"));
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
gateway_entry = CE_IP_ADDRESS_ENTRY (g_object_get_data (G_OBJECT (row), "gateway"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
if (ce_ip_address_entry_is_empty (address_entry) && ce_netmask_entry_is_empty (netmask_entry) && ce_ip_address_entry_is_empty (gateway_entry)) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
/* ignore empty rows */
continue;
}
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
if (!ce_ip_address_entry_is_valid (address_entry))
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
if (!ce_netmask_entry_is_valid (netmask_entry))
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
if (!ce_ip_address_entry_is_valid (gateway_entry)) {
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
if (!ce_ip_address_entry_is_empty (gateway_entry)) {
network: Fix application of the default gateway Now that we ensured that only the first address has a gateway entry, read it and apply it. See https://bugzilla.gnome.org/show_bug.cgi?id=765969 https://bugzilla.gnome.org/show_bug.cgi?id=771515
2016-09-16 17:01:36 +02:00
g_assert (default_gateway == NULL);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
default_gateway = gtk_editable_get_text (GTK_EDITABLE (gateway_entry));
network: Fix application of the default gateway Now that we ensured that only the first address has a gateway entry, read it and apply it. See https://bugzilla.gnome.org/show_bug.cgi?id=765969 https://bugzilla.gnome.org/show_bug.cgi?id=771515
2016-09-16 17:01:36 +02:00
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
continue;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
addr = nm_ip_address_new (AF_INET, gtk_editable_get_text (GTK_EDITABLE (address_entry)), ce_netmask_entry_get_prefix (netmask_entry), NULL);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (addr)
g_ptr_array_add (addresses, addr);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
if (!gtk_widget_get_next_sibling (row))
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ensure_empty_address_row (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
if (addresses->len == 0) {
g_ptr_array_free (addresses, TRUE);
addresses = NULL;
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
dns_servers = g_ptr_array_new_with_free_func (g_free);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
dns_text = g_strstrip (g_strdup (gtk_editable_get_text (GTK_EDITABLE (self->dns_entry))));
Revert "network: Disable DNS entry if the automatic option is enabled" This reverts commit 8a4a80b7b2c2c460ad6b12a48d7cc78da5d97d35. This is a manual revert, because the code changed considerably in a2b9620b1b69bc2e3e4feed2337ad92867738d04. Anyway, although this seemed like a good idea, problem is it clobbers the original state of the connection without any explicit user action if the connection is configured to use both manual and auto DNS. And this happens in practice for imported Wireguard connections, which uselessly have auto DNS enabled due to this NetworkManager bug: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1399 Additional discussion: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1745#note_2112420 The simplest solution is to not try to prevent the user from configuring both manual and auto DNS. Instead, let's just warn the user that this configuration may not be intended in a follow-up commit. Fixes #2617
2023-10-06 11:49:23 -05:00
if (g_str_equal (method, NM_SETTING_IP4_CONFIG_METHOD_AUTO) ||
g_str_equal (method, NM_SETTING_IP4_CONFIG_METHOD_MANUAL))
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
dns_addresses = g_strsplit_set (dns_text, ", ", -1);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
else
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
dns_addresses = NULL;
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
for (i = 0; dns_addresses && dns_addresses[i]; i++) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *text;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
text = dns_addresses[i];
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
if (!text || !*text)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
if (!nm_utils_ipaddr_valid (AF_INET, text)) {
g_ptr_array_remove_range (dns_servers, 0, dns_servers->len);
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
widget_set_error (GTK_WIDGET (self->dns_entry));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
break;
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
} else {
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
widget_unset_error (GTK_WIDGET (self->dns_entry));
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
g_ptr_array_add (dns_servers, g_strdup (text));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
}
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
g_clear_pointer (&dns_addresses, g_strfreev);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: unset DNS entry errors when entry is empty When the entry is initially empty, there is no error. If you enter anything and then delete it, the entry is left in the error state. Empty should not be an error.
2023-10-06 13:31:43 -05:00
if (dns_text[0] == '\0')
widget_unset_error (GTK_WIDGET (self->dns_entry));
network: Fix crash when changing IPv4 DNS The dns_servers GStrv was not NULL-terminated because we forgot to append a NULL item to the GPtrArray that we used to construct it. https://bugzilla.gnome.org/show_bug.cgi?id=771251
2016-09-13 11:45:20 +02:00
if (dns_servers->len == 0) {
g_ptr_array_free (dns_servers, TRUE);
dns_servers = NULL;
} else {
g_ptr_array_add (dns_servers, NULL);
}
network: Fix compilation warnings Those come from the fixes made in commits 981c354 and 7f601cf. https://bugzilla.gnome.org/show_bug.cgi?id=771538
2016-09-16 16:51:14 +02:00
routes = g_ptr_array_new_with_free_func ((GDestroyNotify) nm_ip_route_unref);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
add_routes = g_str_equal (method, NM_SETTING_IP4_CONFIG_METHOD_AUTO) ||
g_str_equal (method, NM_SETTING_IP4_CONFIG_METHOD_MANUAL);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
for (child = gtk_widget_get_first_child (self->routes_list);
add_routes && child;
child = gtk_widget_get_next_sibling (child)) {
GtkWidget *row = child;
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
CEIPAddressEntry *address_entry;
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
CENetmaskEntry *netmask_entry;
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
CEIPAddressEntry *gateway_entry;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *text_metric;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
gint64 metric;
NMIPRoute *route;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
address_entry = CE_IP_ADDRESS_ENTRY (g_object_get_data (G_OBJECT (row), "address"));
if (!address_entry)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
netmask_entry = CE_NETMASK_ENTRY (g_object_get_data (G_OBJECT (row), "netmask"));
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
gateway_entry = CE_IP_ADDRESS_ENTRY (g_object_get_data (G_OBJECT (row), "gateway"));
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
text_metric = gtk_editable_get_text (GTK_EDITABLE (g_object_get_data (G_OBJECT (row), "metric")));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
if (ce_ip_address_entry_is_empty (address_entry) && ce_netmask_entry_is_empty (netmask_entry) && ce_ip_address_entry_is_empty (gateway_entry) && !*text_metric) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
/* ignore empty rows */
continue;
}
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
if (!ce_ip_address_entry_is_valid (address_entry))
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CENetmaskEntry
2020-12-02 11:22:32 +13:00
if (!ce_netmask_entry_is_valid (netmask_entry))
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Make CEIPAddressEntry
2020-12-02 11:11:02 +13:00
if (!ce_ip_address_entry_is_valid (gateway_entry))
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
metric = -1;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (*text_metric) {
errno = 0;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
metric = g_ascii_strtoull (text_metric, NULL, 10);
if (errno || metric < 0 || metric > G_MAXUINT32) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (GTK_WIDGET (g_object_get_data (G_OBJECT (row), "metric")));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (GTK_WIDGET (g_object_get_data (G_OBJECT (row), "metric")));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
} else {
widget_unset_error (GTK_WIDGET (g_object_get_data (G_OBJECT (row), "metric")));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
continue;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
route = nm_ip_route_new (AF_INET,
gtk_editable_get_text (GTK_EDITABLE (address_entry)),
ce_netmask_entry_get_prefix (netmask_entry),
gtk_editable_get_text (GTK_EDITABLE (gateway_entry)),
metric, NULL);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (route)
g_ptr_array_add (routes, route);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
if (!gtk_widget_get_next_sibling (row))
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ensure_empty_routes_row (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
if (routes->len == 0) {
g_ptr_array_free (routes, TRUE);
routes = NULL;
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
goto out;
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ignore_auto_dns = !gtk_switch_get_active (self->auto_dns_switch);
ignore_auto_routes = !gtk_switch_get_active (self->auto_routes_switch);
network: Port to GTK4 Boy this was hard. To ease the pain of porting wireless-security to GTK4, add a new WsFileChooserButton class that mimics the behavior of a button that triggers a filechooser, as per the migration guide suggests. There were lots of GtkGrids, so the diff is particularly horrendous. Sorry. This needs serious testing before landing.
2021-11-29 10:37:01 -03:00
never_default = gtk_check_button_get_active (GTK_CHECK_BUTTON (self->never_default_check));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
g_object_set (self->setting,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NM_SETTING_IP_CONFIG_METHOD, method,
NM_SETTING_IP_CONFIG_ADDRESSES, addresses,
network: Fix application of the default gateway Now that we ensured that only the first address has a gateway entry, read it and apply it. See https://bugzilla.gnome.org/show_bug.cgi?id=765969 https://bugzilla.gnome.org/show_bug.cgi?id=771515
2016-09-16 17:01:36 +02:00
NM_SETTING_IP_CONFIG_GATEWAY, default_gateway,
network: Fix crash when changing IPv4 DNS The dns_servers GStrv was not NULL-terminated because we forgot to append a NULL item to the GPtrArray that we used to construct it. https://bugzilla.gnome.org/show_bug.cgi?id=771251
2016-09-13 11:45:20 +02:00
NM_SETTING_IP_CONFIG_DNS, dns_servers ? dns_servers->pdata : NULL,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NM_SETTING_IP_CONFIG_ROUTES, routes,
NM_SETTING_IP_CONFIG_IGNORE_AUTO_DNS, ignore_auto_dns,
NM_SETTING_IP_CONFIG_IGNORE_AUTO_ROUTES, ignore_auto_routes,
NM_SETTING_IP_CONFIG_NEVER_DEFAULT, never_default,
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
NULL);
out:
if (addresses)
g_ptr_array_free (addresses, TRUE);
if (dns_servers)
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
g_ptr_array_free (dns_servers, TRUE);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (routes)
g_ptr_array_free (routes, TRUE);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
g_clear_pointer (&dns_text, g_free);
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
return ret;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
static void
on_ip4_method_activated_cb (GSimpleAction* action,
GVariant* parameter,
gpointer user_data)
{
CEPageIP4 *self = CE_PAGE_IP4 (user_data);
g_simple_action_set_state (action, parameter);
method_changed (self);
}
network: Convert class property to a virtual method
2019-11-06 13:38:36 +13:00
static const gchar *
ce_page_ip4_get_title (CEPage *page)
{
return _("IPv4");
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static gboolean
network: Rename virtual method to standard names
2019-11-06 16:33:07 +13:00
ce_page_ip4_validate (CEPage *self,
NMConnection *connection,
GError **error)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
if (!ui_to_setting (CE_PAGE_IP4 (self)))
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
return FALSE;
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
return nm_setting_verify (NM_SETTING (CE_PAGE_IP4 (self)->setting), NULL, error);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
ce_page_ip4_init (CEPageIP4 *self)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
const GActionEntry ip4_entries[] = {
network: Fix "Missing initializer for field" warning
2023-10-05 20:43:06 +02:00
{ "ip4method", on_ip4_method_activated_cb, "s", "'automatic'", NULL, { 0 } },
network: keep track of radio buttons in connection editor with action Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal.
2022-12-12 17:44:51 +01:00
};
self->method_group = G_ACTION_GROUP (g_simple_action_group_new ());
g_action_map_add_action_entries (G_ACTION_MAP (self->method_group), ip4_entries, G_N_ELEMENTS (ip4_entries), self);
gtk_widget_insert_action_group (GTK_WIDGET (self), "ip4page", G_ACTION_GROUP (self->method_group));
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_init_template (GTK_WIDGET (self));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
ce_page_ip4_class_init (CEPageIP4Class *klass)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/control-center/network/ip4-page.ui");
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_box);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_sizegroup);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, auto_dns_label);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, auto_dns_switch);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, auto_routes_label);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, auto_routes_switch);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, content_box);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, dns_box);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, dns_entry);
network: Make IPv4/v6 pages drive the scrolledwindow adjustments Those 2 pages in the connection editor dialog are scrollable, but don't hook focus changes so they drive the adjustments. Make them do so.
2019-12-12 16:20:57 +01:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, main_box);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, never_default_check);
Address review feedback
2022-05-10 10:43:50 +02:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_address_label);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_netmask_label);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, address_gateway_label);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_box);
network: fix sensitivity of DNS and route configuration widgets When the IP method is "disabled" or "shared" then everything else is supposed to be insensitive. This currently fails if you toggle between the two, because it's implemented using property bindings that are just not smart enough to handle this task. Handle sensitivity only in method_changed() to avoid this. Additionally, not all of the widgets are being consistently disabled/enabled when appropriate. E.g. when the method is "local" then only the DNS entry, route entries, and default route checkboxes become insensitive, leaving the other widgets, including notably the Automatic switches, sensitive. They should all become insensitive, as when the method is "disabled" or "shared." Fix this by organizing all the related widgets into boxes and setting the sensitivity of the entire box. (Note the strategy followed here does not exactly match nm-connection-editor, which always allows editing addresses. We only allow that in Manual mode. I'm not sure if this is advisable or not, so won't touch that.) Finally, the Automatic DNS and Automatic Routes toggles should only be sensitive when the method is "Automatic".
2023-10-13 14:03:43 -05:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, route_config_box);
Make the network settings panel more screen reader friendly
2022-04-29 11:28:11 +02:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_address_label);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_netmask_label);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_gateway_label);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_metric_label);
network-connection-editor: Align Routes labels Even though the routes_metric_label is in a GtkSizeGroup with the GtkEntry for the metric, its size was set too big after adding the entry to the size group. To fix this, add all the other labels and corresponding entries to size groups as well. The hexpand can then be removed as well on the labels. Fixes #1235
2023-10-18 22:20:46 +02:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_address_sizegroup);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_netmask_sizegroup);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_gateway_sizegroup);
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_metric_sizegroup);
gtk_widget_class_bind_template_child (widget_class, CEPageIP4, routes_sizegroup);
network: Convert CEPage from a class to an interface
2019-11-06 17:07:42 +13:00
}
static void
ce_page_iface_init (CEPageInterface *iface)
{
iface->get_title = ce_page_ip4_get_title;
iface->validate = ce_page_ip4_validate;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
CEPageIP4 *
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
ce_page_ip4_new (NMConnection *connection,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMClient *client)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
CEPageIP4 *self;
network: Move GtkBuilder code from CEPage to its subclasses
2019-11-06 15:05:29 +13:00
network: Move connection reference outside of CEPage
2019-11-06 15:50:40 +13:00
self = CE_PAGE_IP4 (g_object_new (ce_page_ip4_get_type (), NULL));
network: Move GtkBuilder code from CEPage to its subclasses
2019-11-06 15:05:29 +13:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
self->setting = nm_connection_get_setting_ip4_config (connection);
if (!self->setting) {
self->setting = NM_SETTING_IP_CONFIG (nm_setting_ip4_config_new ());
nm_connection_add_setting (connection, NM_SETTING (self->setting));
network: Implement the new design for wired This expands the connection editor to cover ethernet, and adds support for multiple wired profiles.
2012-12-17 14:17:42 -05:00
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use self variable name consistently
2019-10-18 11:47:17 +13:00
connect_ip4_page (self);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Convert CEPage widgets to GtkTemplate
2019-11-06 17:16:54 +13:00
return self;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
Reference in a new issue Copy permalink