diff --git a/capplets/background/ChangeLog b/capplets/background/ChangeLog index 2727b8207..ff25fca74 100644 --- a/capplets/background/ChangeLog +++ b/capplets/background/ChangeLog @@ -1,3 +1,16 @@ +2005-07-25 Sebastien Bacher + + * gnome-background-properties.glade: Replace GnomeColorPicker with + the GtkColorButton widget + Some properties were added by newer version of glade + + * gnome-wp-capplet.c (gnome_wp_props_wp_set): + (gnome_wp_[s]color_changed, gnome_wp_color[12]_changed): + (gnome_wp_load_stuffs, wallpaper_properties_init): + Update to use the API for GtkColorButton instead of GnomeColorPicker + + Fixes #171676 + 2005-07-14 Rodney Dawes * gnome-wp-xml.c (gnome_wp_xml_load_xml): If xmlParseFile returns diff --git a/capplets/background/gnome-background-properties.glade b/capplets/background/gnome-background-properties.glade index c351c99b2..4c2008fef 100644 --- a/capplets/background/gnome-background-properties.glade +++ b/capplets/background/gnome-background-properties.glade @@ -14,6 +14,12 @@ 418 True False + True + False + False + GDK_WINDOW_TYPE_HINT_DIALOG + GDK_GRAVITY_NORTH_WEST + True False @@ -35,6 +41,7 @@ gtk-help True GTK_RELIEF_NORMAL + True -11 @@ -47,6 +54,7 @@ gtk-close True GTK_RELIEF_NORMAL + True -7 @@ -80,6 +88,10 @@ 0 0 wp_tree + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -107,6 +119,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -128,6 +144,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -165,6 +185,9 @@ False False True + False + False + False @@ -202,6 +225,10 @@ 0 0 style_menu + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -230,6 +257,7 @@ gtk-remove True GTK_RELIEF_NORMAL + True 0 @@ -244,6 +272,7 @@ True True GTK_RELIEF_NORMAL + True @@ -252,6 +281,10 @@ 0.5 0 0 + 0 + 0 + 0 + 0 @@ -289,6 +322,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -343,6 +380,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -365,6 +406,10 @@ 0 0 color_menu + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -392,6 +437,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -413,6 +462,10 @@ 0.5 0 0 + PANGO_ELLIPSIZE_NONE + -1 + False + 0 0 @@ -435,12 +488,14 @@ - + True True - True False - Pick a color + True + + Open a dialog to specify the color + 0 @@ -450,11 +505,14 @@ - + + True True - True False - Pick a color + True + + Open a dialog to specify the color + 0 diff --git a/capplets/background/gnome-wp-capplet.c b/capplets/background/gnome-wp-capplet.c index 90467d188..7a750f2e2 100644 --- a/capplets/background/gnome-wp-capplet.c +++ b/capplets/background/gnome-wp-capplet.c @@ -306,14 +306,8 @@ static gboolean gnome_wp_props_wp_set (GnomeWPCapplet * capplet) { gconf_change_set_unref (cs); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->pc_picker), - item->pcolor->red, - item->pcolor->green, - item->pcolor->blue, 65535); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->sc_picker), - item->scolor->red, - item->scolor->green, - item->scolor->blue, 65535); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->pc_picker), item->pcolor); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->sc_picker), item->scolor); g_free (wpfile); @@ -509,20 +503,18 @@ static void gnome_wp_color_changed (GnomeWPCapplet * capplet, } g_free (item->pri_color); - gnome_color_picker_get_i16 (GNOME_COLOR_PICKER (capplet->pc_picker), - &item->pcolor->red, - &item->pcolor->green, - &item->pcolor->blue, NULL); + + gtk_color_button_get_color (GTK_COLOR_BUTTON (capplet->pc_picker), item->pcolor); + item->pri_color = g_strdup_printf ("#%02X%02X%02X", item->pcolor->red >> 8, item->pcolor->green >> 8, item->pcolor->blue >> 8); g_free (item->sec_color); - gnome_color_picker_get_i16 (GNOME_COLOR_PICKER (capplet->sc_picker), - &item->scolor->red, - &item->scolor->green, - &item->scolor->blue, NULL); + + gtk_color_button_get_color (GTK_COLOR_BUTTON (capplet->sc_picker), item->scolor); + item->sec_color = g_strdup_printf ("#%02X%02X%02X", item->scolor->red >> 8, item->scolor->green >> 8, @@ -553,7 +545,6 @@ static void gnome_wp_color_changed (GnomeWPCapplet * capplet, } static void gnome_wp_scolor_changed (GtkWidget * widget, - guint r, guint g, guint b, guint a, GnomeWPCapplet * capplet) { gnome_wp_color_changed (capplet, TRUE); } @@ -620,14 +611,9 @@ static gboolean gnome_wp_load_stuffs (void * data) { gnome_wp_option_menu_set (capplet, item->options, FALSE); gnome_wp_option_menu_set (capplet, item->shade_type, TRUE); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->pc_picker), - item->pcolor->red, - item->pcolor->green, - item->pcolor->blue, 65535); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->sc_picker), - item->scolor->red, - item->scolor->green, - item->scolor->blue, 65535); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->pc_picker), item->pcolor); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->sc_picker), item->pcolor); + } else if (strcmp (style, "none") != 0) { item = gnome_wp_add_image (capplet, imagepath); gnome_wp_capplet_scroll_to_item (capplet, item); @@ -770,10 +756,8 @@ static void gnome_wp_color1_changed (GConfClient * client, guint id, gdk_color_parse (colorhex, &color); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->pc_picker), - color.red, - color.green, - color.blue, 65535); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->pc_picker), &color); + gnome_wp_color_changed (capplet, FALSE); } @@ -788,10 +772,7 @@ static void gnome_wp_color2_changed (GConfClient * client, guint id, gdk_color_parse (colorhex, &color); - gnome_color_picker_set_i16 (GNOME_COLOR_PICKER (capplet->sc_picker), - color.red, - color.green, - color.blue, 65535); + gtk_color_button_set_color (GTK_COLOR_BUTTON (capplet->sc_picker), &color); gnome_wp_color_changed (capplet, FALSE); } @@ -1225,11 +1206,11 @@ static void wallpaper_properties_init (poptContext ctx) { G_CALLBACK (gnome_wp_shade_type_changed), capplet); capplet->pc_picker = glade_xml_get_widget (dialog,"pcpicker"); - g_signal_connect (G_OBJECT (capplet->pc_picker), "color_set", + g_signal_connect (G_OBJECT (capplet->pc_picker), "color-set", G_CALLBACK (gnome_wp_scolor_changed), capplet); capplet->sc_picker = glade_xml_get_widget (dialog,"scpicker"); - g_signal_connect (G_OBJECT (capplet->sc_picker), "color_set", + g_signal_connect (G_OBJECT (capplet->sc_picker), "color-set", G_CALLBACK (gnome_wp_scolor_changed), capplet); g_signal_connect (G_OBJECT (capplet->window), "response",