tiny optimization
2007-08-09 Jens Granseuer <jensgr@gmx.net> * gnome-wp-xml.c: (gnome_wp_xml_load_list), (gnome_wp_xml_save_list): * theme-installer.c: (gnome_theme_install_from_uri): tiny optimization svn path=/trunk/; revision=7982
This commit is contained in:
parent
4279e8b062
commit
08d807cfb4
3 changed files with 11 additions and 5 deletions
|
@ -1,3 +1,9 @@
|
|||
2007-08-09 Jens Granseuer <jensgr@gmx.net>
|
||||
|
||||
* gnome-wp-xml.c: (gnome_wp_xml_load_list),
|
||||
(gnome_wp_xml_save_list):
|
||||
* theme-installer.c: (gnome_theme_install_from_uri): tiny optimization
|
||||
|
||||
2007-08-08 Jens Granseuer <jensgr@gmx.net>
|
||||
|
||||
* appearance-style.c: (gtk_theme_changed): revert r7973 because it
|
||||
|
|
|
@ -287,7 +287,7 @@ void gnome_wp_xml_load_list (AppearanceData *data) {
|
|||
g_free (wpdbfile);
|
||||
|
||||
xdgdirslist = g_getenv ("XDG_DATA_DIRS");
|
||||
if (xdgdirslist == NULL || strlen (xdgdirslist) == 0)
|
||||
if (xdgdirslist == NULL || strcmp (xdgdirslist, "") == 0)
|
||||
xdgdirslist = "/usr/local/share:/usr/share";
|
||||
|
||||
xdgdirs = g_strsplit (xdgdirslist, ":", -1);
|
||||
|
@ -363,7 +363,7 @@ void gnome_wp_xml_save_list (AppearanceData *data) {
|
|||
gchar * wpfile;
|
||||
|
||||
g_hash_table_foreach (data->wp_hash,
|
||||
(GHFunc) gnome_wp_list_flatten, &list);
|
||||
(GHFunc) gnome_wp_list_flatten, &list);
|
||||
g_hash_table_destroy (data->wp_hash);
|
||||
list = g_slist_reverse (list);
|
||||
|
||||
|
@ -384,7 +384,7 @@ void gnome_wp_xml_save_list (AppearanceData *data) {
|
|||
const char * none = "(none)";
|
||||
gchar * filename;
|
||||
|
||||
if (!strncmp (wpitem->filename, none, strlen (none)) ||
|
||||
if (!strcmp (wpitem->filename, none) ||
|
||||
(g_utf8_validate (wpitem->filename, -1, NULL) &&
|
||||
g_file_test (wpitem->filename, G_FILE_TEST_EXISTS)))
|
||||
filename = g_strdup (wpitem->filename);
|
||||
|
@ -401,7 +401,7 @@ void gnome_wp_xml_save_list (AppearanceData *data) {
|
|||
item = xmlNewTextChild (wallpaper, NULL, (xmlChar *)"scolor", (xmlChar *)wpitem->sec_color);
|
||||
g_free (filename);
|
||||
|
||||
list = g_slist_remove (list, wpitem);
|
||||
list = g_slist_delete_link (list, list);
|
||||
gnome_wp_item_free (wpitem);
|
||||
}
|
||||
xmlSaveFormatFile (wpfile, wplist, 1);
|
||||
|
|
|
@ -488,7 +488,7 @@ gnome_theme_install_from_uri (gchar *filename, GtkWindow *parent)
|
|||
gchar *temppath;
|
||||
const gchar *template;
|
||||
|
||||
if (filename == NULL || strlen (filename) <= 0) {
|
||||
if (filename == NULL || strcmp (filename, "") == 0) {
|
||||
dialog = gtk_message_dialog_new (NULL,
|
||||
GTK_DIALOG_MODAL,
|
||||
GTK_MESSAGE_ERROR,
|
||||
|
|
Loading…
Add table
Reference in a new issue