applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

user-accounts: prevent the only Administrator from being demoted

Browse source 
If there is only one account of type Adminstrator and it is demoted to type
Standard the user can be left unable to unlock panels and perform other
Administrator tasks - prevent this by only allowing the Account Type to be
changed when the account is a standard user or, in the case that the account
is an Administrator, when there is one or more other Administrators.

https://bugzilla.gnome.org/show_bug.cgi?id=690246
This commit is contained in:
Joshua Lock 2013-05-29 17:16:47 -07:00 • committed by Thomas Wood
parent b906d32e4c
commit 0adf7c2073
1 changed files with 46 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

48
panels/user-accounts/um-user-panel.c
View file

@ -1043,6 +1043,42 @@ remove_unlock_tooltip (GtkWidget *button)
G_CALLBACK (show_tooltip_now), NULL); G_CALLBACK (show_tooltip_now), NULL);
} }
static guint
get_num_admin (ActUserManager *um)
{
GSList *list;
GSList *l;
guint num_admin = 0;
list = act_user_manager_list_users (um);
for (l = list; l != NULL; l = l->next) {
ActUser *u = l->data;
if (act_user_get_account_type (u) == ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR) {
num_admin++;
}
}
g_slist_free (list);
return num_admin;
}
static gboolean
would_demote_only_admin (ActUser *user,
ActUserManager *um)
{
/* Prevent the user from demoting the only admin account.
* Returns TRUE when user is an administrator and there is only
* one administrator */
if (act_user_get_account_type (user) == ACT_USER_ACCOUNT_TYPE_STANDARD)
return FALSE;
if (get_num_admin (um) > 1)
return FALSE;
return TRUE;
}
static void static void
on_permission_changed (GPermission *permission, on_permission_changed (GPermission *permission,
GParamSpec *pspec, GParamSpec *pspec,
@ -1110,7 +1146,11 @@ on_permission_changed (GPermission *permission,
remove_unlock_tooltip (get_widget (d, "autologin-switch")); remove_unlock_tooltip (get_widget (d, "autologin-switch"));
} else if (is_authorized && act_user_is_local_account (user)) { } else if (is_authorized && act_user_is_local_account (user)) {
um_editable_combo_set_editable (UM_EDITABLE_COMBO (get_widget (d, "account-type-combo")), TRUE); if (would_demote_only_admin (user, d->um)) {
um_editable_combo_set_editable (UM_EDITABLE_COMBO (get_widget (d, "account-type-combo")), FALSE);
} else {
um_editable_combo_set_editable (UM_EDITABLE_COMBO (get_widget (d, "account-type-combo")), TRUE);
}
remove_unlock_tooltip (get_widget (d, "account-type-combo")); remove_unlock_tooltip (get_widget (d, "account-type-combo"));
gtk_widget_set_sensitive (GTK_WIDGET (get_widget (d, "autologin-switch")), get_autologin_possible (user)); gtk_widget_set_sensitive (GTK_WIDGET (get_widget (d, "autologin-switch")), get_autologin_possible (user));
@ -1118,7 +1158,11 @@ on_permission_changed (GPermission *permission,
} }
else { else {
um_editable_combo_set_editable (UM_EDITABLE_COMBO (get_widget (d, "account-type-combo")), FALSE); um_editable_combo_set_editable (UM_EDITABLE_COMBO (get_widget (d, "account-type-combo")), FALSE);
add_unlock_tooltip (get_widget (d, "account-type-combo")); if (would_demote_only_admin (user, d->um)) {
remove_unlock_tooltip (get_widget (d, "account-type-combo"));
} else {
add_unlock_tooltip (get_widget (d, "account-type-combo"));
}
gtk_widget_set_sensitive (GTK_WIDGET (get_widget (d, "autologin-switch")), FALSE); gtk_widget_set_sensitive (GTK_WIDGET (get_widget (d, "autologin-switch")), FALSE);
add_unlock_tooltip (get_widget (d, "autologin-switch")); add_unlock_tooltip (get_widget (d, "autologin-switch"));
} }