applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network/ce: Provide error tooltip in connection editor

Browse source 
Pass through localized libnm error messages as tooltips
to the apply button. That way, users can easily identify
configuration errors.
This commit is contained in:
Christian Glombek 2022-06-20 13:46:30 +02:00 • committed by Robert Ancell
parent 3ca850b257
commit 0fbe2ada5a
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
panels/network/connection-editor/net-connection-editor.c
View file

@ -343,6 +343,7 @@ static void
validate (NetConnectionEditor *self)
{
gboolean valid = FALSE;
g_autofree gchar *apply_tooltip = NULL;
gint i;
if (!editor_is_initialized (self))
@ -356,15 +357,20 @@ validate (NetConnectionEditor *self)
if (!ce_page_validate (page, self->connection, &error)) {
valid = FALSE;
if (error) {
g_debug ("Invalid setting %s: %s", ce_page_get_title (page), error->message);
apply_tooltip = g_strdup_printf (_("Invalid setting %s: %s"), ce_page_get_title (page), error->message);
g_debug ("%s", apply_tooltip);
} else {
g_debug ("Invalid setting %s", ce_page_get_title (page));
apply_tooltip = g_strdup_printf (_("Invalid setting %s"), ce_page_get_title (page));
g_debug ("%s", apply_tooltip);
}
}
}
update_sensitivity (self);
done:
if (apply_tooltip != NULL)
gtk_widget_set_tooltip_text(GTK_WIDGET (self->apply_button), apply_tooltip);
gtk_widget_set_sensitive (GTK_WIDGET (self->apply_button), valid && self->is_changed);
}