applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Printers: Don't focus non-realized widgets

Browse source 
This commit removes focusing of widgets in authentication dialog
which could happen when user traverses Jobs dialog via Tab key
if there are some jobs which need authentication.
Lets rely on standard focus chain.
This commit is contained in:
Marek Kasik 2018-03-05 16:59:59 +01:00
parent 52e3bfaed2
commit 1225766e1f
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
panels/printers/pp-jobs-dialog.c
View file

@ -166,30 +166,21 @@ authenticate_popover_update (PpJobsDialog *dialog)
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "domain-entry"));
gtk_widget_set_visible (widget, domain_required);
if (domain_required)
{
gtk_entry_set_text (GTK_ENTRY (widget), "");
gtk_entry_grab_focus_without_selecting (GTK_ENTRY (widget));
}
gtk_entry_set_text (GTK_ENTRY (widget), "");
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "username-label"));
gtk_widget_set_visible (widget, username_required);
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "username-entry"));
gtk_widget_set_visible (widget, username_required);
if (username_required)
{
gtk_entry_set_text (GTK_ENTRY (widget), cupsUser ());
gtk_entry_grab_focus_without_selecting (GTK_ENTRY (widget));
}
gtk_entry_set_text (GTK_ENTRY (widget), cupsUser ());
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "password-label"));
gtk_widget_set_visible (widget, password_required);
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "password-entry"));
gtk_widget_set_visible (widget, password_required);
if (password_required)
{
gtk_entry_set_text (GTK_ENTRY (widget), "");
gtk_entry_grab_focus_without_selecting (GTK_ENTRY (widget));
}
gtk_entry_set_text (GTK_ENTRY (widget), "");
widget = GTK_WIDGET (gtk_builder_get_object (GTK_BUILDER (dialog->builder), "authenticate-button"));
gtk_widget_set_sensitive (widget, FALSE);