From 168e30a4104818a82c976c569c6c9bab61a73ee0 Mon Sep 17 00:00:00 2001
From: Automeris naranja <automerisnaranja@tutanota.com>
Date: Mon, 13 May 2024 20:15:37 -0300
Subject: [PATCH] general: Don't set some "Copy" buttons as activatable widgets

In rows that have a "Copy" button that is set as activatable
widget, Orca doesn't the buttons a11y label/tooltip; instead,
it reads "[row title] push button".

To fix this, don't set these buttons as activatable widgets.
---
 panels/sharing/cc-sharing-panel.ui                      | 3 +--
 panels/system/remote-desktop/cc-desktop-sharing-page.ui | 6 ++----
 panels/system/remote-desktop/cc-remote-login-page.ui    | 6 ++----
 panels/system/secure-shell/cc-secure-shell-page.ui      | 3 +--
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/panels/sharing/cc-sharing-panel.ui b/panels/sharing/cc-sharing-panel.ui
index 8c242e503..1e12b960d 100644
--- a/panels/sharing/cc-sharing-panel.ui
+++ b/panels/sharing/cc-sharing-panel.ui
@@ -75,14 +75,13 @@
                     <child>
                       <object class="AdwActionRow" id="personal_file_sharing_address_row">
                         <property name="title" translatable="yes">File Sharing _Address</property>
-                        <property name="activatable-widget">copy_file_sharing_address_button</property>
                         <property name="use-underline">True</property>
                         <property name="use-markup">False</property>
                         <style>
                           <class name="property"/>
                         </style>
                         <child type="suffix">
-                          <object class="GtkButton" id="copy_file_sharing_address_button">
+                          <object class="GtkButton">
                             <property name="valign">center</property>
                             <property name="tooltip-text" translatable="yes">Copy</property>
                             <property name="icon-name">edit-copy-symbolic</property>
diff --git a/panels/system/remote-desktop/cc-desktop-sharing-page.ui b/panels/system/remote-desktop/cc-desktop-sharing-page.ui
index fd244ba0a..c745ecf86 100644
--- a/panels/system/remote-desktop/cc-desktop-sharing-page.ui
+++ b/panels/system/remote-desktop/cc-desktop-sharing-page.ui
@@ -45,12 +45,11 @@
                   <object class="AdwActionRow" id="hostname_row">
                     <property name="title" translatable="yes">_Hostname</property>
                     <property name="use-underline">True</property>
-                    <property name="activatable-widget">copy_address_button</property>
                     <style>
                       <class name="property"/>
                     </style>
                     <child type="suffix">
-                      <object class="GtkButton" id="copy_address_button">
+                      <object class="GtkButton">
                         <property name="tooltip-text" translatable="yes">Copy</property>
                         <property name="valign">center</property>
                         <property name="icon-name">edit-copy-symbolic</property>
@@ -66,12 +65,11 @@
                   <object class="AdwActionRow" id="port_row">
                     <property name="title" translatable="yes">_Port</property>
                     <property name="use-underline">True</property>
-                    <property name="activatable-widget">copy_port_button</property>
                     <style>
                       <class name="property"/>
                     </style>
                     <child type="suffix">
-                      <object class="GtkButton" id="copy_port_button">
+                      <object class="GtkButton">
                         <property name="tooltip-text" translatable="yes">Copy</property>
                         <property name="valign">center</property>
                         <property name="icon-name">edit-copy-symbolic</property>
diff --git a/panels/system/remote-desktop/cc-remote-login-page.ui b/panels/system/remote-desktop/cc-remote-login-page.ui
index b83acb6e9..f5e742044 100644
--- a/panels/system/remote-desktop/cc-remote-login-page.ui
+++ b/panels/system/remote-desktop/cc-remote-login-page.ui
@@ -44,12 +44,11 @@
                       <object class="AdwActionRow" id="hostname_row">
                         <property name="title" translatable="yes">_Hostname</property>
                         <property name="use-underline">True</property>
-                        <property name="activatable-widget">copy_address_button</property>
                         <style>
                           <class name="property"/>
                         </style>
                         <child type="suffix">
-                          <object class="GtkButton" id="copy_address_button">
+                          <object class="GtkButton">
                             <property name="tooltip-text" translatable="yes">Copy</property>
                             <property name="valign">center</property>
                             <property name="icon-name">edit-copy-symbolic</property>
@@ -65,12 +64,11 @@
                       <object class="AdwActionRow" id="port_row">
                         <property name="title" translatable="yes">_Port</property>
                         <property name="use-underline">True</property>
-                        <property name="activatable-widget">copy_port_button</property>
                         <style>
                           <class name="property"/>
                         </style>
                         <child type="suffix">
-                          <object class="GtkButton" id="copy_port_button">
+                          <object class="GtkButton">
                             <property name="tooltip-text" translatable="yes">Copy</property>
                             <property name="valign">center</property>
                             <property name="icon-name">edit-copy-symbolic</property>
diff --git a/panels/system/secure-shell/cc-secure-shell-page.ui b/panels/system/secure-shell/cc-secure-shell-page.ui
index 6c970f714..7051c4e17 100644
--- a/panels/system/secure-shell/cc-secure-shell-page.ui
+++ b/panels/system/secure-shell/cc-secure-shell-page.ui
@@ -39,13 +39,12 @@
                     <child>
                       <object class="AdwActionRow" id="hostname_row">
                         <property name="title" translatable="yes">SSH Login _Command</property>
-                        <property name="activatable-widget">copy_ssh_login_command_button</property>
                         <property name="use-underline">True</property>
                         <style>
                           <class name="property"/>
                         </style>
                         <child type="suffix">
-                          <object class="GtkButton" id="copy_ssh_login_command_button">
+                          <object class="GtkButton">
                             <property name="valign">center</property>
                             <property name="tooltip-text" translatable="yes">Copy</property>
                             <property name="icon-name">edit-copy-symbolic</property>