applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network: Include the connection title in the sort string

Browse source 
The list of networks is sorted by connection type. If a user has e.g. a
lot of VPN connections, then the unsorted list is hard to browse.
To fix this, include the title of the connection in the sort order and
ensure the list is kept sorted when a title is changed.

Reported-by: Oliver Haessler <oliver@redhat.com>

https://bugzilla.gnome.org/show_bug.cgi?id=778685
This commit is contained in:
Benjamin Berg 2017-02-13 21:39:18 +01:00
parent f70ac1d863
commit 2c95c6a5d0
5 changed files with 62 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

20
panels/network/panel-common.c
View file

@ -73,38 +73,38 @@ panel_device_to_icon_name (NMDevice *device, gboolean symbolic)
}
/**
* panel_device_to_sortable_string:
* panel_device_get_sort_category:
*
* Try to return order of approximate connection speed.
* But sort wifi first, since thats the common case.
**/
const gchar *
panel_device_to_sortable_string (NMDevice *device)
gint
panel_device_get_sort_category (NMDevice *device)
{
const gchar *value = NULL;
gint value;
NMDeviceModemCapabilities caps;
switch (nm_device_get_device_type (device)) {
case NM_DEVICE_TYPE_ETHERNET:
value = "2";
value = 2;
break;
case NM_DEVICE_TYPE_WIFI:
value = "1";
value = 1;
break;
case NM_DEVICE_TYPE_MODEM:
caps = nm_device_modem_get_current_capabilities (NM_DEVICE_MODEM (device));
if ((caps & NM_DEVICE_MODEM_CAPABILITY_GSM_UMTS) ||
(caps & NM_DEVICE_MODEM_CAPABILITY_CDMA_EVDO)) {
value = "3";
value = 3;
}
break;
case NM_DEVICE_TYPE_BT:
value = "4";
value = 4;
break;
case NM_DEVICE_TYPE_OLPC_MESH:
value = "5";
value = 5;
break;
default:
value = "6";
value = 6;
break;
}
return value;