applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

system/about: Create CcSystemDetailsWindow upon opening

Browse source 
Initializing the About page involves creating a CcSystemDetailsWindow
too. This costs time, making the System panel open slower because it has
to wait for the About page to finish initializing.

By creating the CcSystemDetailsWindow only when it should be opened, we
save at least 0.1 s when opening the System panel.
This commit is contained in:
Matthijs Velsink 2024-02-02 01:02:41 +01:00 • committed by Felipe Borges
parent 5748c50f44
commit 343932964f
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
panels/system/about/cc-about-page.c
View file

@ -54,7 +54,6 @@ about_page_setup_overview (CcAboutPage *self)
g_autofree char *os_name_text = NULL;
g_autofree char *hardware_model_text = NULL;
g_autofree gchar *disk_capacity_string = NULL;
GtkWindow *parent;
hardware_model_text = get_hardware_model_string ();
cc_list_row_set_secondary_label (self->hardware_model_row, hardware_model_text);
@ -76,10 +75,6 @@ about_page_setup_overview (CcAboutPage *self)
os_name_text = get_os_name ();
cc_list_row_set_secondary_label (self->os_name_row, os_name_text);
self->system_details_window = GTK_WINDOW (cc_system_details_window_new ());
parent = (GtkWindow *) gtk_widget_get_native (GTK_WIDGET (self));
gtk_window_set_transient_for (GTK_WINDOW (self->system_details_window), parent);
}
static gboolean
@ -123,6 +118,9 @@ cc_about_page_open_system_details (CcAboutPage *self)
{
GtkNative *parent;
if (!self->system_details_window)
self->system_details_window = GTK_WINDOW (cc_system_details_window_new ());
parent = gtk_widget_get_native (GTK_WIDGET (self));
gtk_window_set_transient_for (self->system_details_window, GTK_WINDOW (parent));
gtk_window_present (GTK_WINDOW (self->system_details_window));