From 3ab4b333903b895e965b5526b1f5502fdeee45ee Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Fri, 17 Mar 2017 15:08:05 +0100 Subject: [PATCH] keyboard: Fix check for existing shortcut settings From a Coverity scan: panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop increment "i++;" is unreachable, the loop body will never execute more than once. This seems like a logic thinko introduced in commit 3207fe97ec516c11f2f781269f9342f36fa8161b . In practice it was unlikely to be a problem since we don't have repeated shortcut gsettings key names in all our KeyListEntries files. --- panels/keyboard/cc-keyboard-manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/panels/keyboard/cc-keyboard-manager.c b/panels/keyboard/cc-keyboard-manager.c index 1f90ca7bf..84e1e15d5 100644 --- a/panels/keyboard/cc-keyboard-manager.c +++ b/panels/keyboard/cc-keyboard-manager.c @@ -214,8 +214,6 @@ have_key_for_group (CcKeyboardManager *self, { return TRUE; } - - return FALSE; } }