applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

search-locations-dialog: Stop removing non-existent folders from tracker

Browse source 
This change effectively reverts commit 5c679301ec ("search: Invalidate
"Search Locations" list when folders can't be found").  The crash
that commits intends to fix does not occur on main anymore, and there's
no real difference between an existing and non existing file from this
interface's perspective.

Removing a folder automatically is dangerous because it may be on
an unmounted external hard drive or another location that is not
currently available.  This also removes some blocking i/o on the main
thread.

Instead replace with a subtitle message to notify the user that the
folder is inaccessible.
This commit is contained in:
Corey Berla 2024-02-05 15:12:06 -08:00 • committed by Matthijs Velsink
parent aae5cd27bd
commit 42920853c0
1 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
panels/search/cc-search-locations-dialog.c
View file

@ -387,19 +387,7 @@ get_tracker_locations (CcSearchLocationsDialog *self)
NULL,
PLACE_OTHER);
if (file != NULL && g_file_query_exists (file, NULL))
{
list = g_list_prepend (list, location);
}
else
{
g_autoptr(GPtrArray) new_values = NULL;
new_values = place_get_new_settings_values (self, location, TRUE);
g_settings_set_strv (self->tracker_preferences,
TRACKER_KEY_RECURSIVE_DIRECTORIES,
(const gchar **) new_values->pdata);
}
list = g_list_prepend (list, location);
}
return g_list_reverse (list);