applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

display: Consider monitors in landscape mode for minimum size

Browse source 
Some devices have panels with a native resolution in portrait mode. In
these cases the monitor will likely be used in landscape mode.

Accept the modes as if they are landscape rather than portrait. A
further improvement would be to restrict the orientation setting.

Fixes #639
This commit is contained in:
Benjamin Berg 2019-08-12 11:43:30 +02:00 • committed by Benjamin Berg
parent fe932a4cea
commit 4e800cc558
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
panels/display/cc-display-config-dbus.c
View file

@ -1211,13 +1211,18 @@ is_scaled_mode_allowed (CcDisplayConfigDBus *self,
CcDisplayMode *pmode, CcDisplayMode *pmode,
double scale) double scale)
{ {
gint width, height;
CcDisplayModeDBus *mode = CC_DISPLAY_MODE_DBUS (pmode); CcDisplayModeDBus *mode = CC_DISPLAY_MODE_DBUS (pmode);
if (!cc_display_mode_dbus_is_supported_scale (pmode, scale)) if (!cc_display_mode_dbus_is_supported_scale (pmode, scale))
return FALSE; return FALSE;
return (round (mode->width / scale) >= self->min_width && /* Do the math as if the monitor is always in landscape mode. */
round (mode->height / scale) >= self->min_height); width = round (mode->width / scale);
height = round (mode->height / scale);
return (MAX (width, height) >= self->min_width &&
MIN (width, height) >= self->min_height);
} }
static gboolean static gboolean

5
panels/display/cc-display-panel.c
View file

@ -40,7 +40,10 @@
#include "cc-display-resources.h" #include "cc-display-resources.h"
#include "cc-display-settings.h" #include "cc-display-settings.h"
/* The minimum supported size for the panel */ /* The minimum supported size for the panel
* Note that WIDTH is assumed to be the larger size and we accept portrait
* mode too effectively (in principle we should probably restrict the rotation
* setting in that case). */
#define MINIMUM_WIDTH 740 #define MINIMUM_WIDTH 740
#define MINIMUM_HEIGHT 530 #define MINIMUM_HEIGHT 530