applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

display: In clone mode, set geometry of all outputs when one changes

Browse source 
Otherwise we could fail to validate the new configuration depending on
which output we're initializing mirror mode from.

gnome_rr_config_applicable() creates a temporary array of outputs for
validation and, in clone mode, all of them are assigned the same
geometry but, since it lacks context about which output the user is
currently on, it just uses the first one's geometry for all of
them. If this first output isn't the one the user is changing in the
UI then we never called _set_geometry() on it with a clone mode
geometry and thus the validation would fail because the geometry used
is that output's current mode which might not match the clone mode's.

https://bugzilla.gnome.org/show_bug.cgi?id=743816
This commit is contained in:
Rui Matos 2015-02-19 18:06:27 +01:00
parent de821d5922
commit 511265e574
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
panels/display/cc-display-panel.c
View file

@ -1945,7 +1945,8 @@ res_combo_changed (GtkComboBox *combo,
GtkTreeModel *res_model;
GtkTreeIter iter;
GnomeRRMode *mode;
gint x, y, width, height;
gint x, y, width, height, i;
GnomeRROutputInfo **outputs;
res_model = gtk_combo_box_get_model (combo);
@ -1958,7 +1959,17 @@ res_combo_changed (GtkComboBox *combo,
width = gnome_rr_mode_get_width (mode);
height = gnome_rr_mode_get_height (mode);
gnome_rr_output_info_set_geometry (priv->current_output, x, y, width, height);
if (gnome_rr_config_get_clone (priv->current_configuration))
{
outputs = gnome_rr_config_get_outputs (priv->current_configuration);
for (i = 0; outputs[i]; i++)
gnome_rr_output_info_set_geometry (outputs[i], x, y, width, height);
}
else
{
gnome_rr_output_info_set_geometry (priv->current_output, x, y, width, height);
}
update_apply_button (panel);
}
}