applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make the custom keybinding UI smoother

Browse source 
These changes were proposed in bug 580792:
 - Make the apply button the default
 - Don't let the cancel button grab the default
 - Make both entries activate the default widget
 - Grab the focus to the first entry when presenting the dialog
This commit is contained in:
Matthias Clasen 2009-05-07 20:02:37 -04:00
parent 4864d99794
commit 59380c29e4
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
capplets/keybindings/gnome-keybinding-properties.c
View file

@ -1376,6 +1376,7 @@ edit_custom_shortcut (KeyEntry *key)
gtk_entry_set_text (GTK_ENTRY (custom_shortcut_name_entry), key->description ? key->description : ""); gtk_entry_set_text (GTK_ENTRY (custom_shortcut_name_entry), key->description ? key->description : "");
gtk_widget_set_sensitive (custom_shortcut_name_entry, key->desc_editable); gtk_widget_set_sensitive (custom_shortcut_name_entry, key->desc_editable);
gtk_widget_grab_focus (custom_shortcut_name_entry);
gtk_entry_set_text (GTK_ENTRY (custom_shortcut_command_entry), key->command ? key->command : ""); gtk_entry_set_text (GTK_ENTRY (custom_shortcut_command_entry), key->command ? key->command : "");
gtk_widget_set_sensitive (custom_shortcut_command_entry, key->cmd_editable); gtk_widget_set_sensitive (custom_shortcut_command_entry, key->cmd_editable);

6
capplets/keybindings/gnome-keybinding-properties.glade
View file

@ -238,7 +238,8 @@
<child> <child>
<widget class="GtkButton" id="cancelbutton1"> <widget class="GtkButton" id="cancelbutton1">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_default">True</property> <property name="can_default">False</property>
<property name="receives_default">False</property>
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="label">gtk-cancel</property> <property name="label">gtk-cancel</property>
<property name="use_stock">True</property> <property name="use_stock">True</property>
@ -252,6 +253,7 @@
<widget class="GtkButton" id="okbutton1"> <widget class="GtkButton" id="okbutton1">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_default">True</property> <property name="can_default">True</property>
<property name="receives_default">False</property>
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="label">gtk-apply</property> <property name="label">gtk-apply</property>
<property name="use_stock">True</property> <property name="use_stock">True</property>
@ -372,7 +374,7 @@
<property name="max_length">0</property> <property name="max_length">0</property>
<property name="has_frame">True</property> <property name="has_frame">True</property>
<property name="invisible_char">•</property> <property name="invisible_char">•</property>
<property name="activates_default">False</property> <property name="activates_default">True</property>
</widget> </widget>
<packing> <packing>
<property name="left_attach">1</property> <property name="left_attach">1</property>