From 6284162a1d8e315694c736431958adcd21da497b Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Wed, 29 Jan 2020 17:43:24 +0000 Subject: [PATCH] user-accounts: Fix use of an uninitialised variable in the carousel MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `dest_x` is not set if `gtk_widget_translate_coordinates()` fails, which it can do before the widget is realised. This fixes a valgrind warning, but doesn’t change any user-visible behaviour as far as I can tell. Signed-off-by: Philip Withnall --- panels/user-accounts/cc-carousel.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/panels/user-accounts/cc-carousel.c b/panels/user-accounts/cc-carousel.c index c1311f7dc..cf98b533f 100644 --- a/panels/user-accounts/cc-carousel.c +++ b/panels/user-accounts/cc-carousel.c @@ -93,12 +93,13 @@ cc_carousel_item_get_x (CcCarouselItem *item, widget = GTK_WIDGET (item); width = gtk_widget_get_allocated_width (widget); - gtk_widget_translate_coordinates (widget, - parent, - width / 2, - 0, - &dest_x, - NULL); + if (!gtk_widget_translate_coordinates (widget, + parent, + width / 2, + 0, + &dest_x, + NULL)) + return 0; return CLAMP (dest_x - ARROW_SIZE, 0,