applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

object-storage: Avoid double free when propagating error

Browse source 
In cc_object_storage_create_dbus_proxy_sync and
cc_object_storage_create_dbus_proxy_finish we need to use g_steal_pointer to
make sure local_error is not double freed.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/86
This commit is contained in:
Andrea Azzarone 2018-05-07 16:20:13 +02:00
parent eea231dc1c
commit 6ec0bcde15
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/cc-object-storage.c
View file

@ -256,7 +256,7 @@ cc_object_storage_create_dbus_proxy_sync (GBusType bus_type,
if (local_error)
{
g_propagate_error (error, local_error);
g_propagate_error (error, g_steal_pointer (&local_error));
return NULL;
}
@ -385,7 +385,7 @@ cc_object_storage_create_dbus_proxy_finish (GAsyncResult *result,
/* If the proxy is not cached, do the normal caching routine */
if (local_error)
{
g_propagate_error (error, local_error);
g_propagate_error (error, g_steal_pointer (&local_error));
return NULL;
}