applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

user-accounts: Allow new password insert iff the old one is right

Browse source 
Since the error message label provided at the bottom only says that
the newly provided password is weak, it can be consfusing for the
users as they might not understand why they can't press 'Accept'
button.  This could be especially true for color blind people.

Fix it by allowing modification of new password entry only if the old
provided password is correctly entered.
This commit is contained in:
Mohammed Sadiq 2023-09-06 12:48:42 +05:30 • committed by Felipe Borges
parent 70a00ec56c
commit 6f9e1bfec0
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
panels/user-accounts/cc-password-dialog.c
View file

@ -208,6 +208,8 @@ update_sensitivity (CcPasswordDialog *self)
can_change = TRUE; can_change = TRUE;
} }
gtk_widget_set_sensitive (GTK_WIDGET (self->password_entry), self->old_password_ok);
gtk_widget_set_sensitive (GTK_WIDGET (self->verify_entry), self->old_password_ok);
gtk_widget_set_sensitive (GTK_WIDGET (self->ok_button), can_change); gtk_widget_set_sensitive (GTK_WIDGET (self->ok_button), can_change);
} }
@ -218,8 +220,8 @@ mode_change (CcPasswordDialog *self,
gboolean active; gboolean active;
active = (mode == ACT_USER_PASSWORD_MODE_REGULAR); active = (mode == ACT_USER_PASSWORD_MODE_REGULAR);
gtk_widget_set_sensitive (GTK_WIDGET (self->password_entry), active); gtk_widget_set_sensitive (GTK_WIDGET (self->password_entry), self->old_password_ok);
gtk_widget_set_sensitive (GTK_WIDGET (self->verify_entry), active); gtk_widget_set_sensitive (GTK_WIDGET (self->verify_entry), self->old_password_ok);
gtk_widget_set_sensitive (GTK_WIDGET (self->old_password_entry), active); gtk_widget_set_sensitive (GTK_WIDGET (self->old_password_entry), active);
gtk_check_button_set_active (GTK_CHECK_BUTTON (self->action_now_radio), active); gtk_check_button_set_active (GTK_CHECK_BUTTON (self->action_now_radio), active);
gtk_check_button_set_active (GTK_CHECK_BUTTON (self->action_login_radio), !active); gtk_check_button_set_active (GTK_CHECK_BUTTON (self->action_login_radio), !active);
@ -395,6 +397,8 @@ old_password_entry_changed (CcPasswordDialog *self)
gtk_widget_set_sensitive (GTK_WIDGET (self->ok_button), FALSE); gtk_widget_set_sensitive (GTK_WIDGET (self->ok_button), FALSE);
self->old_password_ok = FALSE; self->old_password_ok = FALSE;
gtk_widget_set_sensitive (GTK_WIDGET (self->password_entry), self->old_password_ok);
gtk_widget_set_sensitive (GTK_WIDGET (self->verify_entry), self->old_password_ok);
self->old_password_entry_timeout_id = g_timeout_add (PASSWORD_CHECK_TIMEOUT, self->old_password_entry_timeout_id = g_timeout_add (PASSWORD_CHECK_TIMEOUT,
(GSourceFunc) old_password_entry_timeout, (GSourceFunc) old_password_entry_timeout,
self); self);