applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

universal-access: Remove the mnemonic-activate handler

Browse source 
It's wrong because the label's parent isn't a GtkListBoxRow which
causes a warning.

In any case, we don't need it since GtkLabel already does the work of
finding a suitable parent widget to activate on mnemonic-activate
which ends up causing GtkListBox to fire its row-activated signal that
we already handle.

https://bugzilla.gnome.org/show_bug.cgi?id=708283
This commit is contained in:
Rui Matos 2013-09-16 20:17:55 +02:00 • committed by Bastien Nocera
parent 209a528561
commit 7a271439c9
1 changed files with 0 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

24
panels/universal-access/cc-ua-panel.c
View file

@ -404,15 +404,6 @@ activate_row (CcUaPanel *self, GtkListBoxRow *row)
gtk_window_present (GTK_WINDOW (dialog)); gtk_window_present (GTK_WINDOW (dialog));
} }
static void
mnemonic_activate (GtkLabel *label, gboolean cycling, CcUaPanel *self)
{
GtkWidget *row;
row = gtk_widget_get_parent (GTK_WIDGET (label));
activate_row (self, GTK_LIST_BOX_ROW (row));
}
static void static void
cc_ua_panel_init_seeing (CcUaPanel *self) cc_ua_panel_init_seeing (CcUaPanel *self)
{ {
@ -446,9 +437,6 @@ cc_ua_panel_init_seeing (CcUaPanel *self)
priv->interface_settings, priv->interface_settings,
NULL); NULL);
g_signal_connect (WID ("heading_large_text"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
/* zoom */ /* zoom */
g_settings_bind_with_mapping (priv->application_settings, "screen-magnifier-enabled", g_settings_bind_with_mapping (priv->application_settings, "screen-magnifier-enabled",
@ -458,8 +446,6 @@ cc_ua_panel_init_seeing (CcUaPanel *self)
NULL, NULL, NULL); NULL, NULL, NULL);
g_object_set_data (G_OBJECT (WID ("row_zoom")), "dialog-id", "zoom"); g_object_set_data (G_OBJECT (WID ("row_zoom")), "dialog-id", "zoom");
g_signal_connect (WID ("heading_zoom"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
/* screen reader */ /* screen reader */
@ -480,8 +466,6 @@ cc_ua_panel_init_seeing (CcUaPanel *self)
G_CALLBACK (gtk_widget_hide), dialog); G_CALLBACK (gtk_widget_hide), dialog);
g_signal_connect (dialog, "delete-event", g_signal_connect (dialog, "delete-event",
G_CALLBACK (gtk_widget_hide_on_delete), NULL); G_CALLBACK (gtk_widget_hide_on_delete), NULL);
g_signal_connect (WID ("heading_screen_reader"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
/* sound keys */ /* sound keys */
@ -502,8 +486,6 @@ cc_ua_panel_init_seeing (CcUaPanel *self)
G_CALLBACK (gtk_widget_hide), dialog); G_CALLBACK (gtk_widget_hide), dialog);
g_signal_connect (dialog, "delete-event", g_signal_connect (dialog, "delete-event",
G_CALLBACK (gtk_widget_hide_on_delete), NULL); G_CALLBACK (gtk_widget_hide_on_delete), NULL);
g_signal_connect (WID ("heading_sound_keys"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
} }
/* hearing/sound section */ /* hearing/sound section */
@ -593,8 +575,6 @@ cc_ua_panel_init_hearing (CcUaPanel *self)
g_signal_connect (WID ("visual_alerts_test_button"), g_signal_connect (WID ("visual_alerts_test_button"),
"clicked", G_CALLBACK (gdk_beep), NULL); "clicked", G_CALLBACK (gdk_beep), NULL);
g_signal_connect (WID ("heading_visual_alerts"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
} }
/* typing/keyboard section */ /* typing/keyboard section */
@ -720,8 +700,6 @@ cc_ua_panel_init_keyboard (CcUaPanel *self)
G_CALLBACK (gtk_widget_hide), dialog); G_CALLBACK (gtk_widget_hide), dialog);
g_signal_connect (dialog, "delete-event", g_signal_connect (dialog, "delete-event",
G_CALLBACK (gtk_widget_hide_on_delete), NULL); G_CALLBACK (gtk_widget_hide_on_delete), NULL);
g_signal_connect (WID ("heading_accessx"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
} }
/* mouse/pointing & clicking section */ /* mouse/pointing & clicking section */
@ -803,8 +781,6 @@ cc_ua_panel_init_mouse (CcUaPanel *self)
G_CALLBACK (gtk_widget_hide), dialog); G_CALLBACK (gtk_widget_hide), dialog);
g_signal_connect (dialog, "delete-event", g_signal_connect (dialog, "delete-event",
G_CALLBACK (gtk_widget_hide_on_delete), NULL); G_CALLBACK (gtk_widget_hide_on_delete), NULL);
g_signal_connect (WID ("heading_click_assist"), "mnemonic-activate",
G_CALLBACK (mnemonic_activate), self);
} }
static void static void