applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

printers: Don't use gtk_widget_show_all

Browse source 
It is removed in GTK+ 4
This commit is contained in:
Robert Ancell 2018-11-23 13:37:01 +13:00 • committed by Robert Ancell
parent fcde07c770
commit 7f67f6b24f
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
panels/printers/pp-details-dialog.ui
View file

@ -27,14 +27,17 @@
</child>
<child internal-child="vbox">
<object class="GtkBox">
<property name="visible">True</property>
<property name="margin">20</property>
<property name="halign">center</property>
<child>
<object class="GtkGrid">
<property name="visible">True</property>
<property name="row-spacing">10</property>
<property name="column-spacing">10</property>
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="label" translatable="yes">Name</property>
<property name="halign">end</property>
<property name="mnemonic_widget">printer_name_entry</property>
@ -49,6 +52,7 @@
</child>
<child>
<object class="GtkEntry" id="printer_name_entry">
<property name="visible">True</property>
<property name="halign">fill</property>
<property name="width_request">320</property>
<signal name="changed" handler="printer_name_changed"/>
@ -61,6 +65,7 @@
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="label" translatable="yes">Location</property>
<property name="halign">end</property>
<property name="mnemonic_widget">printer_location_entry</property>
@ -75,6 +80,7 @@
</child>
<child>
<object class="GtkEntry" id="printer_location_entry">
<property name="visible">True</property>
<property name="width_request">320</property>
<property name="halign">fill</property>
</object>
@ -86,6 +92,7 @@
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="label" translatable="yes">Address</property>
<property name="halign">end</property>
<property name="mnemonic_widget">printer_address_label</property>
@ -100,6 +107,7 @@
</child>
<child>
<object class="GtkLabel" id="printer_address_label">
<property name="visible">True</property>
<property name="label">192.168.0.1</property>
<property name="halign">start</property>
</object>
@ -111,6 +119,7 @@
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="label" translatable="yes">Driver</property>
<property name="halign">end</property>
<property name="mnemonic_widget">printer_model_label</property>
@ -125,9 +134,11 @@
</child>
<child>
<object class="GtkStack" id="printer_model_stack">
<property name="visible">True</property>
<property name="halign">start</property>
<child>
<object class="GtkLabel" id="printer_model_label">
<property name="visible">True</property>
<property name="halign">start</property>
<property name="label">HP Inkjet Delux 9000</property>
<property name="selectable">True</property>
@ -138,16 +149,19 @@
</child>
<child>
<object class="GtkBox">
<property name="visible">True</property>
<property name="halign">start</property>
<property name="spacing">5</property>
<child>
<object class="GtkSpinner">
<property name="visible">True</property>
<property name="active">True</property>
<property name="halign">start</property>
</object>
</child>
<child>
<object class="GtkLabel">
<property name="visible">True</property>
<property name="halign">start</property>
<property name="label" translatable="yes">Searching for preferred drivers…</property>
</object>
@ -166,11 +180,13 @@
<child>
<object class="GtkButtonBox" id="driver_buttons">
<property name="visible">True</property>
<property name="orientation">vertical</property>
<property name="spacing">10</property>
<property name="halign">start</property>
<child>
<object class="GtkButton" id="search_for_drivers_button">
<property name="visible">True</property>
<property name="label" translatable="yes">Search for Drivers</property>
<property name="halign">fill</property>
<signal name="clicked" handler="search_for_drivers"/>
@ -179,6 +195,7 @@
<child>
<object class="GtkButton" id="select_from_database_button">
<property name="visible">True</property>
<property name="label" translatable="yes">Select from Database…</property>
<property name="halign">fill</property>
<signal name="clicked" handler="select_ppd_in_dialog"/>
@ -187,6 +204,7 @@
<child>
<object class="GtkButton" id="install_ppd_button">
<property name="visible">True</property>
<property name="label" translatable="yes">Install PPD File…</property>
<property name="halign">fill</property>
<signal name="clicked" handler="select_ppd_manually"/>

2
panels/printers/pp-printer-entry.c
View file

@ -439,7 +439,7 @@ on_show_printer_details_dialog (GtkButton *button,
g_signal_connect (self->pp_details_dialog, "response", G_CALLBACK (details_dialog_cb), self);
g_signal_connect (self->pp_details_dialog, "printer-renamed", G_CALLBACK (printer_renamed_cb), self);
gtk_widget_show_all (GTK_WIDGET (self->pp_details_dialog));
gtk_widget_show (GTK_WIDGET (self->pp_details_dialog));
}
static void