applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network: Avoid run-time warnings

Browse source 
As the GPtrArray for the ignored_hosts is never actually created,
and a use-after-free as we didn't dup the strings into the array,
and freed the array.
This commit is contained in:
Bastien Nocera 2010-11-18 03:02:49 +00:00
parent 3b8ae693d5
commit 9b1176aefc
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
panels/network/gnome-network-properties.c
View file

@ -1120,7 +1120,9 @@ proxy_settings_changed_cb (GSettings *settings,
gchar **hosts;
guint i = 0;
g_ptr_array_free (ignore_hosts, TRUE);
if (ignore_hosts != NULL)
g_ptr_array_free (ignore_hosts, TRUE);
ignore_hosts = g_ptr_array_new_with_free_func ((GDestroyNotify) g_free);
hosts = g_settings_get_strv (proxy_settings, "ignore-hosts");
while (hosts[i] != NULL) {
@ -1129,7 +1131,9 @@ proxy_settings_changed_cb (GSettings *settings,
}
populate_listmodel (GTK_LIST_STORE (model), ignore_hosts);
g_strfreev (hosts);
/* Note: not g_strfreev() so we don't have to dup the strings
* we put in the array in the loop above */
g_free (hosts);
}
}