applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

user-accounts: Remove unused password hints

Browse source 
Short password hints are not used for some time. Let's remove them.

https://bugzilla.gnome.org/show_bug.cgi?id=780002
This commit is contained in:
Ondrej Holy 2017-04-05 13:24:47 +02:00 • committed by Felipe Borges
parent 466264e78d
commit 9e4123363e
4 changed files with 5 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
panels/user-accounts/pw-utils.c
View file

@ -125,7 +125,6 @@ pw_strength (const gchar *password,
const gchar *old_password,
const gchar *username,
const gchar **hint,
const gchar **long_hint,
gint *strength_level)
{
gint rv, level = 0;
@ -138,42 +137,21 @@ pw_strength (const gchar *password,
strength = CLAMP (0.01 * rv, 0.0, 1.0);
if (rv < 0) {
*hint = C_("Password strength", "Strength: Weak");
}
else if (strength < 0.50) {
level = 1;
*hint = C_("Password strength", "Strength: Low");
} else if (strength < 0.75) {
level = 2;
*hint = C_("Password strength", "Strength: Medium");
} else if (strength < 0.90) {
level = 3;
*hint = C_("Password strength", "Strength: Good");
} else {
level = 4;
*hint = C_("Password strength", "Strength: High");
}
*long_hint = pw_error_hint (rv);
*hint = pw_error_hint (rv);
if (strength_level)
*strength_level = level;
return strength;
}
int
pw_strength_hint_get_width_chars (void)
{
gint len;
len = 0;
len = MAX (len, strlen (C_("Password strength", "Strength: Weak")));
len = MAX (len, strlen (C_("Password strength", "Strength: Low")));
len = MAX (len, strlen (C_("Password strength", "Strength: Medium")));
len = MAX (len, strlen (C_("Password strength", "Strength: Good")));
len = MAX (len, strlen (C_("Password strength", "Strength: High")));
len += 2;
return len;
}

2
panels/user-accounts/pw-utils.h
View file

@ -26,6 +26,4 @@ gdouble pw_strength (const gchar *password,
const gchar *old_password,
const gchar *username,
const gchar **hint,
const gchar **long_hints,
gint *strength_level);
int pw_strength_hint_get_width_chars (void);

5
panels/user-accounts/um-account-dialog.c
View file

@ -272,15 +272,14 @@ update_password_strength (UmAccountDialog *self)
const gchar *password;
const gchar *username;
const gchar *hint;
const gchar *long_hint;
gint strength_level;
password = gtk_entry_get_text (GTK_ENTRY (self->local_password));
username = gtk_combo_box_text_get_active_text (GTK_COMBO_BOX_TEXT (self->local_username));
pw_strength (password, NULL, username, &hint, &long_hint, &strength_level);
pw_strength (password, NULL, username, &hint, &strength_level);
gtk_label_set_label (GTK_LABEL (self->local_hint), long_hint);
gtk_label_set_label (GTK_LABEL (self->local_hint), hint);
gtk_level_bar_set_value (GTK_LEVEL_BAR (self->local_strength_indicator), strength_level);
if (strength_level > 0) {

5
panels/user-accounts/um-password-dialog.c
View file

@ -69,7 +69,6 @@ update_password_strength (UmPasswordDialog *um)
const gchar *username;
gint strength_level;
const gchar *hint;
const gchar *long_hint;
if (um->user == NULL) {
return 0;
@ -80,10 +79,10 @@ update_password_strength (UmPasswordDialog *um)
username = act_user_get_user_name (um->user);
pw_strength (password, old_password, username,
&hint, &long_hint, &strength_level);
&hint, &strength_level);
gtk_level_bar_set_value (GTK_LEVEL_BAR (um->strength_indicator), strength_level);
gtk_label_set_label (GTK_LABEL (um->password_hint), long_hint);
gtk_label_set_label (GTK_LABEL (um->password_hint), hint);
if (strength_level > 0) {
set_entry_validation_checkmark (GTK_ENTRY (um->password_entry));