From a205fc79b4f7d2b00d3fea940d345a0d2244026c Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Tue, 21 Sep 2010 15:22:43 +0100 Subject: [PATCH] default-apps: Fix illegal memory access gnome_da_xml_free() frees priv->capplet, so we shouldn't be accessing it afterwards. --- panels/default-applications/cc-default-applications-panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/panels/default-applications/cc-default-applications-panel.c b/panels/default-applications/cc-default-applications-panel.c index a86ffca0a..f840152fb 100644 --- a/panels/default-applications/cc-default-applications-panel.c +++ b/panels/default-applications/cc-default-applications-panel.c @@ -71,7 +71,6 @@ cc_default_applications_panel_dispose (GObject *object) if (priv->capplet) { g_object_unref (priv->capplet->gconf); - gnome_da_xml_free (priv->capplet); if (priv->capplet->theme_changed_id > 0) { @@ -80,6 +79,8 @@ cc_default_applications_panel_dispose (GObject *object) priv->capplet->theme_changed_id = 0; } + gnome_da_xml_free (priv->capplet); + priv->capplet = NULL; }