applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Network: prevent a possible crash

Browse source 
Some of the settings may be NULL when we call is_hotspot_connection()
on random connections. No need to crash then...
This commit is contained in:
Matthias Clasen 2011-05-26 17:15:53 -04:00
parent f658ff61aa
commit b8529164d6
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
panels/network/cc-network-panel.c
View file

@ -2656,18 +2656,18 @@ is_hotspot_connection (NMConnection *connection)
NMSettingIP4Config *sip; NMSettingIP4Config *sip;
sc = nm_connection_get_setting_connection (connection); sc = nm_connection_get_setting_connection (connection);
if (strcmp (nm_setting_connection_get_connection_type (sc), "802-11-wireless") != 0) { if (g_strcmp0 (nm_setting_connection_get_connection_type (sc), "802-11-wireless") != 0) {
return FALSE; return FALSE;
} }
sw = nm_connection_get_setting_wireless (connection); sw = nm_connection_get_setting_wireless (connection);
if (strcmp (nm_setting_wireless_get_mode (sw), "adhoc") != 0) { if (g_strcmp0 (nm_setting_wireless_get_mode (sw), "adhoc") != 0) {
return FALSE; return FALSE;
} }
if (strcmp (nm_setting_wireless_get_security (sw), "802-11-wireless-security") != 0) { if (g_strcmp0 (nm_setting_wireless_get_security (sw), "802-11-wireless-security") != 0) {
return FALSE; return FALSE;
} }
sip = nm_connection_get_setting_ip4_config (connection); sip = nm_connection_get_setting_ip4_config (connection);
if (strcmp (nm_setting_ip4_config_get_method (sip), "shared") != 0) { if (g_strcmp0 (nm_setting_ip4_config_get_method (sip), "shared") != 0) {
return FALSE; return FALSE;
} }