applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network: fix critical when opening VPN details page

Browse source 
I was seeing this critical when opening the VPN details page:

(gnome-control-center:78888): nm-CRITICAL **: 16:26:21.689: ((src/libnm-client-impl/nm-device.c:1299)): assertion '<dropped>' failed

It probably broke in 551d72280b. The code
above and below expects self->device may be NULL, so let's add a
NULL check here.
This commit is contained in:
Michael Catanzaro 2021-11-05 16:25:58 -05:00 • committed by Georges Basile Stavracas Neto
parent 234d1aadb7
commit c180aa660c
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
panels/network/connection-editor/ce-page-details.c
View file

@ -297,7 +297,9 @@ connect_details_page (CEPageDetails *self)
gtk_widget_set_visible (GTK_WIDGET (self->speed_heading_label), speed_label != NULL);
gtk_widget_set_visible (GTK_WIDGET (self->speed_label), speed_label != NULL);
hw_address = nm_device_get_hw_address (self->device);
if (self->device)
hw_address = nm_device_get_hw_address (self->device);
gtk_label_set_label (self->mac_label, hw_address);
gtk_widget_set_visible (GTK_WIDGET (self->mac_heading_label), hw_address != NULL);
gtk_widget_set_visible (GTK_WIDGET (self->mac_label), hw_address != NULL);