From c57cadf50b0d78d8363f7b9d14eb8cd4e6136578 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Tue, 31 Jan 2017 10:07:52 -0200 Subject: [PATCH] keyboard: make the "Set" and "Add" buttons blue Per the available mockups [1], the "Set" and "Add" buttons are the suggested action of the dialog and should be blue. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=777842 --- panels/keyboard/cc-keyboard-shortcut-editor.c | 19 +++++++++++++++++++ panels/keyboard/shortcut-editor.ui | 14 ++++++++------ 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/panels/keyboard/cc-keyboard-shortcut-editor.c b/panels/keyboard/cc-keyboard-shortcut-editor.c index 861e71025..e568cc40d 100644 --- a/panels/keyboard/cc-keyboard-shortcut-editor.c +++ b/panels/keyboard/cc-keyboard-shortcut-editor.c @@ -319,6 +319,25 @@ set_header_mode (CcKeyboardShortcutEditor *self, mode != HEADER_MODE_CUSTOM_EDIT); gtk_widget_set_visible (self->replace_button, mode == HEADER_MODE_REPLACE); gtk_widget_set_visible (self->set_button, mode == HEADER_MODE_SET); + + /* By setting the default response, the action button gets the 'suggested-action' applied */ + switch (mode) + { + case HEADER_MODE_SET: + gtk_dialog_set_default_response (GTK_DIALOG (self), GTK_RESPONSE_APPLY); + break; + + case HEADER_MODE_REPLACE: + gtk_dialog_set_default_response (GTK_DIALOG (self), GTK_RESPONSE_ACCEPT); + break; + + case HEADER_MODE_ADD: + gtk_dialog_set_default_response (GTK_DIALOG (self), GTK_RESPONSE_OK); + break; + + default: + gtk_dialog_set_default_response (GTK_DIALOG (self), GTK_RESPONSE_NONE); + } } static void diff --git a/panels/keyboard/shortcut-editor.ui b/panels/keyboard/shortcut-editor.ui index bebec36ce..ac0f01beb 100644 --- a/panels/keyboard/shortcut-editor.ui +++ b/panels/keyboard/shortcut-editor.ui @@ -369,11 +369,9 @@ True False True + True True - end @@ -398,11 +396,9 @@ Set True True + True True - end @@ -411,6 +407,12 @@ + + cancel_button + replace_button + set_button + add_button +