From c57faf5da5222cef41ff0bc3480774b4bf18621a Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Wed, 27 Mar 2013 11:24:00 +0100 Subject: [PATCH] network: Fix possible crash in connection editor Disable the type-ahead search in the connection editor, the number of items, and their positional stability means that a search feature isn't warranted. As a precaution, also check the success of gtk_tree_selection_get_selected() to avoid crashes. https://bugzilla.gnome.org/show_bug.cgi?id=693685 --- panels/network/connection-editor/connection-editor.ui | 2 +- panels/network/connection-editor/net-connection-editor.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/panels/network/connection-editor/connection-editor.ui b/panels/network/connection-editor/connection-editor.ui index 78c4ba9ae..0d48cec15 100644 --- a/panels/network/connection-editor/connection-editor.ui +++ b/panels/network/connection-editor/connection-editor.ui @@ -77,7 +77,7 @@ details_store False False - 0 + False diff --git a/panels/network/connection-editor/net-connection-editor.c b/panels/network/connection-editor/net-connection-editor.c index 07705c9be..e145fe036 100644 --- a/panels/network/connection-editor/net-connection-editor.c +++ b/panels/network/connection-editor/net-connection-editor.c @@ -59,7 +59,8 @@ selection_changed (GtkTreeSelection *selection, NetConnectionEditor *editor) GtkTreeIter iter; gint page; - gtk_tree_selection_get_selected (selection, &model, &iter); + if (!gtk_tree_selection_get_selected (selection, &model, &iter)) + return; gtk_tree_model_get (model, &iter, 1, &page, -1); widget = GTK_WIDGET (gtk_builder_get_object (editor->builder,