applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

user-accounts: Improve password hints

Browse source 
Don't say "Good password!" for all acceptable password (e.g. weak passwords).
Say explicitely that password needs to be longer for short passwords.

https://bugzilla.gnome.org/show_bug.cgi?id=780002
This commit is contained in:
Ondrej Holy 2017-04-05 13:30:51 +02:00 • committed by Felipe Borges
parent e89d4f59c2
commit cd1f96f8ba
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
panels/user-accounts/pw-utils.c
View file

@ -112,11 +112,11 @@ pw_error_hint (gint error)
case PWQ_ERROR_MAX_SEQUENCE: case PWQ_ERROR_MAX_SEQUENCE:
return C_("Password hint", "Try to avoid sequences like 1234 or abcd."); return C_("Password hint", "Try to avoid sequences like 1234 or abcd.");
case PWQ_ERROR_MIN_LENGTH: case PWQ_ERROR_MIN_LENGTH:
return C_("Password hint", "Try to add more letters, numbers and symbols."); return C_("Password hint", "Password needs to be longer. Try to add more letters, numbers and punctuation.");
case PWQ_ERROR_EMPTY_PASSWORD: case PWQ_ERROR_EMPTY_PASSWORD:
return C_("Password hint", "Mix uppercase and lowercase and try to use a number or two."); return C_("Password hint", "Mix uppercase and lowercase and try to use a number or two.");
default: default:
return C_("Password hint", "Good password! Adding more letters, numbers and punctuation will make it stronger."); return C_("Password hint", "Adding more letters, numbers and punctuation will make the password stronger.");
} }
} }
@ -152,7 +152,10 @@ pw_strength (const gchar *password,
level = 5; level = 5;
} }
*hint = pw_error_hint (rv); if (length && length < pw_min_length())
*hint = pw_error_hint (PWQ_ERROR_MIN_LENGTH);
else
*hint = pw_error_hint (rv);
if (strength_level) if (strength_level)
*strength_level = level; *strength_level = level;