From cea45f707c0eedba3affe96ed31ff18a9b9294b0 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Mon, 11 Feb 2013 18:22:11 -0500
Subject: [PATCH] network: Improve accessibility

Add accessible names for a number of switches and buttons which
don't have meaningful representation in orca, otherwise.

https://bugzilla.gnome.org/show_bug.cgi?id=693552
---
 panels/network/net-device-ethernet.c |  1 +
 panels/network/net-device-wifi.c     |  1 +
 panels/network/network-ethernet.ui   |  5 +++++
 panels/network/network-proxy.ui      | 20 ++++++++++++++++++++
 panels/network/network-simple.ui     |  5 +++++
 panels/network/network-vpn.ui        | 10 ++++++++++
 panels/network/network-wifi.ui       |  5 +++++
 7 files changed, 47 insertions(+)

diff --git a/panels/network/net-device-ethernet.c b/panels/network/net-device-ethernet.c
index 186b05711..cb3be6d98 100644
--- a/panels/network/net-device-ethernet.c
+++ b/panels/network/net-device-ethernet.c
@@ -334,6 +334,7 @@ add_row (NetDeviceEthernet *device, NMConnection *connection)
         gtk_container_add (GTK_CONTAINER (widget), image);
         gtk_widget_set_halign (widget, GTK_ALIGN_CENTER);
         gtk_widget_set_valign (widget, GTK_ALIGN_CENTER);
+        atk_object_set_name (gtk_widget_get_accessible (widget), _("Options…"));
         gtk_box_pack_start (GTK_BOX (box), widget, FALSE, TRUE, 0);
         g_object_set_data (G_OBJECT (row), "edit", widget);
         g_object_set_data (G_OBJECT (widget), "row", row);
diff --git a/panels/network/net-device-wifi.c b/panels/network/net-device-wifi.c
index 13093ba0a..808001c17 100644
--- a/panels/network/net-device-wifi.c
+++ b/panels/network/net-device-wifi.c
@@ -1536,6 +1536,7 @@ make_row (GtkSizeGroup   *rows,
                 gtk_container_add (GTK_CONTAINER (widget), image);
                 gtk_widget_set_halign (widget, GTK_ALIGN_CENTER);
                 gtk_widget_set_valign (widget, GTK_ALIGN_CENTER);
+                atk_object_set_name (gtk_widget_get_accessible (widget), _("Options…"));
                 gtk_box_pack_start (GTK_BOX (row), widget, FALSE, FALSE, 0);
                 gtk_size_group_add_widget (spinner_button_group, widget);
                 g_object_set_data (G_OBJECT (row), "edit", widget);
diff --git a/panels/network/network-ethernet.ui b/panels/network/network-ethernet.ui
index bd063ffaf..6e7cb565a 100644
--- a/panels/network/network-ethernet.ui
+++ b/panels/network/network-ethernet.ui
@@ -195,6 +195,11 @@
                 <property name="receives_default">True</property>
                 <property name="halign">end</property>
                 <property name="image">image1</property>
+                <child internal-child="accessible">
+                  <object class="AtkObject" id="details_button-accessible">
+                    <property name="accessible-name" translatable="yes">Options…</property>
+                  </object>
+                </child>
                 <style>
                   <class name="image-button"/>
                 </style>
diff --git a/panels/network/network-proxy.ui b/panels/network/network-proxy.ui
index bc1a821fd..faa56308b 100644
--- a/panels/network/network-proxy.ui
+++ b/panels/network/network-proxy.ui
@@ -266,6 +266,11 @@
             <property name="xalign">1</property>
             <property name="invisible_char_set">True</property>
             <property name="adjustment">adjustment_proxy_port_http</property>
+            <child internal-child="accessible">
+              <object class="AtkObject" id="spinbutton_proxy_http-accessible">
+                <property name="accessible-name" translatable="yes">HTTP proxy port</property>
+              </object>
+            </child>
           </object>
           <packing>
             <property name="left_attach">2</property>
@@ -338,6 +343,11 @@
             <property name="xalign">1</property>
             <property name="invisible_char_set">True</property>
             <property name="adjustment">adjustment_proxy_port_https</property>
+            <child internal-child="accessible">
+              <object class="AtkObject" id="spinbutton_proxy_https-accessible">
+                <property name="accessible-name" translatable="yes">HTTPS proxy port</property>
+              </object>
+            </child>
           </object>
           <packing>
             <property name="left_attach">2</property>
@@ -354,6 +364,11 @@
             <property name="xalign">1</property>
             <property name="invisible_char_set">True</property>
             <property name="adjustment">adjustment_proxy_port_ftp</property>
+            <child internal-child="accessible">
+              <object class="AtkObject" id="spinbutton_proxy_ftp-accessible">
+                <property name="accessible-name" translatable="yes">FTP proxy port</property>
+              </object>
+            </child>
           </object>
           <packing>
             <property name="left_attach">2</property>
@@ -370,6 +385,11 @@
             <property name="xalign">1</property>
             <property name="invisible_char_set">True</property>
             <property name="adjustment">adjustment_proxy_port_socks</property>
+            <child internal-child="accessible">
+              <object class="AtkObject" id="spinbutton_proxy_socks-accessible">
+                <property name="accessible-name" translatable="yes">Socks proxy port</property>
+              </object>
+            </child>
           </object>
           <packing>
             <property name="left_attach">2</property>
diff --git a/panels/network/network-simple.ui b/panels/network/network-simple.ui
index 379fd3bf5..92e5e3b82 100644
--- a/panels/network/network-simple.ui
+++ b/panels/network/network-simple.ui
@@ -272,6 +272,11 @@
                 <property name="can_focus">True</property>
                 <property name="halign">end</property>
                 <property name="valign">center</property>
+                <child internal-child="accessible">
+                  <object class="AtkObject" id="device_off_switch-accessible">
+                    <property name="accessible-name" translatable="yes">Turn device off</property>
+                  </object>
+                </child>
               </object>
               <packing>
                 <property name="left_attach">2</property>
diff --git a/panels/network/network-vpn.ui b/panels/network/network-vpn.ui
index 8a4e9b6a9..31e73ebca 100644
--- a/panels/network/network-vpn.ui
+++ b/panels/network/network-vpn.ui
@@ -285,6 +285,11 @@
                     <property name="can_focus">True</property>
                     <property name="halign">end</property>
                     <property name="valign">center</property>
+                    <child internal-child="accessible">
+                      <object class="AtkObject" id="device_off_switch-accessible">
+                        <property name="accessible-name" translatable="yes">Turn VPN connection off</property>
+                      </object>
+                    </child>
                   </object>
                   <packing>
                     <property name="expand">False</property>
@@ -333,6 +338,11 @@
                     <property name="icon_size">1</property>
                   </object>
                 </child>
+                <child internal-child="accessible">
+                  <object class="AtkObject" id="button_options-accessible">
+                    <property name="accessible-name" translatable="yes">Options…</property>
+                  </object>
+                </child>
               </object>
               <packing>
                 <property name="expand">False</property>
diff --git a/panels/network/network-wifi.ui b/panels/network/network-wifi.ui
index fa3a0559f..df109e540 100644
--- a/panels/network/network-wifi.ui
+++ b/panels/network/network-wifi.ui
@@ -1684,6 +1684,11 @@ here</property>
                         <property name="halign">end</property>
                         <property name="valign">center</property>
                         <property name="hexpand">True</property>
+                        <child internal-child="accessible">
+                          <object class="AtkObject" id="device_off_switch-accessible">
+                            <property name="accessible-name" translatable="yes">Turn Wi-Fi off</property>
+                          </object>
+                        </child>
                       </object>
                       <packing>
                         <property name="expand">True</property>