applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network: Consider empty IPv6 gateway to be valid

Browse source 
The string we get back from the text entries are never NULL (as long as
the UI isn't broken that is), but can be empty strings. Consider an
empty IPv6 address to be invalid, but an empty gateway to be valid.

See https://bugzilla.redhat.com/show_bug.cgi?id=1467308
This commit is contained in:
Bastien Nocera 2018-02-06 10:30:57 +01:00
parent 747accf532
commit dd8b63bdeb
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
panels/network/connection-editor/ce-page-ip6.c
View file

@ -616,7 +616,7 @@ ui_to_setting (CEPageIP6 *page)
continue;
}
if (!text_address || !nm_utils_ipaddr_valid (AF_INET6, text_address)) {
if (!*text_address || !nm_utils_ipaddr_valid (AF_INET6, text_address)) {
widget_set_error (GTK_WIDGET (entry));
ret = FALSE;
} else {
@ -631,12 +631,13 @@ ui_to_setting (CEPageIP6 *page)
widget_unset_error (g_object_get_data (G_OBJECT (row), "prefix"));
}
if (text_gateway && !nm_utils_ipaddr_valid (AF_INET6, text_gateway)) {
if (*text_gateway && !nm_utils_ipaddr_valid (AF_INET6, text_gateway)) {
widget_set_error (g_object_get_data (G_OBJECT (row), "gateway"));
ret = FALSE;
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "gateway"));
have_gateway = TRUE;
if (*text_gateway)
have_gateway = TRUE;
}
if (!ret)