From e267515ed61690faf0532f3108d61c9b56c724c8 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Sat, 7 Sep 2013 14:38:41 -0300 Subject: [PATCH] network: Disconnect from signal on finalize The connection editor connects to permission-changed on its NMClient, but didn't disconnect from that signal when dropping the NMClient reference in finalize. https://bugzilla.gnome.org/show_bug.cgi?id=700989 --- panels/network/connection-editor/net-connection-editor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/panels/network/connection-editor/net-connection-editor.c b/panels/network/connection-editor/net-connection-editor.c index a645c5761..98d7e44e2 100644 --- a/panels/network/connection-editor/net-connection-editor.c +++ b/panels/network/connection-editor/net-connection-editor.c @@ -182,6 +182,8 @@ net_connection_editor_finalize (GObject *object) { NetConnectionEditor *editor = NET_CONNECTION_EDITOR (object); + if (editor->permission_id > 0 && editor->client) + g_signal_handler_disconnect (editor->client, editor->permission_id); g_clear_object (&editor->connection); g_clear_object (&editor->orig_connection); if (editor->window) {