From e39e21eac3023443ffd7e432c6a863b6a6d6c7aa Mon Sep 17 00:00:00 2001 From: Felipe Borges Date: Mon, 28 Nov 2022 10:49:03 +0100 Subject: [PATCH] info-overview: Don't show "Firmware Version" row in virtual machines This value comes from systemd-hostnamed, which harvests it from /sys/class/dmi/id/bios_version, which happens to be empty/invalid in virtual machines (at least KVM powered virtualization). For this reason, we are better off hiding the "Firmware Version" row when gnome-control-center is running in a VM. Fixes #2181 --- panels/info-overview/cc-info-overview-panel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/panels/info-overview/cc-info-overview-panel.c b/panels/info-overview/cc-info-overview-panel.c index 9b46eac0e..706a1ae54 100644 --- a/panels/info-overview/cc-info-overview-panel.c +++ b/panels/info-overview/cc-info-overview-panel.c @@ -553,6 +553,8 @@ set_virtualization_label (CcInfoOverviewPanel *self, if (virt == NULL || *virt == '\0') { gtk_widget_hide (GTK_WIDGET (self->virtualization_row)); + gtk_widget_hide (GTK_WIDGET (self->firmware_version_row)); + return; }