Instead of trying to fill the displayed pixbuf with the background
color (and failing at that), just make the pixbuf be an aspect correct
scaled size of the original picture and draw it at the correct offset
on the draw vfunc.
This allows us to get rid of deprecated gtk+ API usage and fixes the
background around the picture ending up black despite de code's
intent.
https://bugzilla.gnome.org/show_bug.cgi?id=740986
Add user dialog crashes if it has been closed and network configuration
changes, because the dialog is already disposed, but on_network_changes
callback is executed. To fix this crash network monitor signal handler
has to be disconnected on dispose.
https://bugzilla.gnome.org/show_bug.cgi?id=742439
Enroll data are used after destroying when closing dialog. It causes
crash while setting label. Therefor we have to store the pointer for
fingerprint button and use it to set the label after destroying the
data.
https://bugzilla.gnome.org/show_bug.cgi?id=741635
Besides using deprecated gtk+ API this color is actually fully
transparent in the current GNOME theme, meaning that the arrow ended
up looking smaller than intended.
https://bugzilla.gnome.org/show_bug.cgi?id=740986
Change default size for avatar cropping to correspond with changes in cheese.
The default size should be based on maximal size of the image instead of
minimal size for cropping.
https://bugzilla.gnome.org/show_bug.cgi?id=739871
Deleting enterprise accounts using act_user_manager_delete_user fails
with error: userdel failed, because enterprise accounts are added
using act_user_manager_cache_user and don't have entries in passwd
file. Thus enterprise accounts should be removed by
act_user_manager_uncache_user.
https://bugzilla.gnome.org/show_bug.cgi?id=727871
Cheese has an internal copy of UmCropArea, and exports the corresponding
um_crop_area_get_type() as part of libcheese-gtk. This leads to a crash
when taking a photo in the avatar chooser, as the control center copy of
the get_type() function is used. Renaming the function in Cheese would
be an ABI break, so at this stage it is best to do the rename in the
control center instead.
https://bugzilla.gnome.org/show_bug.cgi?id=697039
This lines are dead code, because act_user_get_language() returns empty
string if language isn't set. We don't want to fix the condition, because
cc_common_language_get_current_language is wrong for other users.
https://bugzilla.gnome.org/show_bug.cgi?id=737216
If language is unknown and language chooser is cancelled, panel crash
with the following error:
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_path:
assertion 'iter->stamp == priv->stamp' failed
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_value:
assertion 'iter_is_valid (iter, list_store)' failed
(gnome-control-center:24952): GLib-GObject-WARNING **: gtype.c:4221:
type id '0' is invalid
(gnome-control-center:24952): GLib-GObject-WARNING **:
can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)
https://bugzilla.gnome.org/show_bug.cgi?id=738002
If the language chooser is confirmed and no language is selected,
"Other..." is shown as user's language and the following error is printed:
(gnome-control-center:14608): AccountsService-CRITICAL **:
act_user_set_language: assertion 'language != NULL' failed
Autologin widgets are different in height as compared with other widgets,
which looks odd. Put all the widgets in the sizegroups, to have same
height.
https://bugzilla.gnome.org/show_bug.cgi?id=737343
The notification is wider then window for some languages (e.g.
France). This patch allows wrapping, limits chars and changes
margin as a result of discussion on #gnome-design.
https://bugzilla.gnome.org/show_bug.cgi?id=703392
Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.
https://bugzilla.gnome.org/show_bug.cgi?id=736223
Preview has to be generated after default handler of "selection-changed"
signal, otherwise dialog response sensitivity is rewritten (Bug 547988).
Preview also has to be generated on "selection-changed" signal to reflect
all changes (Bug 660877).
https://bugzilla.gnome.org/show_bug.cgi?id=721683
The mechanism of setting label padding had to be changed consequently.
It fixes following warnings:
(gnome-control-center:32638): Gtk-WARNING **: GtkComboBox 0x28bcef0 is mapped but not child_visible
(gnome-control-center:32638): Gtk-WARNING **: GtkComboBoy 0x28bcef0 is mapped but visible=1 child_visible=0 parent GtkNotebook 0x2b86600 mapped=1
The ugly hack to catch when combo is losing focus had to be also removed
and notify::popup-shown is used instead. It fixes when GtkComboBox is wrongly
shown instead of GtkButton due to escape is pressed or active item is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=694325
Before, we were freeing the DateTime instances when closing the dialog
through the close button and always creating new ones on _show().
Now, with the header bar, we go through the delete-event handler which
just hides the dialog, meaning that we leak the dates instanced on
_show().
Clearing the dates on _show() is more robust anyway. Note that we'd
leak even before switching to a header bar when going through the
delete-event handler.
https://bugzilla.gnome.org/show_bug.cgi?id=729181
