Commit graph

188 commits

Author SHA1 Message Date
Rui Matos
1650293719 network: Get the correct widget holding the "connection" object data
The check button isn't a direct child of the GtkListBoxRow instance
that contains the "connection" object data so we are adding the wrong
widget to the "rows" list which then gives us a NULL for "connection"
in really_forget() and making us fail to remove the connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:36 +02:00
Rui Matos
b68f7421c6 network: Just dismiss forget dialog if response is not OK
If the dialog is deleted, for instance, we don't want to take that as
OK.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:34 +02:00
Rui Matos
db62c4f8e6 network: Don't leak a couple of dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
c5b70a7876 network: Remove unused toplevel windows from .ui files
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:02 +02:00
Kalev Lember
f8f420256b network: Fix a possible crash with no active connections
As a precaution, check the return value of get_active_connections to
avoid dereferencing a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=990196
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:22:01 +02:00
Matthias Clasen
4151cf76b0 network: Fix hover highlight in the wifi list
Setting a margin on the list box row widget causes the highlight
not to extend to the edge of the list. Instead, set the margin
on the box inside the row.
2013-08-30 23:37:19 -04:00
Bastien Nocera
4a53e93c69 network: Correctly check for error conditions 2013-08-19 22:34:55 +02:00
Bastien Nocera
0f5122eb9a network: Remove unused include 2013-08-19 22:34:55 +02:00
Yosef Or Boczko
e611930dfb network: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:56:26 +03:00
Alexander Larsson
b0356fdfc7 network: Convert to GtkListBox
https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-07-02 16:19:09 +01:00
Bastien Nocera
d4723d396c network: Fix display of some characters in WiFi AP names
The old interface used to use markup to display Wi-Fi AP names,
but the new one didn't, but we were still escaping the AP name.

https://bugzilla.gnome.org/show_bug.cgi?id=695515
2013-03-26 18:42:17 +01:00
Thomas Bechtold
b5335bf2e7 network: Plug memory leaks
https://bugzilla.gnome.org/show_bug.cgi?id=693879
2013-02-15 13:45:28 +01:00
Volker Sobek
f05d86d3c2 network: Fix typos that prevented building
This fixes commit 6b48994bdb.

https://bugzilla.gnome.org/show_bug.cgi?id=693787
2013-02-14 13:45:13 +01:00
Dan Winship
6b48994bdb network: disable the Hotspot button if the device does not support it
If the wireless device doesn't support either of the two possible
hotspot modes, disable the button. Also, add a tooltip to the button
when it's disabled, explaining why ("device does not support" or
"system policy prohibits").

https://bugzilla.gnome.org/show_bug.cgi?id=675317
2013-02-14 10:02:11 +01:00
Aleksander Morgado
f094cc0e6e Revert "network: Allow compiling against NM 0.9.6"
This reverts commit ec704ab62f.

This will effectively bump again the NM requirement to 0.9.7.995.
2013-02-12 17:42:59 +01:00
Matthias Clasen
a0de63dfad network: Be more careful in ignoring shared connection
It was possible for us to accidentally use the shared
connection for naming all access points.
https://bugzilla.gnome.org/show_bug.cgi?id=692921
2013-02-12 07:57:02 +01:00
Matthias Clasen
cea45f707c network: Improve accessibility
Add accessible names for a number of switches and buttons which
don't have meaningful representation in orca, otherwise.

https://bugzilla.gnome.org/show_bug.cgi?id=693552
2013-02-11 18:22:11 -05:00
Dan Winship
15baea4720 network: display "device state reason", and remove duplicate code
For disconnected/unavailable devices, show the localized
NMDeviceStateReason next to the localized NMDeviceState (and not in
the tooltip). Also, move the code to do this into panel-common rather
to save some duplication.

https://bugzilla.gnome.org/show_bug.cgi?id=676117
2013-02-11 12:46:49 -05:00
Cosimo Cecchi
0969b36a65 network: unfuzzy symbolic buttons and make them square
Use the 'image-button' style class to make symbolic buttons square
(as supported by latest Adwaita), and make sure to use the correct icon
size for all symbolics to avoid fuzzyness.

https://bugzilla.gnome.org/show_bug.cgi?id=693357
2013-02-11 11:43:43 -05:00
Dan Winship
ec704ab62f network: Allow compiling against NM 0.9.6
NM 0.9.7 has still not been released, even as a tarball, so allow
compiling against 0.9.6 (without certain bits of new functionality).

https://bugzilla.gnome.org/show_bug.cgi?id=691721
2013-02-06 16:06:01 -05:00
Dan Williams
fc6753e768 network: support new AP-mode hotspot functionality
Recent NetworkManager can create AP-mode hotspots instead of Ad-Hoc
mode ones, which are less compatible with mobile devices.  Do that
if NetworkManager and the device support it.

https://bugzilla.gnome.org/show_bug.cgi?id=686732
2013-01-30 13:39:16 -05:00
Dan Winship
ebd863e714 network: add net_device_get_valid_connections() and use it everywhere
In addition to simplifying a bunch of places that were calling
nm_remote_settings_list_connections() +
nm_device_filter_connections(), this also ensures we filter out slave
connections everywhere (except when they are the active connection).

https://bugzilla.gnome.org/show_bug.cgi?id=677145
2013-01-30 13:05:34 -05:00
Dan Winship
7246b2b7ef network: fix two net-device-wifi leaks
https://bugzilla.gnome.org/show_bug.cgi?id=677145
2013-01-30 13:05:34 -05:00
Matthias Clasen
e5cc7d8011 network: Break out wifi details code and add editing support
This code is fairly independent of the rest, and we don't want
net-device-wifi.c to become too massive and unmaintainable.

The code in connection-editor/ is fairly similar to
nm-connection-editor, with some simplification because we
currently only edit wireless connections.

The code in wireless-security/ is almost a straight copy
of the same code in nm-connection-editor, with some changes
to the .ui files to make them fit better in the new design.
2013-01-30 13:05:33 -05:00
Matthias Clasen
66b1fe7b45 network: Use same wifi device name throughout
The device list is using the 'disambiguated' name that
nm is giving us. Use the same in the wifi page heading,
instead of hardcoding 'Wi-Fi'.
2013-01-30 13:05:33 -05:00
Matthias Clasen
d6e11db107 network: Fix hotspot switch getting out of sync
When the user switches the hotspot switch off, we present a
confirmation dialog which can be canceled. We do keep the
hotspot running in that case, but we forget to set the switch
back to 'on'. Fix that.
2013-01-30 13:05:33 -05:00
Matthias Clasen
96caacc136 network: Add status label and icon to wifi header
This is part of the design refresh for the network panel.
2013-01-30 13:05:33 -05:00
Matthias Clasen
9f86b03353 network: Add a spinner while connecting
This is part of the new listbox-based design for the
network panel.
2013-01-30 13:05:33 -05:00
Matthias Clasen
d0f0e8c99c network: no more cell renderers
Now that the list has been converted to a listbox, we don't
need any of these anymore.
2013-01-30 13:05:32 -05:00
Matthias Clasen
71dad5e98b network: Initial listbox conversion
This commit turns the main access point list into a listbox,
and moves out-of-range connections into a History dialog.
2013-01-30 13:05:32 -05:00
Cosimo Cecchi
57de0ab019 network: use a GResource for GtkBuilder UI definition
https://bugzilla.gnome.org/show_bug.cgi?id=691132
2013-01-07 10:57:06 +01:00
Jasper St. Pierre
23e51495ee network: Don't reference CcNetworkPanel directly from some helper code
All we need is the toplevel, here, so pass that in directly.

https://bugzilla.gnome.org/show_bug.cgi?id=690086
2012-12-13 11:55:33 -05:00
Dan Winship
63756458b2 network: disambiguate devices of the same type
If there are multiple devices that would end up with the same name in
the device list, disambiguate their names via new libnm-gtk API.

https://bugzilla.gnome.org/show_bug.cgi?id=677143
2012-10-11 09:22:35 +02:00
Bastien Nocera
d5d66b940a network: Clarify some Hotspot related strings
https://bugzilla.gnome.org/show_bug.cgi?id=684202
2012-10-09 10:18:30 +02:00
Matthias Clasen
ea0f359e4d network: Use a regular button for 'Connect to Hidden'
The treeview is not really up to this level of custom UI.

https://bugzilla.gnome.org/show_bug.cgi?id=684819
2012-10-03 11:43:34 +02:00
Matthias Clasen
42d835b3ce network: Further refinements to out-of-range avoidance 2012-10-02 15:11:59 +02:00
Bastien Nocera
75086eb149 network: Fix WPA Enterprise connection not working
https://bugzilla.gnome.org/show_bug.cgi?id=685207
2012-10-02 14:55:59 +02:00
Bastien Nocera
7e708ae52c network: Scope correctly the connection variable 2012-10-02 12:33:15 +02:00
Bastien Nocera
e7e02390b6 network: Add debug for connection activation failures 2012-10-02 12:28:58 +02:00
Matthias Clasen
6264fea2fe Don't try to activate out-of-range connections
It is not going to work...
https://bugzilla.gnome.org/show_bug.cgi?id=684824
2012-10-02 12:07:00 +02:00
Bastien Nocera
ccc3f0bf3c network: Don't resize the panel or the wifi list 2012-09-28 12:21:25 +02:00
Bastien Nocera
4c23703474 network: Remove g_print() debug 2012-09-27 22:39:12 +02:00
Matthias Clasen
52387c58be network: RTL flipping for details arrow
https://bugzilla.gnome.org/show_bug.cgi?id=684604
2012-09-25 13:14:18 +02:00
Matthias Clasen
c3d00a6c44 Make connecting to Enterprise WPA work again
gnome-shell relies on being able to call
gnome-control-center network connect-8021x-wifi <DEVICE> <AP>
This was broken in the big refactoring of the wifi panel
last cycle. Bring it back.
2012-09-22 11:49:34 -04:00
Matthias Clasen
794b89d561 network: Handle activation in the wifi list better
Instead of manually handling button release events on the
treeview, use activatable cell renderers for the ssid text
and for the arrow, and connect to activate signals for them.

We use cell area focus-sibling technology to make the keynav
in the list just have focus locations for the ssid and the
arrow.

This makes the details pages reachable by keynav, which was
not the case before.
2012-09-13 15:50:50 +01:00
Matthias Clasen
292c8b9fe6 network: Don't override cell renderer properties
The mode cell renderer had a property named 'mode', which
clashed with the GtkCellRenderer property of that name, which
confused the treeview keynav.

Rename the new property to ap-mode.
2012-09-13 15:50:49 +01:00
Matthias Clasen
701fb2846f network: Avoid critical warnings
Remove the reference to the new longer existing viewport_list
widget, and be more careful about getting a NMRemoteSettings
object when calculating the last used time.
2012-09-13 15:50:49 +01:00
Matthias Clasen
36958cbf84 network: Improve the wifi list appearance
Use non-symbolic icons for the arrow, and add padding around the
arrow and the check mark.

https://bugzilla.gnome.org/show_bug.cgi?id=682270
2012-09-13 15:50:49 +01:00
Matthias Clasen
17e3c23cd5 network: Remove references to no-longer existing widgets
And also make sure the initial focus on the details page is
always on the back button.
2012-09-13 15:50:47 +01:00
Matthias Clasen
75d815ded3 network: Remove the saved-ap tab
Saved connections without an access point are now shown
in the same tab as all the others.
2012-09-13 15:50:47 +01:00