Commit graph

825 commits

Author SHA1 Message Date
Robert Ancell
01190db349 network: Use g_autoptr for GError handling 2019-09-13 14:20:50 +12:00
Robert Ancell
072d5daf5c network: Add missing warning message about error 2019-09-13 14:20:49 +12:00
Robert Ancell
c27d26e0eb network: Fix GError leaks 2019-09-13 14:15:19 +12:00
Veerasamy Sevagen
9316a77af4 network: Add tooltip text to encrypted connection.
The issue was that sometimes the icon would show an error but we would not know what it is.

Fixes #468
2019-09-11 03:20:55 +00:00
Jonathan Kang
6f3c3f6f6d network: disable the "Apply" button until a change has been made
Previously, when you open the connection editor dialog for each
connection, no matter whether you've made any changes or not, the
"Apply" button became sensetive, which is not what we expected.

Fix that by removing the unnecessary call to password_storage_changed()
while constructing the security tab.
2019-09-09 22:38:44 +00:00
Adrien Plazas
e4de2f5a09 network: Make the rows adaptive
This factorizes the row creation a bit and normalizes the margins and
spacing, reducing the required width. This also makes labels like row
titles and descriptions ellipsizable so the rows can reach narrower
widths.
2019-09-09 22:25:23 +00:00
Adrien Plazas
555ef00b18 network: Use a HdyColumn
This allows the window to reach narrower sizes.
2019-09-09 22:25:23 +00:00
Robert Ancell
97985a664e Remove unused GNOMELOCALEDIR defines 2019-09-09 21:45:53 +00:00
Mohammed Sadiq
ab8aa577e1 wifi: Use HdyDialog for known networks dialog 2019-09-09 21:36:19 +00:00
Mohammed Sadiq
cef992e717 network: Don’t add proxy device if NM isn’t running 2019-08-08 22:53:47 +00:00
Carlos Garnacho
cb9beaa34a
network: Rename section header
The "Bluetooth" section is actually a catchall section for all
device types we don't know much specifically (Includes, but not
limited to Bluetooth).

Rename/relabel it to something more comprehensive.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/issues/488
2019-07-22 17:53:22 -03:00
Jonathan Kang
90af5b87f9 network: Fix mtu label not requesting enough space
Remove the size group where mtu label belongs, so that it can request
enough space when it becomes visible. Since the size group is removed,
filler widget is no longer useful. Remove it as well.
2019-07-15 03:35:59 +00:00
Markus Theil
04f3264c6a network/eap-method-ttls: add domain match
As it is often not sufficient to only check against
a set of known CA certificates, add a domain suffix
check for Wi-Fi connections.

Signed-off-by: Markus Theil <theil.markus@gmail.com>
2019-07-15 15:02:32 +12:00
Iain Lane
566db3a35f network: Handle cloned-mac setting
This can be set to 'preserve', 'permanent', 'random' or 'stable'. We
need to handle these values otherwise we can end up with the editor
being un-saveable.

Turn the entry in to a GtkComboBoxText with those items in it, allowing
a mac address to be typed too.

Partial copy of 85b6b659a140a59c3df787062e089a0b4e2a547d from
network-manager-applet.
2019-06-27 03:37:37 +00:00
Georges Basile Stavracas Neto
c4e8464818 wifi: Show a spinner when scanning for new access points
The spinner was already present in the UI file! It just needs
minor cleanups (such as moving the bottom margin from the label
to the parent box) and binding the widget to the structure.

We need to monitor which device is visible since the Wi-Fi panel
deals with multiple Wi-Fi devices as well.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/issues/551
2019-06-16 01:01:36 +00:00
Georges Basile Stavracas Neto
0d9aa40cf0 wifi: Add device widgets after caching in the array
This will be required to bind the "scanning" property of
the NetDeviceWifi to the GtkSpinner.
2019-06-16 01:01:36 +00:00
Georges Basile Stavracas Neto
e08bc03533 network: Add NetDeviceWifi::scanning property
This is a boolean property that notifies whether the
device is scanning for new access points. This is
implemented by monitoring the NMDeviceWifi::last-scan
property, as suggested by NetworkManager developers
(and due to the lack of a better API), since this
property is updated *after* the scan is completed.
2019-06-16 01:01:36 +00:00
p3732
ed8561ca34 wifi: Reorder icons displayed for wifi access points
Change the layout of the wifi access point rows according to
the new mockups.

Fixes #554
2019-06-16 01:01:36 +00:00
Allan Day
70b668855d network: Equal spacing between list sections
There should be an equal amount of vertical space between each list
section.

Fixes #550
2019-06-16 01:01:36 +00:00
Georges Basile Stavracas Neto
75f150d5a2 shell: Add position to cc_shell_embed_widget_in_header()
So we can control where the widget should be added to. The
main window only supports left and right positions.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/528
2019-05-21 12:59:36 -03:00
scootergrisen
9299e503d1 Remove one of two "Proxy;" in Keywords 2019-05-17 17:30:39 +00:00
Bastien Nocera
3966f33ce8 network: Add "hotspot" keyword to the WiFi panel 2019-05-14 01:55:59 +00:00
Bastien Nocera
2bf154132e network: Add "proxy" keyword to the panel 2019-05-14 01:55:59 +00:00
Florian Müllner
ba328a1993 network: Remove Wifi & friends from keywords
Wifi was split out into a dedicated panel.
2019-04-30 18:08:57 +00:00
Carlos Garnacho
4c31ff5269 network: Handle Infiniband as a wired interface
The configuration/UI we expose for wired settings are meaningful for those
devices as well.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/489
2019-04-23 19:46:32 +02:00
Veerasamy Sevagen
fb130c06d0 panels/network/cc-wifi-connection-row.ui:Setting Connection/SSID as non-translatable.
Set to non-translatable as it is just a placeholder.

This change has been requested by Benjamin Berg(@bberg).

Issue has not been created for this but it was stated in issue#397
2019-03-31 23:22:06 +00:00
Benjamin Berg
8e175bb562 network: Don't shorten names of bluetooth connections
This prevents a single bluetooth connection to be shortened to the name
"Bluetooth", which means we end up with one "Bluetooth" device in the
"Bluetooth" section. Rather, always use the long name of the bluetooth
device so that the user knows what they are connecting to.
2019-03-29 14:08:45 +01:00
Benjamin Berg
77cae9ce72 network: Only show bluetooth devices in Bluetooth section
Historically, the bluetooth section has been the dumping ground for any
device we don't handle in another way. It has had the "Bluetooth" title
for a long time now though, and many of the devices that end up in there
are actually not useful in the GNOME context.

There are some people complaining that we should support these devices
properly, but the status quo does not help any one either really, so
lets remove them entirely for now.

Obsoletes: !203
Fixes: #190
Touches: #167
2019-03-29 14:08:45 +01:00
Benjamin Berg
e5b017f45e wifi: Fix connection names with markup not showing up
In some cases, the network connection UI uses pango markup to denote the
SSID name inside a connection name. However, if the SSID matched the
connection name, then we would end up setting the SSID as pango markup
without it being escaped.

Fix this by escaping the SSID before setting it as markup.

Fixes: #435
2019-03-29 11:15:52 +01:00
Adrien Plazas
0a249441af wifi: Wrap the airplane mode description
This will help the panel fit in narrower windows.
2019-02-19 13:28:37 +00:00
Adrien Plazas
91af270cce connection-editor: Use GtkTemplate 2019-01-27 21:03:13 +00:00
Benjamin Berg
0209694978 wifi: Show WEP with a broken security icon
WEP is rather insecure, and using it is a bad idea in general. So show
it as insecure rather than falsely advertising it as being secure.
2019-01-07 15:30:06 +01:00
Benjamin Berg
d126b3db5e wifi: Hook up new connection list widget 2019-01-07 15:29:23 +01:00
Benjamin Berg
fb7e09eb46 wifi: Add new connection list widget
This widget keep track of connections and APs and automatically
creates/refreshes the corresponding list entries.
2019-01-07 15:29:23 +01:00
Benjamin Berg
eec7841027 wifi: Add set_checked function to connection row 2019-01-07 15:29:23 +01:00
Benjamin Berg
5c81b12647 wifi: Handle multiple APs in a connection row
Note that this also changes the way to detect that the connection is
currently active. This change is not required but but does simplify the
code a little bit.
2019-01-07 15:29:23 +01:00
Benjamin Berg
3962aa3028 wifi: Show the connection name when it is different to SSID
In almost all cases, the SSID will be identical with the connection name
(in fact, we do not even allow modifying the connection name). However,
as it is now, we can end up with multiple connections with the same name
in the list.

Change the list to indicate the SSID separately in a way that will not
result in any changes in the usual case.
2019-01-07 15:29:23 +01:00
Benjamin Berg
8f706f45bd wifi: Remove unused code in wireless_try_to_connect
The code tries to establish a connect by using an existing connection.
However, if that is possible the function will not even be called.

Remove the code in question.
2019-01-07 15:29:23 +01:00
Benjamin Berg
fb089b7c55 wifi: Use new CcWifiConnectionRow widget
This is in preparation to optimise the AP list updating.
2019-01-07 15:29:23 +01:00
Benjamin Berg
0fb86c82d2 wifi: Add new CcWifiConnectionRow widget for the AP list
This is in preparation to optimize list to not be rebuild completely for
every change.
2019-01-07 15:29:20 +01:00
Benjamin Berg
417624cdab wifi: Fix invalid variant unref in connection editor
If the WiFi secret is not set, then a NULL variant is passed back. We
should not free this variant. Fix this by using g_autoptr instead.
2019-01-07 15:28:38 +01:00
Benjamin Berg
88183c0e9f wifi: Remove old and unused column definitions 2019-01-07 15:28:38 +01:00
Benjamin Berg
0922f1095a wifi: Avoid one level of indentation
Convert an if into an early return rather than nesting the entire logic.
2019-01-07 15:28:38 +01:00
Adrien Plazas
943c90074c wifi: Allow the panel to reach narrower sizes 2018-11-26 15:36:34 +01:00
Robert Ancell
41e3426873 network: Fix warning about freeing const string
The use of g_clear_pointer (&str, g_free) with str being a const gchar *
caused warning errors.

Instead of using str for both constant and allocated strings use separate
variables. Autofree the allocated strings.
2018-11-14 10:40:10 +00:00
Georges Basile Stavracas Neto
120eb2f59e
network: Use #pragma once on headers
Another low hanging fruit that reduces even more the
number of lines of code of the headers.
2018-11-05 08:33:22 -02:00
Georges Basile Stavracas Neto
f1347132d9
net-device-mobile: Remove private field from public structure
We can use pointer arithmetics to retrieve the private field.
2018-11-05 08:33:21 -02:00
Georges Basile Stavracas Neto
724c77a1a4
net-device-mobile: Turn into a final class
Exact same case of NetVpn and NetDeviceWifi.
2018-11-05 08:33:21 -02:00
Georges Basile Stavracas Neto
d4a08c48f1
net-device-mobile: Remove macro to get private field
We can just use the standard, non-deprecated G_DEFINE_TYPE_WITH_PRIVATE
and avoid g_type_class_add_private(), which is deprecated now.
2018-11-05 08:33:21 -02:00
Georges Basile Stavracas Neto
5d10d7121b
net-device-ethernet: Turn into a final class
This one did not require any specific changes beyond moving
the struct definition to the .c file, and removing the old
style GObject boilerplate. Remarkably easy.
2018-11-05 08:33:21 -02:00