Commit graph

426 commits

Author SHA1 Message Date
Marek Kasik
1ed138e957 printers: Remove a memory leak
TDevice and PpPrintDevice structures have "host_name" member which
should be freed too.
2014-01-30 14:21:28 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Marek Kasik
69fc7e9fdc printers: Show correct time of print job
g_date_time_new_local() expects month in range 1..12
but localtime() returns month in range 0..11.
g_date_time_new_local() also expects absolute value
for year but localtime() returns number of years since 1900.

Adding 1 to month and 1900 to year fixes this.
2014-01-15 16:59:31 +01:00
Yosef Or Boczko
84c792c7f4 printers: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:28:28 +02:00
Jasper St. Pierre
dd52ac9417 Add NoDisplay to all gnome-control-center panel .desktop files
These aren't apps -- they're simply launchers for gnome-control-center.
They should not be shown as apps in the UI at all.

https://bugzilla.gnome.org/show_bug.cgi?id=712246
2013-11-15 08:44:53 -05:00
Rui Matos
b17bd4ea7e printers: Don't leak a couple of dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Marek Kasik
fa5ed6cd41 printers: Show authenticated Samba servers in the list of new devices
When a Samba server which needs authentication is discovered, add
it to the list of new devices and allow user to authenticate against it
by pressing new "Authenticate" button.
Show only printers available on such a server when authenticated and
remove the server from the list.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:40 +02:00
Marek Kasik
03d463379f printers: Simplify freeing of lists of found printers
Create a dedicated function for freeing of PpDevicesList.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
da28022da6 printers: Handle cancelling of authentication dialog
Add given Samba server to the list of found devices
if authentication dialog was cancelled.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
22f508a7e1 printers: Authenticate Samba servers only when enabled
Add parameter which enables showing of authentication dialog
for Samba servers which need authentication.
Add samba server to the internal list of found devices if it needs
authentication and the authentication is disabled.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
edcd8b1c13 printers: Enable use of emblems for printer icons
Use GIcon instead of icon names in PpNewPrinterDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
be6523b66c printers: Propagate cancellation of authentication dialog
Return "response_id" of PpAuthenticationDialog in its "response" signal.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
203cb82a67 printers: Mark string translatable
Mark string "Enter address of a printer or a text to filter results"
as translatable.

https://bugzilla.gnome.org/show_bug.cgi?id=707083
2013-08-30 10:03:17 +02:00
Yosef Or Boczko
d49a097b3e printer: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:57:53 +03:00
Thomas Wood
537e3336aa printers: prevent the "Options" dialog box from being resizable
https://bugzilla.gnome.org/show_bug.cgi?id=702487
2013-06-18 17:38:38 +01:00
Marek Kasik
bba624e9d3 printers: Don't move to beginning of list of new devices
Don't reset position of tree view containing new devices when
an actualization of the tree view is required.

https://bugzilla.gnome.org/show_bug.cgi?id=693185
2013-05-21 16:24:19 +02:00
Marek Kasik
8e1bfc521e printers: Replace deprecated function
Use gtk_container_add() instead of deprecated
gtk_scrolled_window_add_with_viewport().

https://bugzilla.gnome.org/show_bug.cgi?id=696766
2013-05-15 13:11:27 +02:00
Marek Kasik
8586d99a88 printers: Don't show CUPS deprecation warnings
Hide CUPS deprecation warnings by definition of
_PPD_DEPRECATED="".

https://bugzilla.gnome.org/show_bug.cgi?id=696766
2013-05-15 13:11:26 +02:00
Marek Kasik
72d63e49d1 printers: Don't crash without system-config-printer
Fix error handling in addition of new printer.

https://bugzilla.gnome.org/show_bug.cgi?id=698642
2013-04-24 15:52:42 +02:00
Marek Kasik
323c09e0b2 printers: Preserve width when setting default printer
Allocate fixed space for cell renderer showing icon of default
printer.

https://bugzilla.gnome.org/show_bug.cgi?id=690443
2013-04-23 13:38:48 +02:00
Marek Kasik
8cd8d8bdd2 printers: Show all printer devices
Get devices also from backends which are not hard-coded
in pp-utils.c. This is achieved by searching on all
backends with excluding hard-coded ones in the last search.

https://bugzilla.gnome.org/show_bug.cgi?id=693182
2013-03-14 15:15:36 +01:00
Marek Kasik
76d18ec85d printers: Don't crash after changing an option
Use GCancellable when setting a new value of an option.
This prevents Printers panel from crash caused by
calling of option widget's callback on finalized widget.

https://bugzilla.gnome.org/show_bug.cgi?id=694874
2013-03-04 12:05:18 +01:00
Marek Kasik
1cadc214ef printers: Don't ask for samba password if not needed
Ask for samba password only if returned directory is NULL
and errno is set to EACCES.

https://bugzilla.gnome.org/show_bug.cgi?id=694150
2013-02-19 14:35:06 +01:00
Marek Kasik
f4d1808b8c printers: Improve look of driver selection dialog
Add 10 pixels of padding between list of manufacturers
and list of drivers.

https://bugzilla.gnome.org/show_bug.cgi?id=690448
2013-02-19 14:35:00 +01:00
Allan Day
11bb915c0e printers: Update panel comments
Very few of the panel comments provide information that is very
useful. Update them to supplement the panel descriptions - this
will make the search results more helpful.

https://bugzilla.gnome.org/show_bug.cgi?id=694110
2013-02-19 10:41:43 +01:00
Bastien Nocera
ed896b8060 printers: Use CUPS CFLAGS when compiling 2013-02-18 09:43:15 +01:00
Jeremy Bicha
05e60169ea build: Disable printers panel is libsmbclient.pc isn't found
https://bugzilla.gnome.org/show_bug.cgi?id=693923
2013-02-18 09:42:58 +01:00
Marek Kasik
39071d5b56 printers: Show printer name only in the title of options dialog
The name of the printer is sufficient information to describe the contents of
the dialog. "Options" isn't necessary.

https://bugzilla.gnome.org/show_bug.cgi?id=690424
2013-02-15 18:33:46 +01:00
Marek Kasik
d33f14b70a printers: Move dialog names to their titles
https://bugzilla.gnome.org/show_bug.cgi?id=690447
2013-02-15 18:33:38 +01:00
Marek Kasik
d7f31fc41c printers: Search for samba printers in new printer dialog
Search for samba printers on local network or on specified
host. The new printer dialog asks for password for a samba
server if it is needed for listing printers on it. User is
asked for selection of driver from local database during
addition of new samba printer.

https://bugzilla.gnome.org/show_bug.cgi?id=683229
2013-02-15 18:23:56 +01:00
Marek Kasik
41924f8c75 printers: Add class for searching for samba printers
Add class PpSamba which contains asynchronous function
for searching for samba-shared printers. It can search
for printers on local network or on a specific host if
needed.

https://bugzilla.gnome.org/show_bug.cgi?id=683229
2013-02-15 18:23:53 +01:00
Marek Kasik
8f2d51cb5e printers: Add authentication dialog for samba printers
Add new class PpAuthenticationDialog which shows dialog
requesting username and password. The dialog has 3 parameters.
The first one is a text which will be shown to the user and
the second is username by which username entry will be prefilled.
The last parameter is parent window so thedialog is properly
decorated and positioned.

https://bugzilla.gnome.org/show_bug.cgi?id=683229
2013-02-15 18:23:49 +01:00
Marek Kasik
27aa41f5c1 printers: Visual improvements of driver selection dialog
Make the dialog bigger (600x400). Add padding between list of manufacturers
and the list of drivers. Add padding to manufacturers and drivers lists.
Change Manufacturers and Drivers to singular. Trigger resizing of treeview
when list has changed so it has optimal width.

https://bugzilla.gnome.org/show_bug.cgi?id=690448
2013-02-15 16:07:39 +01:00
Marek Kasik
22d8f1be60 printers: Have nicer icon for default printer
Change icon of default printer from emblem-default-symbolic
to object-select-symbolic. Make it follow the state of the cell
in which it is placed.

https://bugzilla.gnome.org/show_bug.cgi?id=690444
2013-01-16 12:44:21 +01:00
Marek Kasik
50a0f57533 printers: Attach toolbar controlling jobs to list of jobs
Use inline-toolbar style for the toolbar containing
buttons for controlling jobs. Set junctions so it
visually connects with the list of jobs.

https://bugzilla.gnome.org/show_bug.cgi?id=690421
2013-01-16 12:42:39 +01:00
Marek Kasik
3482dd19c9 printers: Control acceptance of jobs with enable switch
Control acceptance of jobs by selected printer together
with switch which controls whether printer is enabled/disabled.

Use word "Stopped" instead of "Paused" for disabled printers.

Show state "Does not accept jobs" if printer is enabled but doesn't
accept jobs.

https://bugzilla.gnome.org/show_bug.cgi?id=678668
2013-01-09 14:25:15 +01:00
Allan Day
95eb8868ac printers: Reduce vertical and horizontal padding
There was too much space between rows and columns. Reduce the
padding a bit.

https://bugzilla.gnome.org/show_bug.cgi?id=690375
2013-01-09 14:17:32 +01:00
Colin Walters
b8e93fb333 printers: Fix build with srcdir != builddir 2013-01-07 12:30:32 +01:00
Cosimo Cecchi
3064425711 printers: use a GResource for GtkBuilder UI definition
https://bugzilla.gnome.org/show_bug.cgi?id=691132
2013-01-07 10:57:15 +01:00
Matthias Clasen
3d27d8caaf shell: Fittsify panels
Make it possible for panels to go all the way to the edge of the
shell. This is particularly important for panels that scroll, such
as the new power panel. All other panels are changed to compensate
for the loss of external padding.

https://bugzilla.gnome.org/show_bug.cgi?id=691229
2013-01-07 10:51:29 +01:00
Marek Kasik
9afed77bde printers: Avoid possible crash
Unlink given PPD file and free its filename
as soon as it is not required. This avoids
possible double free.

https://bugzilla.gnome.org/show_bug.cgi?id=690091
2012-12-12 13:34:58 +01:00
Bastien Nocera
e419ee7d4e panels: Remove unused X-GNOME-Settings-Panel key 2012-12-11 17:09:04 +01:00
Bastien Nocera
3686cf7eb8 shell: Make all control-center plugins static
This makes loading faster, with less I/O, avoids unnecessary
code duplication (around 1k lines shaved), and ensures that
all the panels link and work appropriately.

By the same token, it will stop external panels from being
created, and loaded.

https://bugzilla.gnome.org/show_bug.cgi?id=690036
2012-12-11 17:07:39 +01:00
Marek Kasik
2bd01a70d3 printers: Make error messages clearer
Point to cups-pk-helper for errors originating from cups-pk-helper.

https://bugzilla.gnome.org/show_bug.cgi?id=689983
2012-12-10 17:05:56 +01:00
Jeremy Bicha
190052ff74 printers: Use the proper Unicode ellipsis (…) instead of three dots
https://bugzilla.gnome.org/show_bug.cgi?id=689497
2012-12-03 09:12:47 -05:00
Jeremy Bicha
7e7a690d12 printers: Add more a11y relations, change 'Show' btn to 'Show Jobs'
https://bugzilla.gnome.org/show_bug.cgi?id=688960
2012-11-26 17:49:17 -05:00
Marek Kasik
a153f43b4e printers: Resolve symlink when passing a PPD to CUPS
root is not able to resolve symlinks in /tmp/ created by ordinary users
because of a new policy and PPDs got from CUPS are symlinks to /etc/cups/ppd/*
placed to /tmp/.
Since we need to pass PPD file of original printer to CUPS when renaming
a printer we resolve given symlink and pass original filename to the CUPS.
2012-11-08 13:39:14 +01:00
Jeremy Bicha
e32494f2f0 Show Printers & Region panels in Unity but hide Background
Ubuntu plans to fork a separate Appearance panel this cycle so
that Gnomebuntu can use the GNOME Background panel.

I believe Ubuntu will try to use the Printers and Region & Language
panels instead of system-config-printer & language-selector

https://bugzilla.gnome.org/show_bug.cgi?id=687258
2012-10-31 06:50:05 -04:00
Cosimo Cecchi
420240840a printers: don't override search entry's icon name
GtkSearchEntry already gets it right; this icon should be symbolic and
there's no need to override it.

https://bugzilla.gnome.org/show_bug.cgi?id=684827
2012-09-26 10:55:50 -04:00
Marek Kasik
1eb906515f printers: Use GPLv2+ for files created by Marek Kasik
This commit is related to the bug #683420.
2012-09-11 15:02:26 +02:00