Commit graph

14326 commits

Author SHA1 Message Date
Bastien Nocera
7be584f4f9 wacom: Update from gnome-settings-daemon 2013-10-08 19:25:01 +02:00
Bastien Nocera
297eb6cfbb wacom: Fix use after free
Causing random values in the calibration data.
2013-10-08 18:59:22 +02:00
Bastien Nocera
8e1dd1ae5d wacom: Update from gnome-settings-daemon 2013-10-08 18:55:19 +02:00
Bastien Nocera
4c2c93c01f wacom: Update from gnome-settings-daemon 2013-10-08 18:31:39 +02:00
Bastien Nocera
6aa409ffdb wacom: Reset the calibration before starting a new one
We shouldn't be using the old calibration values to create the
new ones, so reset the "area" settings before starting a new
calibration, and re-apply the saved calibration if the calibration
is cancelled or fails.

https://bugzilla.gnome.org/show_bug.cgi?id=707784
2013-10-08 18:02:43 +02:00
Bastien Nocera
21a2a53fea wacom: Update from gnome-settings-daemon 2013-10-08 17:59:12 +02:00
Bastien Nocera
c9864b1ebc wacom: Fix event filtering in the calibrator
We were always getting the events from the core pointer instead
of the device itself, so threw all of them away.
We need to get the real source device from the event.

https://bugzilla.gnome.org/show_bug.cgi?id=707784
2013-10-08 11:48:13 +02:00
Bastien Nocera
b921ce215f network: Only start the spinner when we can stop it
https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 18:31:59 +02:00
Bastien Nocera
57b64368ef network: Merge two similar functions
Merge connection_add_activate_cb() and connection_activate_cb(),
the code is too similar.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:58:19 +02:00
Bastien Nocera
3c1b58ab2a network: Fix warnings when clicking Wi-Fi network
Those 2 widgets (the edit page, and the spinner) might be available
but we need to read about them from the correct widget, eg. the
GtkListBoxRow, not the GtkBox it contains.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Bastien Nocera
ce8c2eb6f6 network: Fix run-time warning
The "edit" widget is only set as data when there is a connection
(in make_row) so only hide it when there is a connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Gary Ching-Pang Lin
fc181a2d64 network: Use the parameters property for 8021x
The argv property was deprecated. This commit converts the 8021x
settings to the parameters property so that the user is able to
setup the 8021x connections.

https://bugzilla.gnome.org/show_bug.cgi?id=709545
2013-10-07 16:50:13 +02:00
Kalev Lember
4ecb35ca12 background: Fix a memory leak with wallpaper loading
This removes an extra g_object_ref when inserting items to GtkListStore:
the list store takes care of incrementing the reference count itself and
the caller doesn't need to do it.

https://bugzilla.gnome.org/show_bug.cgi?id=709453
2013-10-07 10:35:52 +02:00
Kalev Lember
3491c6625c background: Fix reference counting in background XML loader
Commit b9e3603ba4 added an unref to fix a
memory leak, but it went to a wrong place -- in XML loader, all items
are stored in a hash table that takes ownership of them, and destroyed
when the hash table goes away.

This commit fixes the reference counting in the XML loader and adds
explicit g_object_ref / g_strdup when inserting values to the hash table
to make the memory management more obvious.

The following commit fixes the real leak.

https://bugzilla.gnome.org/show_bug.cgi?id=709453
2013-10-07 10:35:52 +02:00
Kalev Lember
24faa84d05 datetime: Explicitly destroy toplevel dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=709443
2013-10-07 10:35:52 +02:00
Kalev Lember
47fb0c426f Revert "datetime: Don't leak the dialogs"
This caused criticals when on_permission_changed callback tried to
access priv->datetime_dialog or priv->timezone_dialog before they had
been set up.

Another attempt at fixing the leak in the following patch.

This reverts commit 545c886543.

https://bugzilla.gnome.org/show_bug.cgi?id=709443
2013-10-07 10:35:52 +02:00
Kalev Lember
7ae60ad2cf datetime: Disconnect from GtkStack signals before widget destruction
This fixes a regression from commit 545c886 that caused criticals when
leaving the datetime panel.

https://bugzilla.gnome.org/show_bug.cgi?id=709443
2013-10-07 10:35:52 +02:00
Kalev Lember
2234970583 datetime: Store am_pm_stack in priv structure
This is in preparation for the next patch.

https://bugzilla.gnome.org/show_bug.cgi?id=709443
2013-10-07 10:35:52 +02:00
Мирослав Николић
d691a817f9 Updated Serbian translation 2013-10-05 06:35:24 +02:00
Yuri Myasoedov
4d615d4df0 Updated Russian translation 2013-10-04 20:42:21 +04:00
Thomas Wood
17126cc740 display: always label the built in display as "1"
https://bugzilla.gnome.org/show_bug.cgi?id=709168
2013-10-04 15:02:20 +01:00
Debarshi Ray
516e2a624f background: Remove unused variable
Fallout from 79ec684fa4

https://bugzilla.gnome.org/show_bug.cgi?id=708943
2013-10-04 13:40:11 +02:00
Debarshi Ray
7585b836be background: Set the size request only on the parent
Instead of setting the size on each child, set it on the parent grid
because only one of those children are visible at any given point.

We are cheating a bit by ignoring the fact there is a second child
which is always shown -- the button box. This will make the other
children lose some height and the dialog will be smaller. However it is
still too big for smaller screens.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
2013-10-04 13:37:13 +02:00
Debarshi Ray
f06a349a2a Use a consistent set of permissions when creating directories
https://bugzilla.gnome.org/show_bug.cgi?id=709417
2013-10-04 12:10:14 +02:00
Debarshi Ray
9ce45bfd3f background: Be robust against missing directories, and warn otherwise
We want to track the busy state of the source. To do that we will keep
a count of the number of pending operations. Not having a check for
NOT_FOUND makes it slightly easier to do that. Not a big deal, but I
think it outweighs the downfall of showing an extra warning.

Plus we are trying to create the directories before using them, so the
warning means something fishy has been going on with your system.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
2013-10-04 11:52:29 +02:00
Bastien Nocera
054538c292 wacom: Add some more debug to the calibrator tool 2013-10-04 11:16:45 +02:00
Bastien Nocera
55744f6544 wacom: Fix device filtering in calibration UI
We receive ClutterEvents, not GdkEvents for button presses on
ClutterActors, so use the correct functions to filter devices.

This also fixes the offset used to access the coordinates of the
events. We were actually using the pointer to the source and x
struct members instead of x and y.

https://bugzilla.gnome.org/show_bug.cgi?id=707784
2013-10-04 11:16:45 +02:00
Bastien Nocera
387e3f98f7 wacom: Print debug when calibration is finished 2013-10-04 11:16:45 +02:00
Thomas Wood
1288d64952 sharing: ensure the hostname in labels is updated
https://bugzilla.gnome.org/show_bug.cgi?id=698421
2013-10-04 10:12:01 +01:00
Bastien Nocera
752c964c1c wacom: Align the stylus section with the tablet section
https://bugzilla.gnome.org/show_bug.cgi?id=709360
2013-10-04 09:09:34 +02:00
Debarshi Ray
7a843ae428 background: Use the same method to set the initial view and toggle
This makes it simpler for us to track the busy state of the sources.

https://bugzilla.gnome.org/show_bug.cgi?id=708943
2013-10-03 18:55:22 +02:00
Debarshi Ray
176e8c3057 background: Make it possible to use gtkparasite with the test
The dialog has to be non-modal for us to be able to inspect it with
gtkparasite.
2013-10-03 12:59:18 +02:00
Bastien Nocera
1445700c62 background: Align items in debug output 2013-10-02 19:30:14 +02:00
Bastien Nocera
42ddaffc9a background: Dump the selected item in the test program 2013-10-02 19:30:09 +02:00
Bastien Nocera
5d16f81821 background: Fix a memory leak when monitoring directories
Destroy directory monitors on when the XML object is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:27:10 +02:00
Bastien Nocera
ca77b20062 background: Fix double-free when closing the dialog
9955f17d introduced a double-free.
2013-10-02 19:26:09 +02:00
Bastien Nocera
b9e3603ba4 background: Fix memory leak in XML signal handling
When emitted in an idle, the item was correctly unref'ed, but not
when emitting the signal straight away.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:03:02 +02:00
Bastien Nocera
a0ab6d527f background: Fix memory leaks in slideshow handling
A string was leaked when loading the name of the slideshow,
and a file object was left lingering as well.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
9955f17dd4 background: Fix memory leak in background item object
Some fields were never freed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
ed589cd5b8 background: Fix memory leak in Pictures source
The enumerator was never unref'ed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
d331444591 background: Add test program for the selection dialog
https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
c2413a3c3e background: Fix leak of the Flickr source
The Flickr source was never disposed of when destroying the
selection dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
e7433f1629 background: Fix leak of the preview picture
https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
3942035180 background: Fix memory leak in the picture sources
The list store was taking a reference to the background item,
so we need to unref it on our side to avoid leaking it.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
b8626fd50a sharing: Forcefully enable the MediaExport plugin
When enabling DLNA, also make sure to enable the plugin that
we use to export the media to the TV or set-top-box, otherwise
rygel won't export anything.

https://bugzilla.gnome.org/show_bug.cgi?id=708055
2013-10-02 17:53:17 +02:00
Thomas Wood
fa44b21df5 sharing: prevent duplicate folders being selected for media sharing
https://bugzilla.gnome.org/show_bug.cgi?id=706661
2013-10-02 16:42:18 +01:00
Rui Matos
fb9d98bff1 network: Update forget button sensitivity when rows are destroyed
Doesn't make sense to keep it sensitive after the dialog returns OK.

This also avoids using finalized objects if the forget button is
clicked after some previously checked rows were destroyed because
their connection got removed elsewhere.

https://bugzilla.gnome.org/show_bug.cgi?id=709118
2013-10-01 15:09:38 +02:00
Rui Matos
22ff598b78 network: Destroy connection row widget when connection is removed
Otherwise all sorts of crashes may happen if it's interacted with.

https://bugzilla.gnome.org/show_bug.cgi?id=709104
2013-10-01 15:09:37 +02:00
Rui Matos
1650293719 network: Get the correct widget holding the "connection" object data
The check button isn't a direct child of the GtkListBoxRow instance
that contains the "connection" object data so we are adding the wrong
widget to the "rows" list which then gives us a NULL for "connection"
in really_forget() and making us fail to remove the connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:36 +02:00
Rui Matos
b68f7421c6 network: Just dismiss forget dialog if response is not OK
If the dialog is deleted, for instance, we don't want to take that as
OK.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:34 +02:00