2006-03-18 Rodney Dawes <dobey@novell.com>
* gnome-wp-xml.c (gnome_wp_xml_load_list): Only pass G_FILE_TEST_IS_DIR
to the g_file_test calls
Fixes#331486
2006-01-14 Rodney Dawes <dobey@novell.com>
* *.[ch]: Update Copyright notice to include 2006 year
* gnome-background-properties.glade: Change the main dialog to use
explicit apply with OK and Cancel buttons
Remove the icons from the "Add Wallpaper" and "Remove" buttons
* gnome-wp-capplet.c (gnome_wp_props_wp_set): Add a new retval boolean
so that we can return whether or not we are trying to set the wallpaper
to the same image filename as before
Remove all the UI updating code from here
Fix a potential leak of the GConfChangeSet object
(gnome_wp_props_wp_selected): Update the UI whenever a different
wallpaper is selected in the list
Remove the timeout to update gconf, as we are using explicit apply now
(gnome_wp_main_quit): Free the old_filename variable
Update the indentation style to match the rest of the code
(wallpaper_properties_clicked): Handle setting the gconf keys when the
OK button is clicked, and fall through to the cancel/close code
(gnome_wp_scale_type_changed, gnome_wp_shade_type_changed):
Don't set the gconf strings from here, only update when OK is clicked
(gnome_wp_color_changed): Don't update gconf strings here
Don't generate miniature icon thumbnails for the drop-down menu
(gnome_wp_remove_wallpaper): Don't need to remove the idle id any more
(gnome_wp_load_stuffs): Set the old_filename variable to the current
setting that is stored in gconf for the wallpaper filename
(gnome_wp_delay_changed): Remove this unused method
(gnome_wp_icon_theme_changed): Don't need to update the icons in the
drop-down menu here, as they are being removed
(set_accessible_name): Don't need this any longer, as the drop-down
menu items are now standard label menu items, and don't have icons
(wallpaper_properties_init): No longer need the key repeat delay
Fix some style issues with the glade_xml_get_widget calls
Replace the menu items in the option menus with standard label items
* gnome-wp-capplet.h (_GnomeWPCapplet): Remove the no longer needed
Widget variables for updating the drop-down menu icons
Remove the no longer needed delay and idleid variables
Add an old_filename variable to compare against when OK is clicked
Also should fix#316697
2005-10-01 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_add_image): Remove utf8 validate check
(gnome_wp_props_wp_set): If the filename we have for the image is not
valid utf8, convert it to utf8 before setting the key in gconf
(gnome_wp_load_stuffs, gnome_wp_file_changed): Make sure that the
filename is valid utf8 and the file exists with utf8 encoding, or fall
back to filename encoding as specified by the user with glib's
environment variables
* gnome-wpitem.c (gnome_wp_item_new): Make sure that the name field
is always utf8 for displaying to the user with the tree view
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Make sure that the
filename is valid utf8 and the file exists with utf8 encoding, or fall
back to filename encoding as specified by the user with glib's
environment variables
(gnome_wp_xml_save_list): If the filename is not valid utf8, then
convert to utf8 for storing in the XML file
Fixes#168604
2005-07-14 Rodney Dawes <dobey@novell.com>
* gnome-wp-xml.c (gnome_wp_xml_load_xml): If xmlParseFile returns
NULL, then just return, rather than trying to parse the document
Fixes#310041
2005-02-26 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_add_image): If the filename is not
encoded in UTF-8, we just ignore it for now to avoid crashing
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Check to make sure that the
filename and name tags that we read in, aren't NULL
If the filename we read in is NULL, free the item, and continue on
Fixes#146130#146645 (resolving these as dups of #168604 )
Fixes#159441
2005-01-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-xml.c (gnome_wp_xml_load_xml):
Fix compile warning for syslangs declaration
Wrap g_get_language_names in #if GLIB_CHECK_VERSION as it is 2.6 API
2004-12-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_update_description):
Change the description to use "W pixels x H pixels" and ngettext for
each individual part, instead of just "W x H pixels" (#151425)
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Don't duplicate check to
make sure that the root element is not NULL
2004-09-22 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_free):
Check that the colors aren't NULL before calling gdk_color_free
* gnome-wp-xml.c (gnome_wp_xml_load_xml):
Check that the item isn't already listed, before we try to add
the wallpaper to the list
(gnome_wp_xml_load_list): Load XML files from the correct directory
2004-06-28 Rodney Dawes <dobey@novell.com>
* *.[ch]: Update copyright info to have correct years (2003-2004)
* gnome-wp-capplet.c (gnome_wp_capplet_scroll_to_item):
Abstract this code out so that we don't have to duplicated it every
time we want to scroll to a particular item in the list
(gnome_wp_add_image): Update this to return the new item that we
created, and don't scroll to or set as the wallpaper, every time we
call this function
Use the new gnome_wp_item_new () call to create items
(gnome_wp_add_images): Change the API to not use the files argument
any longer, as we don't need it without the GTK+ 2.2 compat code
Add all the items to the list and select the last one when finished
(gnome_wp_file_open_dialog): Update to not pass in the files argument
to gnome_wp_add_images () and free the GSList of filenames
(bg_add_multiple_files): merge this code into the normal callback for
when images are dragged to the dialog
(bg_properties_dragged_image): Don't check if the list is more than
1 or not here, and always call gnome_wp_add_images () with the full
list that we are given
Convert the GList of GnomeVFSURIs that we get from gnome-vfs to a
GSList of char * uris to pass into gnome_wp_add_images ()
(gnome_wp_load_stuffs, gnome_wp_file_changed):
Use the new gnome_wp_capplet_scroll_to_item () and gnome_wp_item_new ()
API calls instead of duplicating code
* gnome-wp-capplet.h: Remove the GConf key path defines from here
* gnome-wp-item.[ch]: Add the gnome_wp_item_new () call to create the
GnomeWPItem structure for storing wallpapers in
* gnome-wp-utils.h: Put the GConf key path defines in here
* gnome-wp-xml.c (gnome_wp_load_legacy): Use the gnome_wp_item_new ()
call to create items from the old legacy (XD2 capplet) list file
2004-02-24 Rodney Dawes <dobey@ximian.com>
* gnome-wp-xml.c (gnome_wp_oad_legacy): Check that the file exists,
and continue through the loop if it doesn't (#135251)
Fixes#135251
2004-02-01 Rodney Dawes <dobey@ximian.com>
* Makefile.am: Switch the binary name to gnome-background-properties,
Based on patch from Seth Nickell
* background.desktop.in: Use gnome-background-properties here also,
based on patch from Seth Nickell
* gnome-wp-capplet.c: Fix a bug where you can't re-add a wallpaper
after you remove it
Use the new gnome_wp_item_update_description () call
Use a GConfChangeSet to change the gconf keys, based on a patch
from Seth Nickell
Select the first item in the list ("No Wallpaper") when the wallpaper
is removed, based on a patch from Seth Nickell
Do the rc string parsing before creating the window, and change some
defaults so we can fix the spacing between widgets and the border
Fix spacing between widgets and window border
* gnome-wp-item.[ch]: Add update_description function to clean up
code, based on patch from Seth Nickell
Fix a crash when trying to thumbnail very wide images that are very
short, while trying to maintain aspect ratio
* gnome-wp-xml.c: Use backgrounds.xml instead of wp-list.xml, and
migrate the old wp-list.xml over if backgrounds.xml doesn't exist
yet, based on patch from Seth Nickell
2004-01-12 Jody Goldberg <jody@gnome.org>
* Makefile.am : As long as we're hard coding the path hard code it in
only one place. Passing in datadir then adding the magic subdir in
C then building in Makefile seems unnecessary.
Use GNOMECC_CAPPLETS_*
