Commit graph

3879 commits

Author SHA1 Message Date
Rui Matos
7a271439c9 universal-access: Remove the mnemonic-activate handler
It's wrong because the label's parent isn't a GtkListBoxRow which
causes a warning.

In any case, we don't need it since GtkLabel already does the work of
finding a suitable parent widget to activate on mnemonic-activate
which ends up causing GtkListBox to fire its row-activated signal that
we already handle.

https://bugzilla.gnome.org/show_bug.cgi?id=708283
2013-10-01 10:04:20 +02:00
Jan-Michael Brummer
209a528561 Sharing: Allow screen sharing approving without remote control enabled
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=703898
2013-10-01 10:03:12 +02:00
Rui Matos
fecc2eca87 network: Correctly unref NetDevice instances when needed
We have to take the GtkListStore own reference into account.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Rui Matos
d8bfc9e937 network/net-device-ethernet: Disconnect from NMConnection signals
Otherwise we'll crash in our handler if the signal fires after we're
finalized i.e. user leaves the network panel.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Debarshi Ray
675bf324f8 background: Remove undefined method declaration 2013-09-30 18:59:37 +02:00
Yosef Or Boczko
50488b1ea0 mouse: Make the test button align better
https://bugzilla.gnome.org/show_bug.cgi?id=708000
2013-09-28 22:16:58 +03:00
Ondrej Holy
da911dce3c mouse: remove unnecessary acceleration value setting
The acceleration value is set twice, because binding already exists.

https://bugzilla.gnome.org/show_bug.cgi?id=708241
2013-09-27 16:09:11 +02:00
Ondrej Holy
1fc4a0c6b6 mouse: do not reset mouse speed when unset
https://bugzilla.gnome.org/show_bug.cgi?id=708241
2013-09-27 16:08:41 +02:00
Bastien Nocera
ba4eb42778 bluetooth: Fix crash when exiting during a connection
If a connection is on-going, make sure to cancel it before
when finalizing the panel, or we will be crashing once
we've finished connecting/disconnecting.

https://bugzilla.gnome.org/show_bug.cgi?id=708478
2013-09-22 22:24:54 +02:00
Matthias Clasen
03212c0237 universal access: Fix non-expanding sliders in zoom options
The behaviour of the GtkBox expand child property changed in
GTK+ 3.10, back to its traditional behaviour: It no longer
propagates up. Propagation is now reserved for the GtkWidget
hexpand property. Therefore, we can get the sliders back
to the way they were in 3.8 by setting hexpand to TRUE.

http://bugzilla.gnome.org/show_bug.cgi?id=708493
2013-09-21 19:51:50 -04:00
Thomas Wood
34c43203ba display: add an option to turn off the display
https://bugzilla.gnome.org/show_bug.cgi?id=707570
2013-09-20 17:45:29 -04:00
Thomas Wood
3e0235fd1a sharing: prevent incorrect sensitivity of the screen sharing password entry
Both the GSettings binding and "require password" switch were attempting to
control the sensitivity of the screen sharing password entry, so allow the
require password switch to control the sensitivity of the parent container
instead.

https://bugzilla.gnome.org/show_bug.cgi?id=703521
2013-09-17 21:18:03 +02:00
Rui Matos
4b16aad36c power: Fix getting the keyboard brightness value
https://bugzilla.gnome.org/show_bug.cgi?id=706040
2013-09-17 21:18:03 +02:00
Rui Matos
c804369526 power: Don't show the estimated battery capacity
Since we don't currently have the data to present a good estimation.

https://bugzilla.gnome.org/show_bug.cgi?id=691187
2013-09-17 18:27:27 +02:00
Kalev Lember
17a8595ddc datetime: Sync AM/PM button's accessible name with the text displayed
Instead of hardcoding the accessible name as "Switch between AM and
PM.", set it to "AM" or "PM" depending on which label the stack switcher
is currently showing.

https://bugzilla.gnome.org/show_bug.cgi?id=708219
2013-09-17 14:31:22 +02:00
Kalev Lember
538032d26f datetime: Use the currently preferred way for setting accessible names
For entries that have labels associated, use the mnemonic relationship; and for
those that don't, set up the accessible name.

https://bugzilla.gnome.org/show_bug.cgi?id=708219
2013-09-17 02:04:58 +02:00
Kalev Lember
9fface8f03 datetime: Remove incorrectly set mnemonics
The mnemonics were pointing to other GtkLabels rather than activatable
widgets and were confusing Orca.

https://bugzilla.gnome.org/show_bug.cgi?id=708085
2013-09-16 11:48:12 +02:00
Joanmarie Diggs
13c0dccd47 Remove the mnemonic-widget property from the "Click Assist" GtkLabel
It was pointing to another GtkLabel rather than an activatable widget.
Plus it was confusing Orca.

https://bugzilla.gnome.org/show_bug.cgi?id=708085
2013-09-16 07:40:55 -04:00
Ondrej Holy
3f8d1ca21e user-accounts: port history dialog to use GtkListBox
Port is necessary to be consistent across panels.

https://bugzilla.gnome.org/show_bug.cgi?id=706239
2013-09-16 13:35:32 +02:00
Kalev Lember
47e8406ed6 datetime: Connect arrow up/down keynav across list boxes
https://bugzilla.gnome.org/show_bug.cgi?id=707942
2013-09-15 16:58:43 +02:00
Rui Matos
0f64dd1a11 network: Fix empty ignore-hosts setting
If the ignore-hosts setting is set to an empty array we were using
unintialized memory.

This also now ignores zero length strings if there are any in the
array.

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:58 +02:00
Rui Matos
fb74444eec network: Don't include spaces in proxy's ignore-hosts setting
We should also ignore any zero length strings resulting from
g_strsplit_set().

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:56 +02:00
Kalev Lember
5f21f92f7f datetime: Plug a small memory leak 2013-09-12 22:32:46 +02:00
Kalev Lember
8a1c1d4386 universal-access: Remove an unused variable 2013-09-12 22:32:46 +02:00
Jasper St. Pierre
a8b83d706b background: Fix crasher when entering/leaving the background panel
g_application_get_dbus_connection() does not return a ref, so we
shouldn't try to free it.
2013-09-12 15:53:41 -04:00
Thomas Wood
02930b74e0 display: ensure the display labels remain visible when dialogs are open
https://bugzilla.gnome.org/show_bug.cgi?id=707930
2013-09-12 14:34:52 +01:00
Thomas Wood
75f6a84999 display: close any open dialog if the panel is destroyed 2013-09-11 15:56:43 +01:00
Rui Matos
aee3f9d82d network: Remove a spurious signal handler
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:46:35 +02:00
Kalev Lember
f8f420256b network: Fix a possible crash with no active connections
As a precaution, check the return value of get_active_connections to
avoid dereferencing a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=990196
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:22:01 +02:00
Thomas Wood
6192dd7fe3 display: disable the "Apply" button until a change has been made
https://bugzilla.gnome.org/show_bug.cgi?id=600225
2013-09-11 14:24:37 +01:00
Alejandro Piñeiro
0b2a0a37b9 universal access: toggle child switch if parent list box row is activated
Focusing on the main view.

https://bugzilla.gnome.org/show_bug.cgi?id=707778
2013-09-11 05:44:29 -04:00
Alejandro Piñeiro
13d567f126 universal access: fixing can_focus value on several main view rows
https://bugzilla.gnome.org/show_bug.cgi?id=707778
2013-09-11 05:44:28 -04:00
Alejandro Piñeiro
efe1062da0 datetime: setting can_focus to true on listbox rows
https://bugzilla.gnome.org/show_bug.cgi?id=707778
2013-09-11 05:44:27 -04:00
Dan Winship
fea9da1b2e network: don't show unmanaged devices
And in particular, in NM 0.9.10, don't show NM_DEVICE_TYPE_GENERIC
devices.

https://bugzilla.gnome.org/show_bug.cgi?id=706868
2013-09-10 15:54:30 -04:00
Bastien Nocera
015d29604a background: Fix debug message
We're never capturing the whole screen, only a single monitor.

https://bugzilla.gnome.org/show_bug.cgi?id=706578
2013-09-10 16:15:34 +02:00
Bastien Nocera
fd4cf7b881 background: Fix top bar location on dual-head
For testing:
xrandr --addmode VGA1 1024x768
xrandr --output VGA1 --mode 1024x768 --left-of eDP1

https://bugzilla.gnome.org/show_bug.cgi?id=706578
2013-09-10 16:15:31 +02:00
Bastien Nocera
a2872ff123 background: Remove empty finalize functions
They were just chaining up.

https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:56 +02:00
Bastien Nocera
00d8f80586 background: Use g_clear_* helpers when possible
https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:37 +02:00
Debarshi Ray
531989217e display: Silence -Wmaybe-uninitialized 2013-09-09 16:17:56 +02:00
Debarshi Ray
0c1ac731ff network: Silence compiler warning
Use an explicit typecast from gpointer to const gchar **.
2013-09-09 16:17:56 +02:00
Debarshi Ray
cc17b9d471 background: Don't access possibly invalid object
The previous value of CURRENT_BG may not be valid after a call to
update_preview.

https://bugzilla.gnome.org/show_bug.cgi?id=707569
2013-09-09 15:12:55 +02:00
Bastien Nocera
e267515ed6 network: Disconnect from signal on finalize
The connection editor connects to permission-changed on its NMClient,
but didn't disconnect from that signal when dropping the NMClient
reference in finalize.

https://bugzilla.gnome.org/show_bug.cgi?id=700989
2013-09-07 19:09:22 -03:00
Jasper St. Pierre
84b186803e Update gvc 2013-09-04 13:01:13 -04:00
Marek Kasik
fa5ed6cd41 printers: Show authenticated Samba servers in the list of new devices
When a Samba server which needs authentication is discovered, add
it to the list of new devices and allow user to authenticate against it
by pressing new "Authenticate" button.
Show only printers available on such a server when authenticated and
remove the server from the list.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:40 +02:00
Marek Kasik
03d463379f printers: Simplify freeing of lists of found printers
Create a dedicated function for freeing of PpDevicesList.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
da28022da6 printers: Handle cancelling of authentication dialog
Add given Samba server to the list of found devices
if authentication dialog was cancelled.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
22f508a7e1 printers: Authenticate Samba servers only when enabled
Add parameter which enables showing of authentication dialog
for Samba servers which need authentication.
Add samba server to the internal list of found devices if it needs
authentication and the authentication is disabled.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
edcd8b1c13 printers: Enable use of emblems for printer icons
Use GIcon instead of icon names in PpNewPrinterDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Marek Kasik
be6523b66c printers: Propagate cancellation of authentication dialog
Return "response_id" of PpAuthenticationDialog in its "response" signal.

https://bugzilla.gnome.org/show_bug.cgi?id=698532
2013-09-03 22:09:39 +02:00
Debarshi Ray
52a3f0a99e online-accounts: Increase the height of the "Add Account" dialog
... to accommodate the list of Chat providers.

https://bugzilla.gnome.org/show_bug.cgi?id=707285
2013-09-03 13:27:38 +02:00