Commit graph

8 commits

Author SHA1 Message Date
Jens Granseuer
07ac9b7c5d fix critical warning when music directory isn't set
2008-07-28  Jens Granseuer  <jensgr@gmx.net>

	* sound-theme.c: (get_sound_filename): fix critical warning when music
	directory isn't set

	* (setting_column_edited): fix more leaks

	* (theme_changed_custom_reinit): when resetting a theme, also reset
	the preview icon status

svn path=/trunk/; revision=8816
2008-07-28 20:51:28 +00:00
Jens Granseuer
0a36199bb6 plug some leaks, simplify and/or clarify some code
2008-07-28  Jens Granseuer  <jensgr@gmx.net>

	* sound-theme.c: (load_index_theme_name),
	(set_combox_for_theme_name), (theme_combobox_changed),
	(setup_sound_theme), (get_sound_filename), (dump_theme),
	(setting_column_edited), (setup_sound_theme_custom): plug some leaks,
	simplify and/or clarify some code

svn path=/trunk/; revision=8815
2008-07-28 20:12:58 +00:00
Jens Granseuer
0b295549dd don't preview sounds for insensitive rows
2008-07-28  Jens Granseuer  <jensgr@gmx.net>

	* sound-theme.c: (custom_treeview_button_press_event_cb): don't
	preview sounds for insensitive rows

svn path=/trunk/; revision=8814
2008-07-28 19:45:24 +00:00
Bastien Nocera
5cc13a9b71 When selecting a non-custom sound (such as disabled, or builtin), don't
2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* sound-theme.c (setting_set_func), (fill_custom_model),
	(save_sounds), (count_customised_sounds), (setting_column_edited):
	When selecting a non-custom sound (such as disabled, or builtin),
	don't remove the previous custom file's filename from the tree store,
	When a custom file was previously selected, always show it in the
	combo box drop-down (Closes: #545055)


svn path=/trunk/; revision=8812
2008-07-28 18:29:54 +00:00
Bastien Nocera
ee2b7e711b When selecting custom files, listen to "update-preview", and try to play
2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* sound-theme.c (play_sound_preview), (get_sound_filename):
	When selecting custom files, listen to "update-preview", and try
	to play everything that the user might select (Closes: #545056)


svn path=/trunk/; revision=8810
2008-07-28 17:35:38 +00:00
Bastien Nocera
2f22b9318e Fix permissions on the custom theme directory, otherwise not even the user
2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* sound-theme.c (save_custom_theme): Fix permissions on the
	custom theme directory, otherwise not even the user can read the files
	in there


svn path=/trunk/; revision=8808
2008-07-28 14:45:41 +00:00
Lennart Poettering
2d9043878a Pass 'cache control' and 'enable' properties to ca_gtk_play_for_widget()
svn path=/trunk/; revision=8807
2008-07-28 14:11:36 +00:00
Bastien Nocera
2cac70eea3 Remove libsounds and esound usage, check for libcanberra instead (Closes:
2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* Makefile.am:
	* configure.in: Remove libsounds and esound usage, check for
	libcanberra instead (Closes: #542979)

2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* theme-util.c:
	* theme-util.h: Remove the directory deletion helpers, and
	move them to the common sub-directory

2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* Makefile.am:
	* capplet-util.c (directory_delete_recursive),
	(capplet_file_delete_recursive):
	* capplet-util.h: Move directory deletion helper function
	from the appearance capplet into a common directory

2008-07-28  Bastien Nocera  <hadess@hadess.net>

	* Makefile.am:
	* sound-properties-capplet.c (create_dialog), (setup_dialog),
	(get_legacy_settings):
	* sound-properties.glade:
	* sound-theme-definition.h:
	* sound-theme-file-utils.[ch]:
	* sound-theme.[ch]: Remove separate bell settings tab, remove
	libsounds dependency, add freedesktop sound theme support through
	libcanberra (Closes: #542979)


svn path=/trunk/; revision=8802
2008-07-27 23:32:35 +00:00